Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221118190109.1512674-1-namhyung@kernel.org> <dea8c3c5-0739-58c1-9a88-b989878a9b8f@linux.dev>
 <CAM9d7cjk_7-ALzW1kT961TRLpO9Wt8gNX7+rH4ay4N92g1TYkg@mail.gmail.com> <7ec772fb-2108-5945-a308-4bb46fcf0090@linux.dev>
In-Reply-To: <7ec772fb-2108-5945-a308-4bb46fcf0090@linux.dev>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 9 Jan 2023 14:25:44 -0800
Message-ID: <CAM9d7cgb=NjRLt9i00RaOmseLytOF4WMRAXyFiH3LnuVnGHCZQ@mail.gmail.com>
Subject: Re: [PATCH] perf lock contention: Do not use BPF task local storage
To:     Martin KaFai Lau <martin.lau@linux.dev>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, Song Liu <song@kernel.org>,
        bpf@vger.kernel.org, Blake Jones <blakejones@google.com>,
        Chris Li <chriscli@google.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 9, 2023 at 1:23 PM Martin KaFai Lau <martin.lau@linux.dev> wrote:
>
> On 1/9/23 12:56 PM, Namhyung Kim wrote:
> > Hello,
> >
> > On Mon, Nov 21, 2022 at 9:33 AM Martin KaFai Lau <martin.lau@linux.dev> wrote:
> >>
> >> On 11/18/22 11:01 AM, Namhyung Kim wrote:
> >>> We could fix the task local storage to use the safe BPF allocator,
> >>> but it takes time so let's change this until it happens actually.
> >>
> >> I also got another report on the kfree_rcu path.  I am also looking into this
> >> direction on using the BPF allocator.
> >
> > Any progress on this?  Are there any concerns about the change?
>
> Yep, I am working on it. It is not a direct replacement from kzalloc to
> bpf_mem_cache_alloc. eg. Some changes in the bpf mem allocator is needed to
> ensure the free list cannot be reused before the rcu grace period. There is a
> similar RFC patchset going into this direction that I am trying with.

I see.  Thanks for the update!

Namhyung