Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAHk-=wjwrqFcC9-KkfboqATYwLfJHi_8Z5mTrJh=nf8KT_SjUA@mail.gmail.com>
 <20230109174742.GA1191249@roeck-us.net> <CAHk-=whC+YpdympyegB0Wr_0_6=LYggdabkMExRus2DtAdsv-Q@mail.gmail.com>
In-Reply-To: <CAHk-=whC+YpdympyegB0Wr_0_6=LYggdabkMExRus2DtAdsv-Q@mail.gmail.com>
From:   Marco Elver <elver@google.com>
Date:   Mon, 9 Jan 2023 23:29:54 +0100
Message-ID: <CANpmjNOmDp_sZgRuks3OZfT015vLwSKcfdFFC=yLGPUNOxnecg@mail.gmail.com>
Subject: Re: Linux 6.2-rc3
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Kees Cook <kees@kernel.org>, Jaegeuk Kim <jaegeuk@kernel.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Max Filippov <jcmvbkbc@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 9 Jan 2023 at 23:18, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
[...]
> > kernel/kcsan/kcsan_test.c: In function '__report_matches':
> > kernel/kcsan/kcsan_test.c:257:1: error: the frame size of 1680 bytes is larger than 1536 bytes
> >
> > Context: CONFIG_SLUB_TINY is enabled with allmodconfig builds.
> > This enables some previously disabled configurations and disables
> > some previously enabled configurations.
>
> I do think that the test code should be a lot more careful about
> random things on stack.
>
> We've had this before with the EXPECT() macros generating *much* too
> much stack space, and it's not ok for test code to violate kernel
> coding standards even if it might be a "odd config that isn't
> realistic".
>
> That function does some odd things, including
>
>         typeof(observed.lines) expect;
>
> WHAT IS THAT TYPE? It turns out that we have
>
>   static struct {
>         spinlock_t lock;
>         int nlines;
>         char lines[3][512];
>   } observed = {
>
> so it's basically a 1.5kB byte array.
>
> And then des
>
>                 char tmp[2][64];
>
> to add some more pressure. So yeah, can't blame the compiler being
> stupid, this is just bad code.
>
> This is all very much a "this needs to be fixed, or the test just
> needs to be removed, because that's not acceptable".
>
> None of this is new, but clearly it was hidden by config issues
> before. Added the guilty parties.

The 1.5kB array is being fixed by
https://lore.kernel.org/lkml/20221231004514.317809-1-jcmvbkbc@gmail.com/
-- I suppose it's fair if you'd like to pull that patch right away, or
wait for the next PR from the xtensa tree (Cc Max).

Thanks,
-- Marco