Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 01:18:31 +0300
From:   Cyrill Gorcunov <gorcunov@gmail.com>
To:     Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Eric Biederman <ebiederm@xmission.com>,
        Kees Cook <keescook@chromium.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>, kernel@collabora.com,
        peterx@redhat.com, david@redhat.com, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] mm: implement granular soft-dirty vma support
Message-ID: <Y7ySt0XGnbzTyY6T@grain>
References: <20221220162606.1595355-1-usama.anjum@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221220162606.1595355-1-usama.anjum@collabora.com>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk

On Tue, Dec 20, 2022 at 09:26:05PM +0500, Muhammad Usama Anjum wrote:
...
>
> +static inline int nsdr_adjust_new_first(struct vm_area_struct *new, struct vm_area_struct *vma)
> +{
> +	struct non_sd_reg *r, *r_tmp, *reg;
> +	unsigned long mid = vma->vm_start;
> +
> +	list_for_each_entry_safe(r, r_tmp, &vma->non_sd_reg, nsdr_head) {
> +		if (r->start < mid && r->end > mid) {
> +			reg = kmalloc(sizeof(struct non_sd_reg), GFP_KERNEL);
> +			if (!reg)
> +				return -ENOMEM;
> +			reg->start = r->start;
> +			reg->end = mid;
> +			list_add_tail(&reg->nsdr_head, &new->non_sd_reg);
> +
> +			r->start = mid;
> +		} else if (r->end <= mid) {
> +			list_move_tail(&r->nsdr_head, &new->non_sd_reg);
> +		}
> +	}
> +	return 0;
> +}

Hi Muhhamad, really sorry for delay. Please enlighten me here if I get your
idea right -- every new VMA merge might create a new non_sd_seg entry, right?
And this operation will be applied again and again until vma get freed. IOW
we gonna have a chain of non_sd_reg which will be hanging around until VMA
get freed, right?