Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6952628rwl; Mon, 9 Jan 2023 15:39:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXuehn15ZArK26Yrq0R23lF1zEJmr8pGWVO2b6kIW1zUN9DwOyJCEY0tpx9NkSce8M4e72Yj X-Received: by 2002:a05:6402:2497:b0:48e:b020:6c14 with SMTP id q23-20020a056402249700b0048eb0206c14mr30624172eda.26.1673307570350; Mon, 09 Jan 2023 15:39:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673307570; cv=none; d=google.com; s=arc-20160816; b=IFEKb6HbrbSJCq5bcFuz6eZ1OcYet3xcatZ0iRLjYzdVauVGxlEO5DSfBTpaaUzZsE qDJ9yF7wCOgpM0Beqws4ftCdimNFMLEnrwP00SxrLuGeUjOSZC4SdRVIyGk2zk+uI5+X wMnZ8me5ttItoey670Sn767F+MryOf8X6iibKbGtXxr3TEtakshPrLpGcSbOW7aVm22u LnY+tKaA5r5P+HwgDaq0Kjs4OmSXejRxBTeE0Hrg/fUPczePM/PW6z9FR7Zjit8DJZt1 7yy9i0+WGexi1apkQi8/aW3G5wavvQ/OfSXVSiCQu4ZQRLIhNwW2I6oPGNmuusSDXV+3 S2gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=g/cvNab0UVqQrwLLdidvTsUqTZD9TEA9knBaZUuG2Gg=; b=roKs8HYmY9xuIeklSXVta1rb/+ztGcv43uoIjj+xKZNUhNVTZo2mCwEgF7ZXUhXgQl RMnbKkEl7CWnUv6EvfKfwBAuk8UDtai0bboyGJ9RP9nCeQ5F2bDjdEV0r38LR6nvxDyg 9SYO4Aih0c3/UHnHXgeyzyfDTBvWeEMd42GoA1h6CvNx4eTEBNAwG8eULAiFjJSCzdOi JbPiERQ2Ld8a7c1W2KAm3cNqs+bNPvqKgNDC7adzPzOOihSefBFbrCiFVJMcZzASE7IJ oessFs9sxMD3eBNqXybo3wPJJEXVg3romdGEDvNoBnva0k3rC9aIHm2V+etZjHwhZcQk HI3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=GT7StzQA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cn25-20020a0564020cb900b0048c4f4dc16bsi9305195edb.358.2023.01.09.15.39.17; Mon, 09 Jan 2023 15:39:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=GT7StzQA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235601AbjAIXPH (ORCPT + 53 others); Mon, 9 Jan 2023 18:15:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237647AbjAIXOu (ORCPT ); Mon, 9 Jan 2023 18:14:50 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B78C13BE87 for ; Mon, 9 Jan 2023 15:14:49 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id r18so6966811pgr.12 for ; Mon, 09 Jan 2023 15:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g/cvNab0UVqQrwLLdidvTsUqTZD9TEA9knBaZUuG2Gg=; b=GT7StzQARo45EtczBA++lJVu3K7Qqudxsxj/D07FBbT6r8GFWnZqVTHSCrcUPxhn4W pdmcIFoQrhDYJC7b5nVkq4FHQZ1iaKvc7ivP4DcWQUqz62KEmqTd/EkjS2djjtqIE1kM 6QcB7AxEvhaHsPwWxClW340BPwS+odIOHmyC0FEAwVNC+fz4XG9ELHLSTqU8qmw0imV4 0F/4xDcRwMEBcOoUywl/7NASq+Wz6qZEZQVStNMeE+n878QenlZmBgY29Vj1lKhi31Q0 IS+spdo82p1ZmHnm1xKtd0Q4KgzHCYttRE3oGRiZ++qiax+lcP9HbEV3aVZnEx3ibfCO zp1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g/cvNab0UVqQrwLLdidvTsUqTZD9TEA9knBaZUuG2Gg=; b=o2kV3VjSp1O3SFWLzT4tf+/pOsDg87zC8Ok3waLTqajLVic1Ju+I0x3NmQtuF6ywT2 cJCrtn8S0EsSeTHUwxecSGCICJDFkTnBZxcpG63jlu0NWT7LnntKME2SU29XarfsTbdx s+Fd69M1eH3d1r1R1u4KGmwtiyZnKpRsUav8D3CijbQcQlwFWxhuxc2fmg960Xv0ZoZH zfNhrGMMX41V5NNAtvLwI6y3ejz0SJGqDiwrxOMWHDeNKdMiI2z83TOgMtYWYh94p+eA rLmAj9r62fjvx2e+eN04DBxYzICj8F27qIYTZdS309ODvP6egmJiIlnSrTFakwB2f2wf nqhg== X-Gm-Message-State: AFqh2kqCdC+rNZnQ3up0mRLN7Y2zgp7mVGBsLsZWaECWeGr+Fyo70fnZ VwZWyZv0Pz47Y8ngTWa75PUQPQ== X-Received: by 2002:a62:1484:0:b0:587:9e50:3af9 with SMTP id 126-20020a621484000000b005879e503af9mr1437822pfu.0.1673306089205; Mon, 09 Jan 2023 15:14:49 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id i131-20020a628789000000b00573eb4a775esm6803982pfe.17.2023.01.09.15.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 15:14:48 -0800 (PST) From: Jens Axboe To: asml.silence@gmail.com, Dmitrii Bundin Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230109185854.25698-1-dmitrii.bundin.a@gmail.com> References: <20230109185854.25698-1-dmitrii.bundin.a@gmail.com> Subject: Re: [PATCH] io_uring: remove excessive unlikely on IS_ERR Message-Id: <167330608847.5627.8808533650294290115.b4-ty@kernel.dk> Date: Mon, 09 Jan 2023 16:14:48 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12-dev-cc11a X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 09 Jan 2023 21:58:54 +0300, Dmitrii Bundin wrote: > The IS_ERR function uses the IS_ERR_VALUE macro under the hood which > already wraps the condition into unlikely. > > Applied, thanks! [1/1] io_uring: remove excessive unlikely on IS_ERR commit: 119fda37c54736ea65a669273d0b3c394c99a75c Best regards, -- Jens Axboe