Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 07:47:43 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Eric DeVolder <eric.devolder@oracle.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
Subject: Re: [PATCH v16 7/7] x86/crash: add x86 crash hotplug support
Message-ID: <Y7ynnzmfy+Kxj8hQ@fedora>
References: <20230105151709.1845-1-eric.devolder@oracle.com>
 <20230105151709.1845-8-eric.devolder@oracle.com>
 <Y7vD6bm9xy9uyvRD@fedora>
 <bc4ade74-dcbc-88f6-2d88-2bd4c2be38ba@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bc4ade74-dcbc-88f6-2d88-2bd4c2be38ba@oracle.com>
Precedence: bulk

On 01/09/23 at 01:43pm, Eric DeVolder wrote:
> 
> 
> On 1/9/23 01:36, Baoquan He wrote:
> > On 01/05/23 at 10:17am, Eric DeVolder wrote:
> > ......
> > > @@ -394,10 +409,37 @@ int crash_load_segments(struct kimage *image)
> > >   	if (ret)
> > >   		return ret;
> > > -	image->elf_headers = kbuf.buffer;
> > > -	image->elf_headers_sz = kbuf.bufsz;
> > > +	image->elf_headers	= kbuf.buffer;
> > > +	image->elf_headers_sz	= kbuf.bufsz;
> > > +	kbuf.memsz		= kbuf.bufsz;
> > > +
> > > +	if (IS_ENABLED(CONFIG_CRASH_HOTPLUG)) {
> > > +		/*
> > > +		 * Ensure the elfcorehdr segment large enough for hotplug changes.
> > > +		 * Start with VMCOREINFO and kernel_map.
> > > +		 */
> > > +		unsigned long pnum = 2;
> > > +
> > > +		if (IS_ENABLED(CONFIG_HOTPLUG_CPU))
> > > +			pnum += CONFIG_NR_CPUS_DEFAULT;
> > > +
> > > +		if (IS_ENABLED(CONFIG_MEMORY_HOTPLUG))
> > > +			pnum += CRASH_MAX_MEMORY_RANGES;
> > 
> > Logic of pnum calculating is a little confusing to me. If I only enable
> > one of CONFIG_HOTPLUG_CPU and CONFIG_MEMORY_HOTPLUG, is it OK? Say I
> > only enable CONFIG_HOTPLUG_CPU and CONFIG_SMP, on x86_64,
> > CONFIG_NR_CPUS_DEFAULT will be 64. pnum will be 64, is it OK. Am I miss
> > anything?
> 
> Ah, your understanding is correct, and the issue you point out I need to fix.
> Specifically is only one of HOTPLUG_CPU or MEMORY_HOTPLUG is set, then I need
> to allow a default for the other. Using the example you have above, there would
> not be room for a single memory region, so I need to allow for a default number
> of memory regions.

Hmm, for the above example, should we get real number of memory
regions? I am worried if the default number of memory regions 
need be big enough. Because on system w/o memory hotplug, it could have
very many memory regions. The cpu number is similar.