Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Geethasowjanya Akula <gakula@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>
Subject: Re: [net PATCH] octeontx2-pf: Use GFP_ATOMIC in atomic context
Thread-Topic: [net PATCH] octeontx2-pf: Use GFP_ATOMIC in atomic context
Thread-Index: AQHZJMjHQXU1h4wUiU6krrAQOSBT1g==
Date:   Tue, 10 Jan 2023 07:54:34 +0000
Message-ID: <DM6PR18MB26020126CE7BB48D3C2AEC26CDFF9@DM6PR18MB2602.namprd18.prod.outlook.com>
References: <20230107044139.25787-1-gakula@marvell.com>
 <Y7rAUVXiRNFsuR8y@unreal>
 <DM6PR18MB2602C7D1546455B12340D140CDFF9@DM6PR18MB2602.namprd18.prod.outlook.com>
In-Reply-To: <DM6PR18MB2602C7D1546455B12340D140CDFF9@DM6PR18MB2602.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wsBOLk7Z0y37XE132F8oMqgVpQyAj+X+HSVIdmRi0UMssxtUCernejfK955k?=
 =?us-ascii?Q?rEqNPq0zQIarFZTIKiiuOiOke8qdnA9WQov5YOgFs+uzGafEbEp1bkpAhUvA?=
 =?us-ascii?Q?GYPpKoT3tteiD4VscV6RGIKbIYYcDAx1C3aOFYPghBZXw3ssCe4/Bo2xlAKg?=
 =?us-ascii?Q?eMF+RdYmcN4qJAPAHBlXyQpuRY/UyreS/NZyAlQ/MhXSosCsryF4RiTxM5FB?=
 =?us-ascii?Q?QmkUmycTcB3eYhBm6vXxd41VbOW6BvpOlq/xhHuw0EFF/bFEqb3ursyndV2M?=
 =?us-ascii?Q?9g3f/RgYMWvhnOPd7dcSKsqLq1mOUgtgslexFjY2L19R+LK0dhMmOr+x1sJE?=
 =?us-ascii?Q?p4K8KL9jbPJ9K7nzEPW/M9Bsy43gfX3tENLAbhdlstD0owlydqCw4oNFC5Vm?=
 =?us-ascii?Q?/uZPWtjUqIh8lzTDk6w6wQN+0vhEEB21pFHqvZ+b7ozAdyh4q4VNNA1sQdEI?=
 =?us-ascii?Q?KpUmEBTcBnkQszyelhJ10c9qCZiSMubuiExQ5WJ27VczIBJslf8WQ/9ypcU1?=
 =?us-ascii?Q?WUxjoFTpJ5dRV69QnYyE35S4S0Ubf27KoFhOm6Vxx3er6cm51iWaWlJQHd9P?=
 =?us-ascii?Q?lire5WPiQBPJrcjzwcxTRiIbd7YNjnwVtpkdvPixT+5LgxAxBEHOre5OtjWT?=
 =?us-ascii?Q?a1Q3Yk8D0h/5za68MRYyTrUddi45QRbMmdT44S8knxAUKGD4mkLar7LSItdM?=
 =?us-ascii?Q?WYIGhQgUZuOIVy/19K1LyqOw9UbjSRlg75wwcRQjSUNVKRsONwsJ1xeJbPPQ?=
 =?us-ascii?Q?C3Y4kuuWIrKh3rA9Irlg7LmBjZxAiUUpYO2tXmtnZgCYlsFBeu4w9yTWUs8I?=
 =?us-ascii?Q?Xw1ZIvzXzm6fyeeD8/wNsqUI3L+2LbZVJDQ+vrZQZ5BXzJQ6fCQGS9QZsbYj?=
 =?us-ascii?Q?NQ88ot48PdzArsTPo19DjLcIUw4vkuliWoJVZg1c/FIoUwc7zvUVyayTEUNy?=
 =?us-ascii?Q?Outn8hx502twENF/uNHKfyqrH+0hFUOid3TRcFvvICLsXBNRuHTGVQWeusyD?=
 =?us-ascii?Q?y65F+PvHmxYl/+UR9z/M43mIhb/tsKZlt/xHt4pfirEIS8KgKn/vnYpmRUfg?=
 =?us-ascii?Q?di9ulYF6/0KaReZXngHFQqQ3FIItDYwK9c42c+DA5I3RTJ5AD9vbY4NyS0Gw?=
 =?us-ascii?Q?cSHuz8rtMTZ3vxzdI7Co0/a4hiZngwF9WnUBT+YJ+KUQMWSTiabMOkRDjsXu?=
 =?us-ascii?Q?Iewl5Bga/CYrTpxFg1nOzDSBRKG0Gr7PpDgiX+49Ggl2lJ1JzqneKVCDWSWv?=
 =?us-ascii?Q?0y7yUAu9tDWVabITT/jMfIEKpOTO5EUaA1ZGnGCjhNyaqi7YP5TXNoNiJxBU?=
 =?us-ascii?Q?xnRiEh+bRQfYlrGdpUuxqo16hRBnq71A+0EDUOGkwUyP/c2FG6MfLkthlIAC?=
 =?us-ascii?Q?hQTa7G2cRDTuQHflyFEGXlVg/dhDx3w238K1yn5L7aRLEEI50eWAHu8igbIk?=
 =?us-ascii?Q?o6Kz3nqr/o3cFzKRmVS8aZvMMhy27i0DGptGt1iZGKZmeToPdeQgWsnlCpii?=
 =?us-ascii?Q?/X39e/gtFGcdtIZzA17/0XbYCSju8XdEZNxu4dW67i8VDY8p8QIoYMDl9btm?=
 =?us-ascii?Q?IvLkf+Vgb/L470gSGTEZQFFXZJlm0EvQLSuIx4QB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB2602.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c81462f-1e3f-4ddb-1a0d-08daf2dfea0c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 07:54:34.4324
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BUHJcbdhfRh9iXMpx56yymIxMCoqMVQmDi8FNr/rw/PleSD9u5OLrX0J1ndOaKesH3JxSNIMcVCv6wTUV/8U3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3610
X-Proofpoint-ORIG-GUID: pp_kBbWSUw6Ot0Ok3rJpmbYa8iR81_42
X-Proofpoint-GUID: pp_kBbWSUw6Ot0Ok3rJpmbYa8iR81_42
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-10_02,2023-01-09_02,2022-06-22_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


-----Original Message-----
From: Leon Romanovsky <leon@kernel.org>
Sent: Sunday, January 8, 2023 6:39 PM
To: Geethasowjanya Akula <gakula@marvell.com>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kuba@kernel.org; =
pabeni@redhat.com; davem@davemloft.net; edumazet@google.com; Subbaraya Sund=
eep Bhatta <sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>; Su=
nil Kovvuri Goutham <sgoutham@marvell.com>
Subject: [EXT] Re: [net PATCH] octeontx2-pf: Use GFP_ATOMIC in atomic conte=
xt

External Email

----------------------------------------------------------------------
On Sat, Jan 07, 2023 at 10:11:39AM +0530, Geetha sowjanya wrote:
>> Use GFP_ATOMIC flag instead of GFP_KERNEL while allocating memory in=20
>> atomic context.

>Awesome, but the changed functions don't run in atomic context.

drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
    1368         /* Flush accumulated messages */
    1369         err =3D otx2_sync_mbox_msg(&pfvf->mbox);
    1370         if (err)
    1371                 goto fail;
    1372
    1373         get_cpu();
                 ^^^^^^^^^
The get_cpu() disables preemption.=20

    1374         /* Allocate pointers and free them to aura/pool */
    1375         for (qidx =3D 0; qidx < hw->tot_tx_queues; qidx++) {
    1376                 pool_id =3D otx2_get_pool_idx(pfvf, AURA_NIX_SQ, q=
idx);
    1377                 pool =3D &pfvf->qset.pool[pool_id];
    1378
    1379                 sq =3D &qset->sq[qidx];
    1380                 sq->sqb_count =3D 0;
    1381                 sq->sqb_ptrs =3D kcalloc(num_sqbs, sizeof(*sq->sqb=
_ptrs), GFP_ATOMIC);

>> Fixes: 4af1b64f80fb ("octeontx2-pf: Fix lmtst ID used in aura free")
>> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
>> Signed-off-by: Geetha sowjanya <gakula@marvell.com>
>> ---
>>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>=20
>> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
>> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
>> index 88f8772a61cd..12e4365d53df 100644
>> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
>> @@ -886,7 +886,7 @@ static int otx2_sq_init(struct otx2_nic *pfvf, u16 q=
idx, u16 sqb_aura)
>>  	}
>> =20
>>  	sq->sqe_base =3D sq->sqe->base;
>> -	sq->sg =3D kcalloc(qset->sqe_cnt, sizeof(struct sg_list), GFP_KERNEL);
>> +	sq->sg =3D kcalloc(qset->sqe_cnt, sizeof(struct sg_list),=20
>> +GFP_ATOMIC);
>>  	if (!sq->sg)
>>  		return -ENOMEM;
>> =20
>> @@ -1378,7 +1378,7 @@ int otx2_sq_aura_pool_init(struct otx2_nic
>> *pfvf)
>> =20
>>  		sq =3D &qset->sq[qidx];
>>  		sq->sqb_count =3D 0;
>> -		sq->sqb_ptrs =3D kcalloc(num_sqbs, sizeof(*sq->sqb_ptrs), GFP_KERNEL)=
;
>> +		sq->sqb_ptrs =3D kcalloc(num_sqbs, sizeof(*sq->sqb_ptrs),=20
>> +GFP_ATOMIC);
>>  		if (!sq->sqb_ptrs) {
>>  			err =3D -ENOMEM;
>>  			goto err_mem;
>> --
>> 2.25.1
>>=20