Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755264AbXHVAe6 (ORCPT ); Tue, 21 Aug 2007 20:34:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750820AbXHVAer (ORCPT ); Tue, 21 Aug 2007 20:34:47 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:35841 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754568AbXHVAek (ORCPT ); Tue, 21 Aug 2007 20:34:40 -0400 Date: Tue, 21 Aug 2007 17:34:38 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Mathieu Desnoyers cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@redhat.com Subject: Re: [PATCH] SLUB use cmpxchg_local In-Reply-To: <20070822002616.GA1400@Krystal> Message-ID: References: <20070821173849.GA8360@Krystal> <20070821231216.GA29691@Krystal> <20070821233938.GD29691@Krystal> <20070821234702.GE29691@Krystal> <20070822000323.GG29691@Krystal> <20070822002616.GA1400@Krystal> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 21 On Tue, 21 Aug 2007, Mathieu Desnoyers wrote: > As I am going back through the initial cmpxchg_local implementation, it > seems like it was executing __slab_alloc() with preemption disabled, > which is wrong. new_slab() is not designed for that. The version I send you did not use preemption. We need to make a decision if we want to go without preemption and cmpxchg or with preemption and cmpxchg_local. If we really want to do this then the implementation of all of these components need to result in competitive performance on all platforms. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/