Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 09:36:37 +0100
Message-ID: <87k01ueqga.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Luka Guzenko <l.guzenko@web.de>
Cc:     tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Spectre x360 13-aw0xxx
In-Reply-To: <20230109235840.26452-1-l.guzenko@web.de>
References: <20230109235840.26452-1-l.guzenko@web.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 10 Jan 2023 00:58:40 +0100,
Luka Guzenko wrote:
> 
> The HP Spectre x360 13-aw0xxx devices use the ALC285 codec with GPIO 0x04
> controlling the micmute LED and COEF 0x0b index 8 controlling the mute LED.
> A quirk was added to make these work as well as a fixup entry.
> 
> Signed-off-by: Luka Guzenko <l.guzenko@web.de>
> ---
>  sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3794b522c222..6a76a2eddd3c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4644,6 +4644,16 @@ static void alc285_fixup_hp_coef_micmute_led(struct hda_codec *codec,
>  	}
>  }
> 
> +static void alc285_fixup_hp_gpio_micmute_led(struct hda_codec *codec,
> +				const struct hda_fixup *fix, int action)
> +{
> +	struct alc_spec *spec = codec->spec;
> +
> +	if (action != HDA_FIXUP_ACT_PRE_PROBE)
> +		spec->micmute_led_polarity = 1;

Is this condition correct?  It's usually other way round; a flag is
set up only once at parsing.


thanks,

Takashi