Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Fix return value of vfat_bad_char() and
 vfat_replace_char() functions
In-Reply-To: <20221226142512.13848-1-pali@kernel.org> ("Pali
 =?iso-8859-1?Q?Roh=E1r=22's?= message
        of "Mon, 26 Dec 2022 15:25:12 +0100")
References: <20221226142512.13848-1-pali@kernel.org>
Date:   Tue, 10 Jan 2023 18:17:52 +0900
Message-ID: <87zgaqu4sf.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Precedence: bulk

Pali Roh?r <pali@kernel.org> writes:

> These functions returns boolean value not wide character.
>
> Signed-off-by: Pali Roh?r <pali@kernel.org>

Thanks.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

> ---
>  fs/fat/namei_vfat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index 21620054e1c4..0735e4f0aeed 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {
>  
>  /* Characters that are undesirable in an MS-DOS file name */
>  
> -static inline wchar_t vfat_bad_char(wchar_t w)
> +static inline bool vfat_bad_char(wchar_t w)
>  {
>  	return (w < 0x0020)
>  	    || (w == '*') || (w == '?') || (w == '<') || (w == '>')
> @@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w)
>  	    || (w == '\\');
>  }
>  
> -static inline wchar_t vfat_replace_char(wchar_t w)
> +static inline bool vfat_replace_char(wchar_t w)
>  {
>  	return (w == '[') || (w == ']') || (w == ';') || (w == ',')
>  	    || (w == '+') || (w == '=');

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>