Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 12:29:04 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     pabeni@redhat.com
Cc:     Hariprasad Kelam <hkelam@marvell.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
        pabeni@redhat.com, edumazet@google.com, sgoutham@marvell.com,
        gakula@marvell.com, sbhatta@marvell.com
Subject: Re: [net PATCH] octeontx2-pf: Fix resource leakage in VF driver
 unbind
Message-ID: <Y7098K4iMjPyAWww@unreal>
References: <20230109061325.21395-1-hkelam@marvell.com>
 <167334601536.23804.3249818012090319433.git-patchwork-notify@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <167334601536.23804.3249818012090319433.git-patchwork-notify@kernel.org>
Precedence: bulk

On Tue, Jan 10, 2023 at 10:20:15AM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (master)
> by Paolo Abeni <pabeni@redhat.com>:
> 
> On Mon, 9 Jan 2023 11:43:25 +0530 you wrote:
> > resources allocated like mcam entries to support the Ntuple feature
> > and hash tables for the tc feature are not getting freed in driver
> > unbind. This patch fixes the issue.
> > 
> > Fixes: 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count")
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > 
> > [...]
> 
> Here is the summary with links:
>   - [net] octeontx2-pf: Fix resource leakage in VF driver unbind
>     https://git.kernel.org/netdev/net/c/53da7aec3298

Paolo,

I don't think that this patch should be applied.

It looks like wrong Fixes to me and I don't see clearly how structures
were allocated on VF which were cleared in this patch.

Thanks

> 
> You are awesome, thank you!
> -- 
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
> 
>