Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <47278c99-0137-83f7-cf15-718b630450a7@quicinc.com>
Date:   Tue, 10 Jan 2023 16:27:45 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH V0 1/1] bootconfig: Increase max size of bootconfig from
 32 KB to 256 KB for DCC support
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>
CC:     Masami Hiramatsu <mhiramat@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-arm-msm@vger.kernel.org>,
        "Sai Prakash Ranjan" <quic_saipraka@quicinc.com>,
        Sibi Sankar <quic_sibis@quicinc.com>,
        Rajendra Nayak <quic_rjendra@quicinc.com>
References: <cover.1673261071.git.quic_schowdhu@quicinc.com>
 <654357bcbfd3974072a558c494a51edafaa73e1a.1673261071.git.quic_schowdhu@quicinc.com>
 <20230109150951.ikdlkr6lmiapesmu@builder.lan>
From:   Souradeep Chowdhury <quic_schowdhu@quicinc.com>
In-Reply-To: <20230109150951.ikdlkr6lmiapesmu@builder.lan>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/9/2023 8:39 PM, Bjorn Andersson wrote:
> On Mon, Jan 09, 2023 at 08:01:05PM +0530, Souradeep Chowdhury wrote:
>> Increasing the memory size of bootconfig to be able to handle a max number of
>> 8192 nodes to be fitted in memory size of 256KB.
>>
> 
> This states what the patch does, but not why.
> 
> The description you put in the cover letter does capture the why, but
> the cover-letter won't be part of the git history (and if it was,
> there's no reason to keep the motivation separate from the change). So
> please move the motivation into the commit message.
> 
> Also, there's generally no reason to have a cover-letter for a
> single patch "series". So please skip the --cover-letter.
> 
> Regards,
> Bjorn

Ack

> 
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
>> ---
>>   include/linux/bootconfig.h | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/linux/bootconfig.h b/include/linux/bootconfig.h
>> index 1611f9d..64d233b 100644
>> --- a/include/linux/bootconfig.h
>> +++ b/include/linux/bootconfig.h
>> @@ -55,11 +55,11 @@ struct xbc_node {
>>   } __attribute__ ((__packed__));
>>   
>>   #define XBC_KEY		0
>> -#define XBC_VALUE	(1 << 15)
>> -/* Maximum size of boot config is 32KB - 1 */
>> +#define XBC_VALUE	(1 << 18)
>> +/* Maximum size of boot config is 256KB - 1 */
>>   #define XBC_DATA_MAX	(XBC_VALUE - 1)
>>   
>> -#define XBC_NODE_MAX	1024
>> +#define XBC_NODE_MAX	8192
>>   #define XBC_KEYLEN_MAX	256
>>   #define XBC_DEPTH_MAX	16
>>   
>> -- 
>> 2.7.4
>>