Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230110103512.4690-1-xupengfei@nfschina.com>
In-Reply-To: <20230110103512.4690-1-xupengfei@nfschina.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Tue, 10 Jan 2023 15:34:45 +0200
Message-ID: <CAFCwf11sCX2k_kaKEPjjc5TcdWi+TK1gQ90XPFfgM3bBpLm91g@mail.gmail.com>
Subject: Re: [PATCH 1/1] habanalabs: remove unnecessary (void*) conversions
To:     XU pengfei <xupengfei@nfschina.com>
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org, osharabi@habana.ai,
        obitton@habana.ai, dhirschfeld@habana.ai, mhaimovski@habana.ai,
        rkatta@habana.ai, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 10, 2023 at 12:35 PM XU pengfei <xupengfei@nfschina.com> wrote:
>
> data is a void * type and does not require a cast.
>
> Signed-off-by: XU pengfei <xupengfei@nfschina.com>
> ---
>  drivers/misc/habanalabs/common/mmu/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu.c b/drivers/misc/habanalabs/common/mmu/mmu.c
> index 2c1005f74cf4..a42ae8bc61e8 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu.c
> @@ -781,7 +781,7 @@ static void mmu_dma_mem_free_from_chunk(struct gen_pool *pool,
>                                         struct gen_pool_chunk *chunk,
>                                         void *data)
>  {
> -       struct hl_device *hdev = (struct hl_device *)data;
> +       struct hl_device *hdev = data;
>
>         hl_asic_dma_free_coherent(hdev, (chunk->end_addr - chunk->start_addr) + 1,
>                                         (void *)chunk->start_addr, chunk->phys_addr);
> --
> 2.18.2
>

Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
Thanks,
Oded