Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 09:53:35 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yishai Hadas <yishaih@nvidia.com>
Cc:     Matthew Wilcox <willy@infradead.org>, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk,
        logang@deltatee.com, hch@lst.de, alex.williamson@redhat.com,
        leonro@nvidia.com, maorg@nvidia.com
Subject: Re: [PATCH] lib/scatterlist: Fix to calculate the last_pg properly
Message-ID: <Y71t3yyFvdLXM+qd@nvidia.com>
References: <20230109144701.83021-1-yishaih@nvidia.com>
 <Y7zyyTxdoJulq7OD@casper.infradead.org>
 <a1f3b6ad-7173-70c7-4361-d01f9af1b7d6@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a1f3b6ad-7173-70c7-4361-d01f9af1b7d6@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g910uR3fUeLqeOUgKfr9YNuz24o4DyivjBhP9COWGrGCOZQI9RxYWkY/Cy/2?=
 =?us-ascii?Q?AH8moHYdzToXcOqPb22nBBuVqIVLHpUs++v6MliXuDXltnCr2E8MhUhIUMRA?=
 =?us-ascii?Q?LvnXsc8ANAAl2WwXpa0JwKaapzVI74TXDNkx2a71lYIpw7mOJz0fNNlkPZyO?=
 =?us-ascii?Q?BmbszyKJ/+sn1LhmULqNesBdzSZ0mAI6H0mJHy4ahhFa3TqVCeJfsA+dRM6m?=
 =?us-ascii?Q?59BXfDu4UDA05IJf6gnqV9L4k2Gm2QOQqcbsuo667i6qq5ejLsV+nGk8pz1f?=
 =?us-ascii?Q?UNV+JGtES310cqKNT/2nRFcGbyT6JbcowY/ttNus7WB1gQvsk/9pVvONsJmh?=
 =?us-ascii?Q?LW318tzEc2mIxHn8lDcg+VkeeE7lGeH4mVv8ksp6PDI9Y/VnD3q02XFlQIgq?=
 =?us-ascii?Q?hl9UILuChNIe54Hb4/Li5oHoQxORMUGYwfyQVnRdvW68D8uEavVlrnVKuTHn?=
 =?us-ascii?Q?F/WJjdUneEEhCmvC2VzQmdwEws+H/zAN3isGae1pyyLQljWuy0W5zI9HqgpU?=
 =?us-ascii?Q?7xHH/WnHE2cTQpwveS0eP6XmAagxWoFQ/uLvAAvdooebB9TzosCPcF7hHAiI?=
 =?us-ascii?Q?SQn86K6NMQsEFRREvNK8LrBeF5c8jwsoAh1xq2X54RxDrBM/qCXV/HCfkD9s?=
 =?us-ascii?Q?lkpI7gmR/Mjyzjx3L0hxJE3j9o0h3X7KuWBAXHtwG4Rnlx8zE5NDYQ2YLMx3?=
 =?us-ascii?Q?k7NOD1pkUoycsBPrcAtLVqfBTEmXL+gTX1rlg6aCVVdTf8kPc4/B1ULcBEQQ?=
 =?us-ascii?Q?1EEATZbkm4DTH4KDdZaoa9zzrFtmcEO5nD7MWrAugnwfHZgjMJjk29pL39ZK?=
 =?us-ascii?Q?hYFqKDxPj0BXiwZaSDqHSa6g+TJ0UdaTvC0WTp0CyVdUZ6hc7e6vIxkHv5KX?=
 =?us-ascii?Q?zRgYIVlK8xMBWravYTnp/9BMx0kq8TSMyNkjb6yk2WU9pOZH8idgSDG7cR5l?=
 =?us-ascii?Q?sb1GYA17eypz3Bwm/FO1n/D14ouE4Jg7yJiMVwx7J6lQN+rNkJowk2HCIOxn?=
 =?us-ascii?Q?3DX35ipBxnpRud+5A5gDx60Ws70iJ8GKJk50iS3K7etKmgPiW6U0YRkYMvmd?=
 =?us-ascii?Q?3n9e/+3B0GxR9K/isfYxP1BDsj9Mzn/rTQDxgXOZp18sMQqCqIoSSDVKWIn6?=
 =?us-ascii?Q?0UFKAvYMZ3ShS1jUfJ4ePllhTAZqgemFOOg6sjJGrRXhCBxIDOjLR1zBevRn?=
 =?us-ascii?Q?dSa6oI/Qkr4/IQcA64xN3F6tonl7EydzmpBxlnCTZfM4YDyd5TJAiwsEdSrh?=
 =?us-ascii?Q?nOLVKrPtzkWpyYghzL6WeeufFEaYFVJTHd3lHtEHTtmpfPgE30a8sILpkufg?=
 =?us-ascii?Q?EIwc5kgyf7Vwf6vAfy43P4N82MfA08aJyORXEorU3FX2xfyJ++YJeDXf7s7Z?=
 =?us-ascii?Q?vMazM482/j40zDUgwVEiXktH/S+N350rIWfe5J8ajVtV5+m4yclkCveYdEhU?=
 =?us-ascii?Q?DI7X0ecC3OVz+AnS4EdQQLwzjhrMBh0+FjHC4PacVx9slTt+1bQbn1WOaFWw?=
 =?us-ascii?Q?lZypiDWpG1osE0CDF6Gm7ANkyUOwbnxhpPoMl+qorxxAAT1xGlym4NYqqB38?=
 =?us-ascii?Q?5NfAhjpexUCSU2aBbRM7l3qWzC3W9f/7w38kPjb4?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1a4e4fa-34be-48b1-80b3-08daf31211ef
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 13:53:36.4559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SiUgJ3V2ua0y6vGLQo+i1AyiI17w/7ihzny5OTNBBrb0uyinUd2WqzRammqgO+MB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7752
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 10, 2023 at 10:01:53AM +0200, Yishai Hadas wrote:
> On 10/01/2023 7:08, Matthew Wilcox wrote:
> > On Mon, Jan 09, 2023 at 04:47:01PM +0200, Yishai Hadas wrote:
> > >   	if (sgt_append->prv) {
> > > +		unsigned long paddr =
> > > +			(page_to_pfn(sg_page(sgt_append->prv)) * PAGE_SIZE +
> > 1. page_to_pfn() * PAGE_SIZE is spelled page_to_phys()
> > 
> > 2. physical addresses have type phys_addr_t.  Oh, wait, paddr isn't a
> > physical address, it's a pfn because you divide by PAGE_SIZE at the end.
> > But you will get truncation on 32-bit, because page_to_pfn() has type
> > unsigned long.  Anyway, this shouldn't be called paddr.  Maybe last_pfn
> > or something?
> > 
> > > +			 sgt_append->prv->offset + sgt_append->prv->length) /
> > > +			PAGE_SIZE;
> 
> In this area of the patch I just reverted to what we had in 6.1 [1] where we
> were good.
> 
> I can send V1 and replace the 'paddr' to be called 'last_pfn' if it's really
> needed.

Please change it as Matthew describes so it is clearer

Jason