Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <996e39448350d4f6318f7ff59c6a2ca249fb30a7.camel@collabora.com>
Subject: Re: [PATCHv8 7/7] arm64: dts: rockchip: Add rock-5b board
From:   Christopher Obbard <chris.obbard@collabora.com>
To:     Jagan Teki <jagan@edgeble.ai>,
        Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        Michael Riesch <michael.riesch@wolfvision.net>
Date:   Tue, 10 Jan 2023 14:50:17 +0000
In-Reply-To: <CA+VMnFxb1P4tP5sef5ME3jCcCq2Y3rD-0bpv1B0TsUZ3RXXuqg@mail.gmail.com>
References: <20230109155801.51642-1-sebastian.reichel@collabora.com>
         <20230109155801.51642-8-sebastian.reichel@collabora.com>
         <CA+VMnFxb1P4tP5sef5ME3jCcCq2Y3rD-0bpv1B0TsUZ3RXXuqg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2-1 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-01-10 at 19:30 +0530, Jagan Teki wrote:
> On Mon, 9 Jan 2023 at 21:28, Sebastian Reichel
> <sebastian.reichel@collabora.com> wrote:
> >=20
> > From: Christopher Obbard <chris.obbard@collabora.com>
> >=20
> > Add board file for the RK3588 Rock 5B board. This is a basic
> > implementation which just brings up the eMMC and UART which is
> > enough to successfully boot Linux.
> >=20
> > The ethernet controller is connected via PCIe so support will
> > come in a follow-up patch.
> >=20
> > Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> > Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> > =C2=A0arch/arm64/boot/dts/rockchip/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 +
> > =C2=A0.../boot/dts/rockchip/rk3588-rock-5b.dts=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 | 44
> > +++++++++++++++++++
> > =C2=A02 files changed, 45 insertions(+)
> > =C2=A0create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dt=
s
> >=20
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile
> > b/arch/arm64/boot/dts/rockchip/Makefile
> > index 87a853435142..c5bdd0176ce0 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -83,4 +83,5 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-evb1-
> > v10.dtb
> > =C2=A0dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-odroid-m1.dtb
> > =C2=A0dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-rock-3a.dtb
> > =C2=A0dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-evb1-v10.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-rock-5b.dtb
> > =C2=A0dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588s-rock-5a.dtb
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > new file mode 100644
> > index 000000000000..d2f1e963ce06
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > @@ -0,0 +1,44 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +
> > +/dts-v1/;
> > +
> > +#include "rk3588.dtsi"
> > +
> > +/ {
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 model =3D "Radxa ROCK 5 Model B";
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible =3D "radxa,rock-5b", "=
rockchip,rk3588";
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 aliases {
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 mmc1 =3D &sdhci;
>=20
> I think sdhci - emmc has to be mmc0 due to boot priority.

Hi Jagan,

We kept eMMC as mmc1 for both ROCK 5 Model A and B to keep
compatibility with vendor kernel:
https://github.com/radxa/kernel/blob/stable-5.10-rock5/arch/arm64/boot/dts/=
rockchip/rk3588-rock-5b.dts#L31

But I am happy to change the alias to mmc0, @Sebastian what do you
think?

Thanks
Chris