Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 16:26:31 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Heiko =?utf-8?Q?St=C3=BCbner?= <heiko@sntech.de>
Cc:     Jagan Teki <jagan@edgeble.ai>,
        Christopher Obbard <chris.obbard@collabora.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCHv8 7/7] arm64: dts: rockchip: Add rock-5b board
Message-ID: <20230110152631.etavxhpofd2qmi3t@mercury.elektranox.org>
References: <20230109155801.51642-1-sebastian.reichel@collabora.com>
 <CA+VMnFxb1P4tP5sef5ME3jCcCq2Y3rD-0bpv1B0TsUZ3RXXuqg@mail.gmail.com>
 <996e39448350d4f6318f7ff59c6a2ca249fb30a7.camel@collabora.com>
 <37476486.XM6RcZxFsP@diego>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="l4ezfuydhkzkiruc"
Content-Disposition: inline
In-Reply-To: <37476486.XM6RcZxFsP@diego>
Precedence: bulk


--l4ezfuydhkzkiruc
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jan 10, 2023 at 04:07:46PM +0100, Heiko St=FCbner wrote:
> Am Dienstag, 10. Januar 2023, 15:50:17 CET schrieb Christopher Obbard:
> > On Tue, 2023-01-10 at 19:30 +0530, Jagan Teki wrote:
> > > On Mon, 9 Jan 2023 at 21:28, Sebastian Reichel
> > > <sebastian.reichel@collabora.com> wrote:
> > > >=20
> > > > From: Christopher Obbard <chris.obbard@collabora.com>
> > > >=20
> > > > Add board file for the RK3588 Rock 5B board. This is a basic
> > > > implementation which just brings up the eMMC and UART which is
> > > > enough to successfully boot Linux.
> > > >=20
> > > > The ethernet controller is connected via PCIe so support will
> > > > come in a follow-up patch.
> > > >=20
> > > > Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> > > > Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>
> > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > > > ---
> > > >  arch/arm64/boot/dts/rockchip/Makefile         |  1 +
> > > >  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 44
> > > > +++++++++++++++++++
> > > >  2 files changed, 45 insertions(+)
> > > >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > >=20
> > > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile
> > > > b/arch/arm64/boot/dts/rockchip/Makefile
> > > > index 87a853435142..c5bdd0176ce0 100644
> > > > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > > > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > > > @@ -83,4 +83,5 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-evb1-
> > > > v10.dtb
> > > >  dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-odroid-m1.dtb
> > > >  dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3568-rock-3a.dtb
> > > >  dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-evb1-v10.dtb
> > > > +dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588-rock-5b.dtb
> > > >  dtb-$(CONFIG_ARCH_ROCKCHIP) +=3D rk3588s-rock-5a.dtb
> > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > > b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > > new file mode 100644
> > > > index 000000000000..d2f1e963ce06
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > > @@ -0,0 +1,44 @@
> > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > +
> > > > +/dts-v1/;
> > > > +
> > > > +#include "rk3588.dtsi"
> > > > +
> > > > +/ {
> > > > +       model =3D "Radxa ROCK 5 Model B";
> > > > +       compatible =3D "radxa,rock-5b", "rockchip,rk3588";
> > > > +
> > > > +       aliases {
> > > > +               mmc1 =3D &sdhci;
> > >=20
> > > I think sdhci - emmc has to be mmc0 due to boot priority.
> >=20
> > Hi Jagan,
> >=20
> > We kept eMMC as mmc1 for both ROCK 5 Model A and B to keep
> > compatibility with vendor kernel:
> > https://github.com/radxa/kernel/blob/stable-5.10-rock5/arch/arm64/boot/=
dts/rockchip/rk3588-rock-5b.dts#L31
> >=20
> > But I am happy to change the alias to mmc0, @Sebastian what do you
> > think?
>=20
> In any case, if you decide to swap things around, please just send a foll=
ow
> up patch, as I just applied this series :-)

No strong opinion regarding the device enumeration from my side.
I'm fine either way.

@Heiko: Thanks for merging the series.

-- Sebastian

--l4ezfuydhkzkiruc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmO9g6AACgkQ2O7X88g7
+pr44RAAkXwmE424okAqcVR+nWqsE8cKoZCl0Rpyt1jc2ks9V570cxvC4b0FP5ON
bMub1n1T/h1+xGkWcSGUiE7gO7F99bobD6UYfRIzOSTSDFovlN4R8UhZtMgJ0OUn
7+yxlCoybbjNoiJq2MCH0igkGxeRGE2Jyi9CoRfYZIyk5jzZlTPM8cEPX3I48Nod
/dBrxbgktSC6/qlOld2fRGfjUo0JYRtQOUKB7wkKfEeUDfeOpz23XYQAFmI1knTT
fSMdTqU+BC4hanSXqDd5OBwo4vjyynxChfgRssWbnLl2k485QPMcz5epyrB/VMOi
GNZsWU545kXa4RFmF3Uv2RAEzctEyKDyCHtL9WEyEtGsAri9CciCRqxK3UOjObww
xs2cSEYn5AIjEXk1sOmFPCyBIhf/DTLFD+2deS9MX9vybg+3cvtjVnGx02+ycLt8
PUM2XrQ0hiD6OuZgWu8OMOT8BTnIs/TTf1B7tHiOqEJSalMTmh7HE05qUskx64Li
kPBdnDvjlnqmjzHoFwFUJ2k90KE5nGOPFY7uFFZIhHjCsHaTcVQ01zNfJfrHS94k
rsM9+K/1QvqtZv0RTlStzkUIXmOGj+hu93QMKukC0ZGKFIH2VHOgmotRaPma9x7q
5oSmhjw6KmD41Ut7lOBXPrdkbr3c79muPZzE05aGd2rokaEQjJA=
=XnXS
-----END PGP SIGNATURE-----

--l4ezfuydhkzkiruc--