Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7a16f713-b8ca-d46c-a18d-d48e6938be16@amd.com>
Date:   Tue, 10 Jan 2023 10:54:58 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] drm/amd/display: No need for Null pointer check before
 kfree
To:     Deepak R Varma <drv@mailo.com>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
References: <Y6s7989gmBZldV/S@qemulion>
Content-Language: en-US
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <Y6s7989gmBZldV/S@qemulion>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGpldGk0VGtUdmk4SkVjQjV6MkZsSlUvL2VHd0hrZSs1cnBqUkZ2NklKUlJH?=
 =?utf-8?B?WE9tYXRDV0ZsRXNhQTc1V01OTjlscEJ3T3FlL1BEaHIzcFFSZlJabnIyaTA1?=
 =?utf-8?B?dzd4a3RiYzh3V3FpUEluSzJiZWE4ajZ6bE5hQmFudm1MMUZCOEJNOC9iSUE0?=
 =?utf-8?B?dVgyOC9DYnV0V2c3ZzMwc2RNQitsbmNQcCs2L1JjRExqS1laa0NhdHR3L2xq?=
 =?utf-8?B?aURiMGdPSUtyc0tCamxpWDFjSFBHbjdCK2JsQTRGWTRETEVmcnpKZ3E2NU9J?=
 =?utf-8?B?VHdocE1jRFg4bTZ1c1U3Yk9YMG1ZMHpZTGZpUk56ckFHUlRBVmZrZ1RoVXp6?=
 =?utf-8?B?aTlyS3h5WDhjeXpMUTFxRkNwdk1NQ0FOTitBaDFXTE9MN1JrRzNKbDZyeWk3?=
 =?utf-8?B?SVFNS3R5eUhQdVNQajRXT3VsREZlMkhldG95bkFlVE1rdjNLZmF5Sjl6WGpl?=
 =?utf-8?B?dTJNSExOQnBHSXVQOVNYL0x3MTdTbXgxVXVJMW1JVjFWdnFhMUNMaEdkdG16?=
 =?utf-8?B?RVlSK2U1VkZGcys5QWhJZUVhZm56b0hOcDlsMWtRa1RjalY5YmRDd3ZjYVRa?=
 =?utf-8?B?elJFemFiRWtNbGpSTG1aVW5LaGdHK2hIRW1YQm9QTExJeWd3ajBmaldOVTdu?=
 =?utf-8?B?RWdacnRHMUdjUk9QREc2U0FwMHdMVVB2dUNWYVRsYkNTdHRBL2ZUcEVnalBw?=
 =?utf-8?B?dUpWQ0dHYllvelBBWngyWG5abGFLNjlyejNtRDErbG4yeTdweFdmRTA2S3Ri?=
 =?utf-8?B?djVXd0NnZWRxRFlicWxvUlBhd04vUlh2VVZrcVZXOGEvL0ZhRFdsazFxOWdO?=
 =?utf-8?B?UG9peW9DbVkraktyQWdWNHo3VnlWVjA2UHh4Yy9wT2RaNXVHMFdodzJ5aTRr?=
 =?utf-8?B?WjB4WEkzQzJJaGxnbVlOdkMrdWRhYS9RNmt2RjVPV29EV0hNUldXOThDRTBO?=
 =?utf-8?B?U21DZnRjeXFJa25zcW1id0poeWRqS1pQNkVUOTFody9kckpzeXl6cy9EbWp4?=
 =?utf-8?B?cEtDZnV0YUZnT0E3VEk0RHhybk5QNlkyRi9RMDBnc1RQU0NmZ0svZ2FNQnI2?=
 =?utf-8?B?V1FIc0VOUkVIUkpJTFdFaGhWeDVuLzVObGxVa0FkZzJtK0ljZ2RkV0MvQjVr?=
 =?utf-8?B?dUw1SDl4WCtyR2JHV0ZxMTdqemFEMStzaUQ2M0xHR2wxZDQ5azJITlZQSlh3?=
 =?utf-8?B?YkI1Z3V2TDh3Mk9rOTEyWTc1UXJ5OXcvbkR1RDJzeERZMlg2T0ttYzk3S2Z2?=
 =?utf-8?B?eTVjTG9ZeVhyK1FlRDJDUUNod1FDU3d4UksvckZWSm9OTTF1bHhUV3hOYUZK?=
 =?utf-8?B?YkNGVklyU1dMTmY5b3BmNW1TU240SkMrUXJzc0JlcytVR0cyNnNoVDFLL3A1?=
 =?utf-8?B?VTljbVdFZHVOR1RjbUU2RTZwUi9UeUFYRnhVbGlJM2ZGdWFVdnZGL2tQVURB?=
 =?utf-8?B?VURKWEs1WU1BOEVnMmg2T3ZWbVp5K0N4cUxVWHJ2MjZKWC9yZkkyeG1wQjdM?=
 =?utf-8?B?WENnS0dSQmxWNkVhMUMvNCsvRmducDZpeUVQQTdFQ3BuOFUyaWlTN0lNUFNC?=
 =?utf-8?B?STZzc0hJTGF6ZXpCWGVIRUk5VjVTZFRpM2NNQWJLQk9hcHRDci92VHNBek9p?=
 =?utf-8?B?R0xHWTA4bitxOTlodFR2R0RZL1F4ZDkwcWk3WExZTm9VT2taaDZKRUxIZFVu?=
 =?utf-8?B?WWdGT3JCMGF0ZEZPU05SaG02bXFWREVFKzRKUmRPQUZzQ0pPUjJpZTJOYUN3?=
 =?utf-8?B?NnlWeXRLRWMrUzBNUHdLMFRkZXd4cGZMbDZUQmhBWmhuOEFTK0NWZUNST2lJ?=
 =?utf-8?B?UnVha0w2bGNvY2RreFFZdU1jbjR3L0VoWGhhd0hYaVZRU3FFdEJxazRQVUV5?=
 =?utf-8?B?YW5nbUhZVXF0alNRNzZScmlLTjlqUlpPSmdXNEZKeEcwL3lvbERWZnFhTWNZ?=
 =?utf-8?B?WG5lYU94OWk2OW1XS0lHcTJYMmQrWW53bjF6SDRNQisyVGh2dndrRnVGalFH?=
 =?utf-8?B?b3hMczZrZ0RNZVhIdnNTb21TNkNoTzc4Rnhsc0dEQUFZLzNlMFl0SWFEcnhR?=
 =?utf-8?B?emdvTjdJUnQzYmZLblpBOVRjRTlJS2tZL0JIZ1J4enQ0ZGhrcXVpQjAyajlm?=
 =?utf-8?Q?Ngjnq58aiWv4rlf808fAtXCNI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32d84fe3-b533-47d4-dc79-08daf3230788
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 15:55:03.2940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kIZZFJaWclwiQyWcNSFtIJ5j+dHXUOU5A7bgmZ5VqgIJ4CZ9DOkHiX2OFDot7HO17HFQAnt4zmbxvwHfNtY10Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8155
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/27/22 13:39, Deepak R Varma wrote:
> kfree() & vfree() internally performs NULL check on the pointer handed
> to it and take no action if it indeed is NULL. Hence there is no need
> for a pre-check of the memory pointer before handing it to
> kfree()/vfree().
> 
> Issue reported by ifnullfree.cocci Coccinelle semantic patch script.
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
>   drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 3 +--
>   drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c
> index 3ce0ee0d012f..694a9d3d92ae 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c
> @@ -577,8 +577,7 @@ void dcn3_clk_mgr_construct(
> 
>   void dcn3_clk_mgr_destroy(struct clk_mgr_internal *clk_mgr)
>   {
> -	if (clk_mgr->base.bw_params)
> -		kfree(clk_mgr->base.bw_params);
> +	kfree(clk_mgr->base.bw_params);
> 
>   	if (clk_mgr->wm_range_table)
>   		dm_helpers_free_gpu_mem(clk_mgr->base.ctx, DC_MEM_ALLOC_TYPE_GART,
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> index 200fcec19186..ba9814f88f48 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> @@ -783,8 +783,7 @@ void dcn32_clk_mgr_construct(
> 
>   void dcn32_clk_mgr_destroy(struct clk_mgr_internal *clk_mgr)
>   {
> -	if (clk_mgr->base.bw_params)
> -		kfree(clk_mgr->base.bw_params);
> +	kfree(clk_mgr->base.bw_params);
> 
>   	if (clk_mgr->wm_range_table)
>   		dm_helpers_free_gpu_mem(clk_mgr->base.ctx, DC_MEM_ALLOC_TYPE_GART,
> --
> 2.34.1
> 
> 
> 

Hi,

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

And applied to amd-staging-drm-next.

Thanks
Siqueira