Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <789c2c61-4959-c3c1-0916-d1cc7f659247@amd.com>
Date:   Tue, 10 Jan 2023 10:58:16 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] drm/amd/display: Fix set scaling doesn's work
Content-Language: en-US
To:     harry.wentland@amd.com, nicholas.kazlauskas@amd.com,
        hongao <hongao@uniontech.com>
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        sunpeng.li@amd.com, linux-kernel@vger.kernel.org,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        aurabindo.pillai@amd.com, roman.li@amd.com, Jerry.Zuo@amd.com
References: <20221122112034.30080-1-hongao@uniontech.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20221122112034.30080-1-hongao@uniontech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ny9EWStIMGY1eTdLWCtwMzBhenBrQzZkTVUxZmxBeEVNbGlkNTczOXhpcm16?=
 =?utf-8?B?YytNc1VVTldWUzJHdldjdFVNYnZqcVF6RS81L1YzWVh5TENMaFg5RC9hV1Zv?=
 =?utf-8?B?THB5SnEybXZaSUJUQ2F6dzI3cWMrYVcwUk5tSDRzV3Izamhya1E3UTNYa2RO?=
 =?utf-8?B?cG5YS21TZVQzT2tzMEJlTUdJenlNbURiVnB3cFdzMUhza3M5alBEbzBWNkVy?=
 =?utf-8?B?L0kxSXVmK0NFUklnL0s0VFZHVHRLWnVIa2ZTTHgwRkVxdjRhL3BoQ2tkOSsv?=
 =?utf-8?B?a2NVTUxXVHVxWnhjN25aWEFZRDNBdGpHdnJOeVdTcG9rcEFzQjdrQmF2N0hF?=
 =?utf-8?B?L2VhdXFNUmwxd1hJV1JjN2Y5S0FuT243aW1SdkFONE4xOEN1NHZoc2p6dC93?=
 =?utf-8?B?VHJCYXRiNkNkL01tK3JvTmtvQjBENmg0aTRGVnlNV0ptMVJ4M0hDcXdFU2xH?=
 =?utf-8?B?UE93SVlSNk14TWI2QzV5dVBvc1YrWUYrSnJqZTVMQVBZbmoyM3BQL0QvTXNl?=
 =?utf-8?B?aE0xd0lwUGwybGEzN0tIZS94UDRmOWduRzFxd3lWT1dzNjN5dlJxbGUvWjZz?=
 =?utf-8?B?S2JJR1RRZVVhT3VUMjByeEVQbld4TVJRODZkMlFzQ213c3lKYUZSdFhONUdS?=
 =?utf-8?B?TTdJcHI4TkVMeUM3NmphYWRqSG0vbVlRdGJ4bUVtNnFxWHRHMGppTzkzY21N?=
 =?utf-8?B?bTE4aXZndVNnVW1RN1phbERxeG9pT1ROc2doQ2ZUbk1wYklrakE3SXBoNms2?=
 =?utf-8?B?SS9yZExsUlNVT0FYZlNQUFFhZ3o1cml5NjhIZnljYjJ2RUsrc2FCeVU2NlY4?=
 =?utf-8?B?VXE1ZVU2ZkFZZGZlODVWQUhGZGJ5RytyRFlkdmY5KzZMUjlPSGdmRVdCaUM0?=
 =?utf-8?B?U2ptMGh2ZlUway8zNisydjlkVjFHRG1sT2xUYjRNdXN6eUZITkpjVkhkMUc4?=
 =?utf-8?B?Q2J0ekNqSzRoRUhPUlFoWkViUm01dGJ2RjV2MG5BdlRIMjJJWWRZVlp6Z3FF?=
 =?utf-8?B?ZlFFeXoxaHF1REcvUnRhditMSWNGczdON2Y4VDVWcXF5dWdRZEc4NVNleW00?=
 =?utf-8?B?STlNN0sxOUR6VEVmbDZWR3ozMzZNSmx3cnh2ZWFuR21IZzFPOFd0a1ZSd2pJ?=
 =?utf-8?B?Tlh5Y2IwdFg5WXN2THNBVU5NMGtrdFo5bGE0UmI2YzVjSVZIcTR2Y2dVK3Mz?=
 =?utf-8?B?NjVvaUN4bWx2dW0rYU1KMGdyZmN2bWNJdUdHTXMydWoybnpvdWJZNWYxeHY4?=
 =?utf-8?B?UHlRejBPQzMvK2lBWjlvYWNuU2Ewa3k4VVNhbXVSNUY2bkgxeGxvbzRiMGNJ?=
 =?utf-8?B?WUpoVDZTKzR2UVpMWlN4ek1uMERNUHd5Z2wxTXd4WHk0a2xBOVJhbU5wVWwv?=
 =?utf-8?B?b0lmQk42R2tjbEVjcWlZWEJ0RXFMdXl6Y2N6Q0YyZFZTVGVxT01YNGdHc3lq?=
 =?utf-8?B?dGprOXo1MUQ1OHdud2hLZjdjOEw3VTF0WGh0Y3BWMnpobk02cVpzcmJkRm9P?=
 =?utf-8?B?UTU3Mk1RdWpLTmZ1VGdVeG1ma1FqU1JUY3RoNDhrMXE4ejlmb1ZNbUgxQVlL?=
 =?utf-8?B?OTVFTWtrbmtueS9WUG4vb2V3a2xmZGlTZHl5L0dtbVlPeWJybGxrNUpWK0wz?=
 =?utf-8?B?OGZNTUUzQUlwMVAybE1HK3REcy9ROS95R1NBMkZGcnUvZm1wbFJFN09DYXBS?=
 =?utf-8?B?a0RBRm1QdEJVR21FbmZreTh6aWg0OWFOUGoyc1BMZFFXcWdBNHU5a0M2c2Jr?=
 =?utf-8?B?bVlQMEg2WUZIUkgrc1IrY0lCdDV1MGN5Z3doU1N6cDJ2eTZXdEJpKzZUTWlp?=
 =?utf-8?B?Nk8rbERZYkNTWWVpSXBjUVVwVk8rWCtBK1pqMkl3eW9sMXl2UDFCOEowRXRL?=
 =?utf-8?B?dHJXa1c2bXl0TUd5bk5STFdSY2wwaytHcExjZytyOEp4SS9FQ2VkY09YRiti?=
 =?utf-8?B?Q3NVK2tEMG4rM3M5U3RGMThDV05IcCtTMjFSaTlCQmk2QWJrcVlhVDViemM5?=
 =?utf-8?B?WmxhdDhTc2hhRW1sZmF6dFcrcnZ2ZXhJekd0Zk9EWFNKR09TZjllMG1CcEZN?=
 =?utf-8?B?OGFJS29uOElEU0NwMjVuS2VldXYwbzk4dHMyTjFjeFlJK2VBNW5DSmlWSHpv?=
 =?utf-8?Q?uj4jlzg/vltp6BI9HAt+WcUj8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9c68ea9-a115-4b98-983f-08daf3237d60
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 15:58:18.1264
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: snZomJUI9Lla7CTcHrgNYPnZaLN2rUrEPtNgEwye5k03gn6iihpVIG7VCM3y1JvSS2N0LWNZaj37U4eK2dO7Og==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6424
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/22/22 06:20, hongao wrote:
> [Why]
> Setting scaling does not correctly update CRTC state. As a result
> dc stream state's src (composition area) && dest (addressable area)
> was not calculated as expected. This causes set scaling doesn's work.
> 
> [How]
> Correctly update CRTC state when setting scaling property.
> 
> Signed-off-by: hongao <hongao@uniontech.com>
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 3e1ecca72430..a88a6f758748 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -9386,8 +9386,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
>   			goto fail;
>   		}
>   
> -		if (dm_old_con_state->abm_level !=
> -		    dm_new_con_state->abm_level)
> +		if (dm_old_con_state->abm_level != dm_new_con_state->abm_level ||
> +		    dm_old_con_state->scaling != dm_new_con_state->scaling)
>   			new_crtc_state->connectors_changed = true;
>   	}
>   

Hi,

This change lgtm, and I also run it in our CI, and from IGT perspective, 
we are good.

Harry, do you have any comment about this change?

Thanks
Siqueira