Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <439c4aa1-2769-3c66-4d15-15729643c736@linaro.org>
Date:   Tue, 10 Jan 2023 17:31:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 2/3] dt-bindings: qcom: Ducument bindings for new
 msm8916-zhihe-uf896 and msm8916-zhihe-ufi001c
Content-Language: en-US
To:     Yang Xiwen <forbidden405@foxmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Jaime Breva <jbreva@nayarsystems.com>,
        Nikita Travkin <nikita@trvn.ru>,
        ~postmarketos/upstreaming@lists.sr.ht
References: <20230110155014.31664-1-forbidden405@foxmail.com>
 <tencent_5AB8DBF2B3CDE947BB84B3D6D2A0D7023F0A@qq.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <tencent_5AB8DBF2B3CDE947BB84B3D6D2A0D7023F0A@qq.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/01/2023 16:50, Yang Xiwen wrote:
> Document the new zhihe,uf896/ufi001c device tree bindings used in
> their device trees.

Subject: drop second/last, redundant "bindings for". The "dt-bindings"
prefix is already stating that these are bindings.

Subject: typo - Document

Subject: shorten it, use some shorter user descriptive model name

> 
> Signed-off-by: Yang Xiwen <forbidden405@foxmail.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 65ef7e442da0d..efe5f6c384b69 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -210,6 +210,8 @@ properties:
>                - samsung,j5
>                - samsung,serranove
>                - wingtech,wt88047
> +              - zhihe,uf896
> +              - zhihe,ufi001c

Real hardware, running real mainline OS cannot be called "placeholder".

>            - const: qcom,msm8916
>  
>        - items:

Best regards,
Krzysztof