Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1194985a-1353-2f7b-3a83-eeb317dfab83@gmail.com>
Date:   Tue, 10 Jan 2023 12:00:42 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] of: overlay: fix warning being reported as error in
 add_changeset_property
Content-Language: en-US
From:   Frank Rowand <frowand.list@gmail.com>
To:     "Ankit 16. Kumar (Nokia)" <ankit.16.kumar@nokia.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1671195782-23078-1-git-send-email-ankit.16.kumar@nokia.com>
 <VI1PR0701MB68298749C8133A7D69CFDBBFC9F09@VI1PR0701MB6829.eurprd07.prod.outlook.com>
 <a7e15b62-8929-b76e-77d7-42d78aaa02e1@gmail.com>
 <2ec3f5dc-b974-e799-2b96-d7b09dee4df1@gmail.com>
In-Reply-To: <2ec3f5dc-b974-e799-2b96-d7b09dee4df1@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/10/23 00:23, Frank Rowand wrote:
> On 1/2/23 08:35, Frank Rowand wrote:
>> On 12/30/22 02:40, Ankit 16. Kumar (Nokia) wrote:
>>>
>>> The print causes false reporting of the issue which actually is a warning
>>
>> How did you select the commit in this Fixes tag?
>>
>>> Fixes: 2fe0e8769df9 ("of: overlay: check prevents multiple fragments touching same property")
>>>
>>> Signed-off-by: Ankit Kumar <ankit.16.kumar@nokia.com>
>>> ---
>>>  drivers/of/overlay.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index ed4e6c144a68..0da39b8461e7 100644
>>> --- a/drivers/of/overlay.c
>>> +++ b/drivers/of/overlay.c
>>> @@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
>>>  	}
>>>  
>>>  	if (!of_node_check_flag(target->np, OF_OVERLAY))
>>> -		pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
>>> +		pr_warn("WARNING: memory leak will occur if overlay removed, 
>>> +property: %pOF/%s\n",
>>>  		       target->np, new_prop->name);
>>>  
>>>  	if (ret) {
>>> --
>>> 2.30.1
>>>
>>
>> NACK.  This patch is incorrect.  The reported memory leak is a bug, not a warning.
>>
>> I'll write up some information about why the memory leak occurs, then reply to this
>> email with the additional info.
> 
> The additional information is now available at:
> 
>    https://elinux.org/Device_Tree_Linux#Object_Lifetime

I have now expanded the information at that link to content that is beyond
the original topic.  Those interested in devicetree memory object may find
the additional info useful.

> 
>>
>> -Frank
>