Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8200485rwl; Tue, 10 Jan 2023 10:12:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXvgdX9ZD6qzh0/A9SXVvj1B3vbzumiX1F7MMQwVwAByzHkG28oedMZGAHk1F7FzUeC5CpLi X-Received: by 2002:a17:90a:1996:b0:227:94a:b5d9 with SMTP id 22-20020a17090a199600b00227094ab5d9mr9455541pji.48.1673374343117; Tue, 10 Jan 2023 10:12:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673374343; cv=none; d=google.com; s=arc-20160816; b=KvFmaiMJ09ku8a3yZkbSj6Z79ecWGkfGaUAosjDA2tVha6wU9bw7okCUq7zcTCaM+X CqA+2T8eLmoMxDGQhtlkwE3GfDhbPqxfif9CdgnSa0sXsecnexxf8baxu6rGqdOQKJFF +ip0U54oUKANSXwBDDhTjh/lMrMP3y5IhankOWIqreJ53oJC2TjbTzuGES81nYkRJJen lMg9bG8L7x6Rpq9VlVW2x5NdVOkXSSF6ZoSdMi79OE/9eR9RGper0pyjc0rfJDdTee7T UcHx5rt4ilXXtRyh7vBBgbZazXICT94dwqqZ8QkW5RCKOA/OgW9VVr9+83yPMJNvk/yB eHfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Fuw8Je+UQ6ckp268vYs/AqAO5ZMbAosQo5L96kq15aY=; b=i99+fk48cLrPjenHMkEIWRQlHnOe7uFUWbL1DpS1YMVsXLOoBZNoTUqt5E5cUyUS7D kTtRIKqW8Fp1vZGpQJB7jCvfHx88zKETHGDn9C6aXDJJGHn6Di7m13NQpjkREk/kCez0 ClcnYp3J2stfaDxPlqZvd1ZeVcsbuHivZIuowauO95GpFYFqv9lq1KKYczTit6izE2m6 PHdWvA48J9owV3RIXwC+M4npedovwiomW9dKxbPVPAWPBcRVgp5dVefwEhs8VY1xGni0 1jyocfY/YJa7SmKpLaPe51HfkohbOnZjF85mSqB/CZ+WMEhx4jGYJ60p/oEJtUOPmQT0 fr9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SoiSZ+kj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pm17-20020a17090b3c5100b002274d1eec16si2916249pjb.79.2023.01.10.10.12.16; Tue, 10 Jan 2023 10:12:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SoiSZ+kj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238962AbjAJSFm (ORCPT + 55 others); Tue, 10 Jan 2023 13:05:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238733AbjAJSEs (ORCPT ); Tue, 10 Jan 2023 13:04:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48E0C84BF5; Tue, 10 Jan 2023 10:02:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 071CCB818FB; Tue, 10 Jan 2023 18:02:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83C5EC433EF; Tue, 10 Jan 2023 18:02:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673373772; bh=3TkgNGFutzwKLFf4bqMOUvkvszlVhZochLWy+jcc/p4=; h=From:To:Cc:Subject:Date:From; b=SoiSZ+kjFzj70arH8udHwEKHRHi3QawNfbI22gUiojNMcDWvmm7/ly1WwAUIN6my8 i2DfhAEyXx+PjcTYGfSAMucGtV1yJifqucDMrLpy3YBq7mUc/4uGk0WytYUYNcxDZe fxmVaisZO7QewInuYnOMc5rMdDHzMZULV4b5banwy7tfQAfj0t5MUeEaGAgdbRWkIc bMHIzf50hcweUhe3z47OkOzKNYmu8avyqGOLWZHwdA1Al7OqiIk8DuS2JgL0jhzLXc dr7ISkGIuR/CvWey+0sFTELfyD6ApqPBZ0KCWeFLWTU3QywOBrUFJ5gbBSR8mUfjjc SvLMPvIefw/FQ== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Dan J Williams , Kan Liang , Tony Luck , David E Box , Yunying Sun , Dave Jiang , Mika Westerberg , Giovanni Cabiddu , Herbert Xu , Hans de Goede , Florent DELAHAYE , Konrad J Hambrick , Matt Hansen <2lprbe78@duck.com>, Nicholas Johnson , =?UTF-8?q?Benoit=20Gr=C3=A9goire?= , Werner Sembach , mumblingdrunkard@protonmail.com, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 0/2] PCI: Fix extended config space regression Date: Tue, 10 Jan 2023 12:02:41 -0600 Message-Id: <20230110180243.1590045-1-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map") appeared in v6.2-rc1 and broke extended config space on several machines. This broke drivers that use things in extended config space, e.g., perf, VSEC telemetry, EDAC, QAT, etc. This happened because mmconfig-shared.c checks to see that ECAM space is reserved in E820 or ACPI motherboard resources. If it's not, it assumes ECAM doesn't work. 07eab0901ede removed some E820 entries, so it looked like ECAM was no longer reserved, so we stopped using it. The machines where this broke don't reserve the ECAM in ACPI PNP0C02 devices (which seems to be what the PCI Firmware spec requires), but they do mention it in the EFI memory map as EfiMemoryMappedIO. Bjorn Helgaas (2): x86/pci: Simplify is_mmconf_reserved() messages x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space arch/x86/pci/mmconfig-shared.c | 44 +++++++++++++++++++++++++++++----- 1 file changed, 38 insertions(+), 6 deletions(-) -- 2.25.1