Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 10:07:39 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>, <linux-pci@vger.kernel.org>
CC:     Dan J Williams <dan.j.williams@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        David E Box <david.e.box@intel.com>,
        Yunying Sun <yunying.sun@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Hans de Goede <hdegoede@redhat.com>,
        "Florent DELAHAYE" <linuxkernelml@undead.fr>,
        Konrad J Hambrick <kjhambrick@gmail.com>,
        Matt Hansen <2lprbe78@duck.com>,
        Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
        Benoit =?iso-8859-1?Q?Gr=E9goire?= <benoitg@coeus.ca>,
        Werner Sembach <wse@tuxedocomputers.com>,
        <mumblingdrunkard@protonmail.com>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>
Subject: RE: [PATCH 1/2] x86/pci: Simplify is_mmconf_reserved() messages
Message-ID: <63bda96bcb95c_5178e29418@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230110180243.1590045-1-helgaas@kernel.org>
 <20230110180243.1590045-2-helgaas@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230110180243.1590045-2-helgaas@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VlluctPTg9oGqcDvJC4BKDaAHiG1lrqCH5jNzu5g8QLbrHnc3QCKgEST5daF?=
 =?us-ascii?Q?zIv+epKThJCEQpnv9r0yYSR9hXnMO5Teea3bFtfTIwQd9+NwRbmDZLKhUtPW?=
 =?us-ascii?Q?jzuZg8dvbu/SPGLBCBPwBAr0KrOGgFKMRAPabvqeefe0ei79a2CBpjS9vAh6?=
 =?us-ascii?Q?yN2e8a5lKcPiGyvNm4wPPUdd5Q6uIlJOBzuLSKsReT9GZoTGl1HfX2RYn10I?=
 =?us-ascii?Q?qUwLNaT9p2vdBSF2VSpcILGPBFQd0bgrrM3TegspW6fzDLATNkTv7jAAJC6l?=
 =?us-ascii?Q?Ehf6YSYkU96O+Sjr+tgDxFfaptnURCx5q2pG42fcnDL0u/sJBBI8iyYzPMRZ?=
 =?us-ascii?Q?iOUXxcFI4LP0DSNuNJbc9/WJOJccsPF27LgNoZT3ArBch+DLXgcKR894pBmk?=
 =?us-ascii?Q?qipqKF5Rqsjf6wkLjx7R83EJo1gfxnBT4YTzmYsEIfzT33eYgkpnsZVjtEet?=
 =?us-ascii?Q?upk+dOysb+2hCrW+SCfPlM27IYKBFRQkuQBUPw9Ph+T/w2+ZECRkx29i/RU7?=
 =?us-ascii?Q?1mqbnQ5qdurIPJEJN7T4JWQRATQ5gyQMH9OV/JswC+YfYZq74JET0P8z1RBq?=
 =?us-ascii?Q?PoYRYmtOXq3jRF/GBC/DfVX89nW+2lb7z4Yv6R9CNSJKOmf2Zb1i+3pDUKMm?=
 =?us-ascii?Q?qcxNb3DUTw1jWBX5HO/bT+fi52+tB+cEZG9iSl/1hUBn1EL0EzvDImdCEBOj?=
 =?us-ascii?Q?C2IoO+CTnxvaLlzRgujzk94SLkz93Xanirz87gaaoutNaERZNCYL472nlPtu?=
 =?us-ascii?Q?YpluI5WicztRpsjYAVw3Mbw5IvmoClhaT78TSDiSLttLF1M0/lLtQU79EByJ?=
 =?us-ascii?Q?xo+EQmv+gv+ITwCDht8ljktYVnsURuM7T/gWVOTNwr6kn15qYXqPlQyhIjgu?=
 =?us-ascii?Q?6u0N9g1T7N3rG1xf4qCLdJHisIMK6UNmBC8UxRHee4Gsp/4aHNRPP3mC3296?=
 =?us-ascii?Q?vqgu3IteVG4qb+6d89bAUr6s6bWsJ/w8h+HjFGdXpFLDjvhz9+5w3MK+wbDy?=
 =?us-ascii?Q?9jSIgpsfIE1MxVspEWQZQ/hQ9NZZB15B3ICit8SCDBDP/cYlnMNzflx+LGzF?=
 =?us-ascii?Q?kWnZs3nwmAW2ZkRTYWJ2puMbgOm6ivc0SyWTbibqGhSWSYzxs7CvCCzml0su?=
 =?us-ascii?Q?dO4wVIsExcIx8EeNo+i4pX6EestOHGLOngDOatSVAcp+10xuHxKyroF4I3cr?=
 =?us-ascii?Q?vhG0iFjjvyFeBuuPecaIL72z9dTHy98UGkhWloz5Or6R/MY3lelNC8lpn1ZT?=
 =?us-ascii?Q?bXoyRO6apBlGxaFc/B6CgYpJjh+bKhyp/u9HeMbEMjW0zSuX2HQ5VAuth3dq?=
 =?us-ascii?Q?PeOWhLCoAr3iJwN/VcoYq6N+ipJyP3QxnV6/MD44RUpa+cEJB3OHT1WdaYXL?=
 =?us-ascii?Q?pdS8rca5RuC6AefZJJQ5p5YxdJ4uBAqPqSk7P9jiaR1ZFp2cOMYj2KU4gbGr?=
 =?us-ascii?Q?ZrC+xCAJ4UFq89pXmQsZzMi8AXccLMiONlWsuA6JdFsPCF0RJRS2HdhMtJl4?=
 =?us-ascii?Q?En5yGbogCwSZQCIoUQW7q0zlsUZtntMTCfJmtsFtcg2Hl/rwOT3UvCr3Y5Zk?=
 =?us-ascii?Q?LVhaYZRInlDZNRLHpQzWm++Nt20Sa87TH/hEm2oJQ9SMPADxIHETMgzyd31A?=
 =?us-ascii?Q?lA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 477e8a96-23b3-4151-45c1-08daf33591a2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 18:07:43.0681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6cKeGoqHr6K0gvN1jZuoKlMUexDxCtNT2CmeMlpQyjKRe0y5o6JQr1e0KK9OUAmstGFp7EJTb08VEelIC8kl4c68dmyHlC+bXi+PE+VghSc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> is_mmconf_reserved() takes a "with_e820" parameter that only determines the
> message logged if it finds the MMCONFIG region is reserved.  Pass the
> message directly, which will simplify a future patch that adds a new way of
> looking for that reservation.  No functional change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  arch/x86/pci/mmconfig-shared.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
> index 758cbfe55daa..cd16bef5f2d9 100644
> --- a/arch/x86/pci/mmconfig-shared.c
> +++ b/arch/x86/pci/mmconfig-shared.c
> @@ -446,13 +446,12 @@ typedef bool (*check_reserved_t)(u64 start, u64 end, enum e820_type type);
>  
>  static bool __ref is_mmconf_reserved(check_reserved_t is_reserved,
>  				     struct pci_mmcfg_region *cfg,
> -				     struct device *dev, int with_e820)
> +				     struct device *dev, char *method)

@method could be 'const char *', but either way:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>