Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 13:51:30 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Praveen Kumar" <kumarpraveen@linux.microsoft.com>,
        Saurabh Singh Sengar <ssengar@microsoft.com>
Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/display: Avoid full proxy
 f_ops for DRRS debug attributes
Message-ID: <Y72zsk1eAmROtU9B@intel.com>
References: <cover.1673343994.git.drv@mailo.com>
 <4f6ae3e9a1f674abd36295772e7ffd0aa3e4a30b.1673343994.git.drv@mailo.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <4f6ae3e9a1f674abd36295772e7ffd0aa3e4a30b.1673343994.git.drv@mailo.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9jD8OPRB8YYuGgeE61IwmTvfyBz7A85kXJfOGv0EZpDwWoWIc+LZCCdXTySl?=
 =?us-ascii?Q?LrUT819ZzYlJekF3cqldUyHKynRBD+r/WALYVBKqdTaNKQ9kkn+B05WuFsFL?=
 =?us-ascii?Q?xzofEmGvA2kuOfwYDB2SyfUMTP8XxWAdKjWaGvN35tSMkfJfOeuke9nhxU5U?=
 =?us-ascii?Q?6y+7AAUiScyBDZ1w2eFJJVRK3a4/7TuO1lzbTs4SvNUDl5c/KkoRjO0+jC60?=
 =?us-ascii?Q?dKSsbmr4D+K9AL5JYoPyXYtbtrUz/TcR95PZpVyWGsSRjm9WwNYDbar2QTfZ?=
 =?us-ascii?Q?ndrKPrXvxn8WQHzh+s3VNbOw3iaH6zf0hv64R1Gi4vVqrYLXUFzC0G5u0+Mh?=
 =?us-ascii?Q?tSfLDG4RRh1Dh3hEOrG1dN/CCbaD/VpQ5CZmH9zxeErZgaVdyBefkp9HNbbO?=
 =?us-ascii?Q?cOTy+cllPSBXK4g7MQZmE65Nps8j6L/AQHKiLDNbxoBupp762r8tM1KX0mp9?=
 =?us-ascii?Q?x46WZom0afnpT83We333j0G/yt6dVPqdJFjh1ylNq00moDc98Id2nT2ST6il?=
 =?us-ascii?Q?HVMAwh4bm9ufnG44IRygfF35cV7RioX6DgnZkIl0ULPB5beDT21fUDnI+Vtg?=
 =?us-ascii?Q?aTsLERhgzDcPlugiIhlDvi7fvRZKNA43EglQo2huK0tPOzgZWWwRxIVyVSsq?=
 =?us-ascii?Q?VzieaTz2nVLh/hPIK3XELZL2vCKyug7mawOvdytBPMM0aQ6jTKKgSjGzttTI?=
 =?us-ascii?Q?uwZP72W3y6aKu37rN6pw24k5vJ1ITu87wuEGf9iPWeqnMWBafVfQHvzX78ME?=
 =?us-ascii?Q?1k+h3+rphIrCwdCpCIAAR/0kMBeNmpa5J9RhpAc62F3pu3/hTxm/88cNFKN7?=
 =?us-ascii?Q?DH91aF9RKPYfyaiz5jCUozbIZfmisl7rn/4vZXaYtuqwDKCPpAx2k2PFNjNC?=
 =?us-ascii?Q?gT8yKJ6g5TmKYNVgGrZz47XRpRQHqoLTQyQYm9SKCbv7mRRIBsqzQul54vMX?=
 =?us-ascii?Q?/xSl9dycSYOJML4Q0XmC3XEB8F4F9Hp1eeDUKhltOd2d7AEvCB12/4bwifko?=
 =?us-ascii?Q?pB838B8Vt/pJS7S0aPsdYSkiO4Nzpqd6fNmD4/09jVaXBSCzv7JrghLoHBV4?=
 =?us-ascii?Q?cyyJVUPgpJlk6/3mCP69gOGGwkvnOelBHBEXuA4d5aF9SnnKa8UEn47lf4pq?=
 =?us-ascii?Q?+0AAf5acwrZ9VQDn71Nigh7Nzy9Nud2leZP4zc3yWqlMkYxQJBc+AjQ1/pvR?=
 =?us-ascii?Q?cHDSAKeoZ9U/Ib6P/lyu+WOmKo/2C/8YaDsjEXohBjvq3/Kj1zUYyn7Indxg?=
 =?us-ascii?Q?kbdkgKXJnlmrOSxhRfbUu3lCEgY+3mTsuyqz2p92n2GGMGUtk6Pkr9+TYpC7?=
 =?us-ascii?Q?5mdKHGEPrnlr33aqT2GLLdLaeYEb8wFtyRpVraJFByn7jOyM/o51VOO4BRN7?=
 =?us-ascii?Q?69DQqG/HdQOKgNylJcGTwhdmA24KXLdEFWa4bCwlW6zN8Nvt0B3tCcPmZiS+?=
 =?us-ascii?Q?bp7A3FquZDRIKqbIxJ3ADK7LUVmgauLV2skS9BB/RC35kHJsGxah0N1fMq5N?=
 =?us-ascii?Q?nLKvOOSTMTrMUd7Vi0RidYBbc2JHpVeom3BlTdbgvvoMoK+fuPIlKqXcHrzu?=
 =?us-ascii?Q?VQfILGSePQMpTP9pRLoptepp6DaV6F8m1UBT1GWQl1Ev1TMvcIoecgkHG2Og?=
 =?us-ascii?Q?pw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a9bbf82-b5e2-48a0-4b0d-08daf33bb2c9
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 18:51:35.7314
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FPhzZJoPsT8Kk0rUsxKrl7C3OkzFAfVKJULAXdmYaOSuwFpGhQXAku0h8KPauBbLfycZciJUqDu9RXYlnjwJng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5341
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 10, 2023 at 11:45:02PM +0530, Deepak R Varma wrote:
> Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file()
> function adds the overhead of introducing a proxy file operation
> functions to wrap the original read/write inside file removal protection
> functions. This adds significant overhead in terms of introducing and
> managing the proxy factory file operations structure and function
> wrapping at runtime.
> As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired
> with debugfs_create_file_unsafe() is suggested to be used instead.  The
> DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and
> debugfs_file_put() wrappers to protect the original read and write
> function calls for the debug attributes. There is no need for any
> runtime proxy file operations to be managed by the debugfs core.
> Following coccicheck make command helped identify this change:
> 
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> Changes in v2:
>    - Include coccicheck make command in the patch log message for clarity.
>      Suggested by Rodrigo Vivi <rodrigo.vivi@intel.com>

Thank you

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
>  drivers/gpu/drm/i915/display/intel_drrs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/drivers/gpu/drm/i915/display/intel_drrs.c
> index 5b9e44443814..84ba7379d6f8 100644
> --- a/drivers/gpu/drm/i915/display/intel_drrs.c
> +++ b/drivers/gpu/drm/i915/display/intel_drrs.c
> @@ -374,16 +374,16 @@ static int intel_drrs_debugfs_ctl_set(void *data, u64 val)
>  	return ret;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(intel_drrs_debugfs_ctl_fops,
> -			NULL, intel_drrs_debugfs_ctl_set, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(intel_drrs_debugfs_ctl_fops,
> +			 NULL, intel_drrs_debugfs_ctl_set, "%llu\n");
>  
>  void intel_drrs_crtc_debugfs_add(struct intel_crtc *crtc)
>  {
>  	debugfs_create_file("i915_drrs_status", 0444, crtc->base.debugfs_entry,
>  			    crtc, &intel_drrs_debugfs_status_fops);
>  
> -	debugfs_create_file("i915_drrs_ctl", 0644, crtc->base.debugfs_entry,
> -			    crtc, &intel_drrs_debugfs_ctl_fops);
> +	debugfs_create_file_unsafe("i915_drrs_ctl", 0644, crtc->base.debugfs_entry,
> +				    crtc, &intel_drrs_debugfs_ctl_fops);
>  }
>  
>  static int intel_drrs_debugfs_type_show(struct seq_file *m, void *unused)
> -- 
> 2.34.1
> 
> 
>