Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 13:52:05 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        "Praveen Kumar" <kumarpraveen@linux.microsoft.com>,
        Saurabh Singh Sengar <ssengar@microsoft.com>
Subject: Re: [PATCH v2 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC
 debug attributes
Message-ID: <Y72z1T1bifo3YpSR@intel.com>
References: <cover.1673343994.git.drv@mailo.com>
 <a4200ae1de7324fcddac201009a43571d0a72104.1673343994.git.drv@mailo.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <a4200ae1de7324fcddac201009a43571d0a72104.1673343994.git.drv@mailo.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AaijdpqfwNPv8SpQC+djmB7Q6X2o6xC4RogecscfSUD9bxBki4GScyIGaeGb?=
 =?us-ascii?Q?XSkb8/DbUVkdbVlRPZqgVWoLCI7M47xs1JTWeGBw/ALTcG9OjRWXgKEvAzyP?=
 =?us-ascii?Q?KZEGkpExwqMDtIKm1tTEzfCPV6/NFo7OrdhhwHXLm/iU3l2ii4KgkhsdF+s0?=
 =?us-ascii?Q?/3RLAWezC9SyuguMEsk1/U8+968BE704cbux/LhmQbxQQQHD+qxwdUTeiTjC?=
 =?us-ascii?Q?QjnPNhCvJhsaz1GfzWpYq69NlKhCikIuEgxyhTa/avX617FkypEjbspfu+Vh?=
 =?us-ascii?Q?w1WHy7I5fW2k1+CsdykLGqZCnprgT2hdE4auP7IYNzriWFEyHPImXX44Uy8b?=
 =?us-ascii?Q?46/9h74tXTM9AV6cxidppkJmMFwmBRWtT6f3Ci/9i0S+r3Bro3W4PKWILuD+?=
 =?us-ascii?Q?qfsLoGd63vUCDrs6TCeg7Lw7+nBBFgFu3aO4/L5+cwi9M6Q1jcyOatkIH9pH?=
 =?us-ascii?Q?dTHwIE1xy+0JbdTnAWWPrO/eUiQNxDnIC0I7WK44akzo9v+99i1e2qMoby0V?=
 =?us-ascii?Q?7EGkwy1Hcq8NvhC3vUOPZepruJ6FvJDZKv6KvsMgEPYwrVuuAN2PaHzqSMeg?=
 =?us-ascii?Q?V4QkX8yg/AhwaX+rrvM60Us92x+eVEp+foLtaKg83KRo8+Ltts/9LZWM6CUc?=
 =?us-ascii?Q?8cwh5pWJatKvcej362CdXkBF2OJMm8OzyIh5czVJ3liNYgkNfnZOga7MZr5h?=
 =?us-ascii?Q?ZWAEx5hNeMk/uc2Iix19jBBwKqEjVlC8VlbjQsLhb+0sgq3EC4lUHxbo0XFu?=
 =?us-ascii?Q?hEJl1CwEk5JJek3pK6En6ILuA+Omc6ZRgS2tzRMA+v3tBkyg0FKHey42UgUJ?=
 =?us-ascii?Q?yu5nWxQ4v7trQLB77rLtGCbo02mGcQ8D1iStjGbplMo8IWDrZZFqwtGnBaqr?=
 =?us-ascii?Q?GS1DAIX/pbh74bN77jpWar+oGnuyERwbh3SAGC/gzJ5IVj3cmOLDb6xRsaLe?=
 =?us-ascii?Q?5FeY+qYIPnrPJkw/agZHhY9cV+T/JK88PLlZAxIK45J6Pt8U1l2ZNuU3rOCM?=
 =?us-ascii?Q?9FKI0Ay91beH8l5WmlW07eo6vfzYiXQcsLIc4u0MSrXxnpXTor7a8n0ljVBQ?=
 =?us-ascii?Q?SuQ1GGTdBf6u4YwhKfvPenngJK3wY1G200czp7kaIzidTibSLIfOuYegJgRg?=
 =?us-ascii?Q?nBCCQdB4+PmBS9qtJSCmVu9t6IjxtERudMfcsiLPM5/rR5hn43t2sr0T7SKp?=
 =?us-ascii?Q?My/WKm8uVhf8N7Htr+BFm5r3kFc9e6d6UPq8d8xwgTG2E1U4l6ROeyjjnLw2?=
 =?us-ascii?Q?GVsxB0Dfp6CFENozGO3CaDA9KLZFodHjhv0IF4WgzKla3ZU1Aapa2Lsmk2wd?=
 =?us-ascii?Q?ul65Sl2G24pMjIiROgwPfcAz1mRHS1qyDYWW1c+nXitxvBQK7+0UgRTImMbQ?=
 =?us-ascii?Q?cv4u1XLirVk/KreuExVZERGgDLIo3imAhBb7RgHVqAUwbavsJvQ5YnScDdFu?=
 =?us-ascii?Q?TQE0zlXNXxtpVnuOEeakvp4HVGu23koPMMCoL6duUNFtE+tJW72lVTqUk9ST?=
 =?us-ascii?Q?edWRvn9mQ7syyxUae1TuFK9EAJuZSMkDwXzzgX33uVBuATpATKsAxKvWBFl/?=
 =?us-ascii?Q?UykcMp6vrBDr9S9sQMqrpHH4tZAouqooVXlP6npaeStCqvfFHF9AciuxMvrS?=
 =?us-ascii?Q?6w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 314266a1-5419-4200-9a89-08daf33bc7c6
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 18:52:11.4785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b0JY08ziR5d/PTSP22RuDhdkeFqu5XNd6ROYwH9x73Nm8IRCo34/xHlgm3ezfOG87ZMOSWY0pZFELZIz6uLyQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5341
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 10, 2023 at 11:45:40PM +0530, Deepak R Varma wrote:
> Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file()
> function adds the overhead of introducing a proxy file operation
> functions to wrap the original read/write inside file removal protection
> functions. This adds significant overhead in terms of introducing and
> managing the proxy factory file operations structure and function
> wrapping at runtime.
> As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired
> with debugfs_create_file_unsafe() is suggested to be used instead.  The
> DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and
> debugfs_file_put() wrappers to protect the original read and write
> function calls for the debug attributes. There is no need for any
> runtime proxy file operations to be managed by the debugfs core.
> Following coccicheck make command helped identify this change:
> 
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

(Are you planning to send the one for pxp file?)

> ---
> Changes in v2:
>    - Include coccicheck make command in the patch log message for clarity.
>      Suggested by Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> 
>  drivers/gpu/drm/i915/display/intel_fbc.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 5e69d3c11d21..c508dcf415b4 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1807,10 +1807,10 @@ static int intel_fbc_debugfs_false_color_set(void *data, u64 val)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(intel_fbc_debugfs_false_color_fops,
> -			intel_fbc_debugfs_false_color_get,
> -			intel_fbc_debugfs_false_color_set,
> -			"%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(intel_fbc_debugfs_false_color_fops,
> +			 intel_fbc_debugfs_false_color_get,
> +			 intel_fbc_debugfs_false_color_set,
> +			 "%llu\n");
>  
>  static void intel_fbc_debugfs_add(struct intel_fbc *fbc,
>  				  struct dentry *parent)
> @@ -1819,8 +1819,8 @@ static void intel_fbc_debugfs_add(struct intel_fbc *fbc,
>  			    fbc, &intel_fbc_debugfs_status_fops);
>  
>  	if (fbc->funcs->set_false_color)
> -		debugfs_create_file("i915_fbc_false_color", 0644, parent,
> -				    fbc, &intel_fbc_debugfs_false_color_fops);
> +		debugfs_create_file_unsafe("i915_fbc_false_color", 0644, parent,
> +					   fbc, &intel_fbc_debugfs_false_color_fops);
>  }
>  
>  void intel_fbc_crtc_debugfs_add(struct intel_crtc *crtc)
> -- 
> 2.34.1
> 
> 
>