Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8290557rwl; Tue, 10 Jan 2023 11:23:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXtANLc5un+RuMa5SCOeHFfcCvG2CGQw7/b0OllAwGnjN9HkortY4rE3PBnMurqNO2dquFur X-Received: by 2002:a17:903:12cd:b0:193:335a:989e with SMTP id io13-20020a17090312cd00b00193335a989emr7530651plb.25.1673378605633; Tue, 10 Jan 2023 11:23:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673378605; cv=pass; d=google.com; s=arc-20160816; b=dJapU34QLTOX4o/tCDdHNmysUronGjAkjCUR/Upyy3fEMekFTPdJfENeZKySeAbQIS B442IsG0My7tecy/4u9JouWLJKbpk7U43lPsrgiCk9dzMAi2wDne2VCMyQlcVCOmQdKD eG8GCWWahsxz6n4KD1aoM7G+nY49sDy/y3r5n0Vdeh4tZt4EqxA7szFRHP13LHoo+pv9 R0tYHamhvGW4+1XAuiGqmGIDFhyaLmPuJ+aaAPRCezkHUiKnP9mbqzJt2RDveZCQ+HyA p0x6hwvJQ6IBKrkSi7WmUqpFq94/jrCPF+HQpPoQ4CLeCRQuZHBIN4c9vHFYgTDg9UsK HjoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:importance:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:dkim-signature; bh=94w/84cEKuVEFn2g20pluke79PDKWPNFSLBsY9v/ql8=; b=uaosn3USNnZ9T/xVg/Cn3UCVBrywEg8KJ6egvP6gn3LZVWLQwWzPovEWMt0mkT9k3I cOltqEES/2V+KmZcJGXmLTalC8lvjIlHTDotuzfO9f9ochB0uRtedOEVwrSZCm4LD1VJ O564j2jeVDj5yKSChfZhYoJZ+5VuiiB3OogMJ+ip33i/DN9hjicZt5D/uYB6EO3e4i27 1C5sTVQtMg5eldeiC3JjiDfLSqHzDmhnO1qpNLMwctm24CItXwMFa0CwfqwT60B4CsrU fnKIRtEkSeITcJeCXRjiiqVxNLlPCyygV+CZ9kGgunH93veUhMRxocZt5wzcWMtTw//n /QhA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@siddh.me header.s=zmail header.b=LsKe4OZP; arc=pass (i=1 spf=pass spfdomain=siddh.me dkim=pass dkdomain=siddh.me dmarc=pass fromdomain=siddh.me>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siddh.me Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ix9-20020a170902f80900b001932ed455f4si5973835plb.273.2023.01.10.11.23.19; Tue, 10 Jan 2023 11:23:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siddh.me header.s=zmail header.b=LsKe4OZP; arc=pass (i=1 spf=pass spfdomain=siddh.me dkim=pass dkdomain=siddh.me dmarc=pass fromdomain=siddh.me>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siddh.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239738AbjAJTMC (ORCPT + 53 others); Tue, 10 Jan 2023 14:12:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239762AbjAJTLi (ORCPT ); Tue, 10 Jan 2023 14:11:38 -0500 Received: from sender-of-o50.zoho.in (sender-of-o50.zoho.in [103.117.158.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0596DFBB; Tue, 10 Jan 2023 11:11:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673377846; cv=none; d=zohomail.in; s=zohoarc; b=fgjNUnZKnlS2NO43QnBV8y7avtKZwWUTLL/kVFRJkZPOzStFvsy+AgJ+42e4C5gKAAoOOLDIlH6lio9MAeFXvI6lrewPC2gBNVckzs3iLqE8K++zC9mfQVz891uB+6WHYdLtOGMC4zra+YvjyEt/hKOQrUNAJyOb5i96nxvd3ZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.in; s=zohoarc; t=1673377846; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=94w/84cEKuVEFn2g20pluke79PDKWPNFSLBsY9v/ql8=; b=WRgOCrgiJHyBP8Je59WuVLMKYNSpD1l1zy0B1pLOt9dG5JlgkWJ1RLZ8BFnSrx9A6OtR/nGFmZcvuK0WE6jxZZCwb6y5rtyxeKepfIyBexUFI3GFXA2B22hnikIdkJCHZvi7VjsiRl944vCTLzoiIcj+krKDfm5Jslwra1DprXY= ARC-Authentication-Results: i=1; mx.zohomail.in; dkim=pass header.i=siddh.me; spf=pass smtp.mailfrom=code@siddh.me; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1673377846; s=zmail; d=siddh.me; i=code@siddh.me; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=94w/84cEKuVEFn2g20pluke79PDKWPNFSLBsY9v/ql8=; b=LsKe4OZPG0vKr3M78UgPtfxUXOmZn6E226af1nX/CH1sPXYNvt/dwivBe676PFIs oY/i8i7Z390dKS9GBO5WpdB8AbUzqXBYV+ypC2ts9ziVu9cd6MX2XL5kNgdl6NSdohx ndBuAxm0sEL6U0r7NSSgGLT0hkhfzRaVMmG8SzsA= Received: from mail.zoho.in by mx.zoho.in with SMTP id 1673377834655807.4120717855777; Wed, 11 Jan 2023 00:40:34 +0530 (IST) Date: Wed, 11 Jan 2023 00:40:34 +0530 From: Siddh Raman Pant To: "David Howells" Cc: "mauro carvalho chehab" , "randy dunlap" , "jonathan corbet" , "fabio m. de francesco" , "eric dumazet" , "christophe jaillet" , "eric biggers" , "keyrings" , "linux-security-module" , "linux-fsdevel" , "linux-kernel" Message-ID: <1859d17668d.7b9d5469421579.5464668634216421773@siddh.me> In-Reply-To: <2121105.1673359772@warthog.procyon.org.uk> References: <97ce37e2fdcfbed29d9467057f0f870359d88b89.1673173920.git.code@siddh.me> <2121105.1673359772@warthog.procyon.org.uk> Subject: Re: [PATCH v3 1/2] include/linux/watch_queue: Improve documentation MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jan 2023 19:39:32 +0530, David Howells wrote: > Please don't. > > The structure is documented fully here: > > Documentation/core-api/watch_queue.rst > > See: > > https://docs.kernel.org/core-api/watch_queue.html#event-filtering > > The three column approach is much more readable in the code as it doesn't > separate the descriptions from the things described. Putting things in > columns has been around for around 6000 years. > > David Okay. Apologies for that. But what about the second patch? Should I send that without these doc changes? Thanks, Siddh