Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 13:49:57 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>,
        Saurabh Singh Sengar <ssengar@microsoft.com>
Subject: Re: [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status
 debug attributes
Message-ID: <Y72zVXYLVHXuyK05@intel.com>
References: <cover.1673375066.git.drv@mailo.com>
 <188df08e0feba0cda2c92145f513dd4e57c6e6cf.1673375066.git.drv@mailo.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <188df08e0feba0cda2c92145f513dd4e57c6e6cf.1673375066.git.drv@mailo.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6FmxYUQXK4xCMaDJBhoC/DvXnejbz6DJrVzrNHZasW3i0Ghd4vJ5FoqFm9lc?=
 =?us-ascii?Q?+/eAR62rP5MYKJccnQd+z1KQO3Jz9aeoa/td3fcZ9oWvSxAIZgoBU/BvOM2i?=
 =?us-ascii?Q?IAAVKEb3qZT5ECvytL1AVSqRwHfqKoAuCDs3OydQDNTH6B+//Ubrb3LBMGhs?=
 =?us-ascii?Q?L3E+ltZ/On5PzSLqi0tGAHxHdOb55Y9/iutVLvY5miMIbrllPz1A9ZKAlTv9?=
 =?us-ascii?Q?ytVRjHLKkxgu659j51BxlyDNqj79CqL970AKYXVGRUR1pueSmPVrAvlB+0bF?=
 =?us-ascii?Q?1bsVgD24X08Y7lkq4PdlQF2jM8fEhJhc2iuUizwJzROeYllQD/3wI9Dp5/Lt?=
 =?us-ascii?Q?+HMabVDamYaObj0LtU42z1c+3KEYRF/AVM1pypuU5zKIo8c5eaQcQ+OZVdzp?=
 =?us-ascii?Q?fsTNM/Q8MLuuupGBsSQXHn7A1Tk0uArlp4L9D9s4Pxpl2tUGjlyWjT1iG/Oj?=
 =?us-ascii?Q?zconCt5LuyZS+YFyr34rYmbiYTGIoG+GS/XEPGHmibzaHkK4RXbeyovps2RZ?=
 =?us-ascii?Q?nYNRimRBuswD+KhxO1B8BCrH0IXfpNl7kyBZkfz9lQe7alNfkPlbOtSva6ql?=
 =?us-ascii?Q?nXwicSq8AxtfO8IewGIYlls2KbwWj8EBx2Svo5EoTm2JppMtlPQSQRO8TmPp?=
 =?us-ascii?Q?pd7xVb6D0ypvNqnAKOFUYUUW2BxWd6MW7Qsj0CbuU6t8TYX7taU+s3uD/WEo?=
 =?us-ascii?Q?c4rBVKH3sCOY+gR6+xC8dcRmQsKz69kW4sj9gTU6b1kcvQfDEjCmh9zxSLmC?=
 =?us-ascii?Q?0CDopD1RaDA2G6qHqmgf+M4ozBsEM6DXi2JtOGgItbI9HYIDtDNc2QAwoXt8?=
 =?us-ascii?Q?mO+tKc8PKFScU8MA0HNt1UQTwgRhMygJKS7DrMzBKSBZFT8Q9oqMmyndhPlI?=
 =?us-ascii?Q?mSkde2TT8Zdb1L6V+tQS2KasrciFAbyjFjlLJei08EyiUbOVNEAa3xvC77lZ?=
 =?us-ascii?Q?9Ipna5ezU9qJdIEcDBsO8k8VrqhQPPRJJzL23XVahF5+btR8k7Cgx6rclSr4?=
 =?us-ascii?Q?XOdbmmfRWXEqwuP4ZEPcTrwJ4Mb8dO1YUQMasjT7ejwbT5YgaEcDSUYApux1?=
 =?us-ascii?Q?Z8alVQWLYWlSVrbCtuj2aIfJJlBn3ny35E8V6PLSPwj3bJkZqqAobH0geGDZ?=
 =?us-ascii?Q?38Xo23MhoAwYlkO6ob5VkkozvmWShfHBFWHZ8GxzdJOcH8QNL4t2Ejvxcyhz?=
 =?us-ascii?Q?Khl7iGdZ35K3F9BAOv3AN5itJ5Ziz98anV63eOFuod6MZlOZ+0D7hYzUKS9L?=
 =?us-ascii?Q?tylNm74Pgx4EX12X5cR0TUodAGCemo9UytHRpIngpQ7VqR7RGF2cepf6TRb7?=
 =?us-ascii?Q?iHhJh3gkATryXd5B5cFZTbD+VLglSpu1u6Dh2SXBvLluvUHFbmF5Fd6951f7?=
 =?us-ascii?Q?hEaPcyz2p4KgNjWNl+ESPIiLfjIzjUlSzeTo1f7vyDatGMXF38qMu2oK7i6I?=
 =?us-ascii?Q?Z5aqKR8H6MwBdoJD4VKEtbrx5CBkVfqaXMlHX1XWWrJcW0CvZsnai8i542LC?=
 =?us-ascii?Q?OOQZoeAGY45XwlTj31BBO+IfGCjBTyzSAqOLBDjyjBZh2R84RUDO9dQibW2r?=
 =?us-ascii?Q?kl2r+0kbKK9yY3dWbYSInWaNmRpHpoyR/yVcbY2kNAYDW7/dTErWKHYk06NI?=
 =?us-ascii?Q?8A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 79008600-26fb-4861-122d-08daf33b7b32
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 18:50:02.4969
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pUE0iLyOk6uKp8oMBHiQsZtw/8LrlFNGwi/FejBGbIazfoXixQdDGoKO/XpwL3TTomYID5RvXGMwT33vfMOMRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7089
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote:
> Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file()
> function adds the overhead of introducing a proxy file operation
> functions to wrap the original read/write inside file removal protection
> functions. This adds significant overhead in terms of introducing and
> managing the proxy factory file operations structure and function
> wrapping at runtime.
> As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired
> with debugfs_create_file_unsafe() is suggested to be used instead.  The
> DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and
> debugfs_file_put() wrappers to protect the original read and write
> function calls for the debug attributes. There is no need for any
> runtime proxy file operations to be managed by the debugfs core.
> Following coccicheck make command helped identify this change:
> 
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>

I believe these 2 gvt cases could be done in one patch.
But anyways,

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

for both patches... and will leave these 2 patches for gvt folks
to apply. Unless they ack and I apply in the drm-intel along with the other ones.

> ---
>  drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c
> index 03f081c3d9a4..baccbf1761b7 100644
> --- a/drivers/gpu/drm/i915/gvt/debugfs.c
> +++ b/drivers/gpu/drm/i915/gvt/debugfs.c
> @@ -165,7 +165,7 @@ static int vgpu_status_get(void *data, u64 *val)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n");
>  
>  /**
>   * intel_gvt_debugfs_add_vgpu - register debugfs entries for a vGPU
> @@ -182,8 +182,8 @@ void intel_gvt_debugfs_add_vgpu(struct intel_vgpu *vgpu)
>  			    &vgpu_mmio_diff_fops);
>  	debugfs_create_file_unsafe("scan_nonprivbb", 0644, vgpu->debugfs, vgpu,
>  				   &vgpu_scan_nonprivbb_fops);
> -	debugfs_create_file("status", 0644, vgpu->debugfs, vgpu,
> -			    &vgpu_status_fops);
> +	debugfs_create_file_unsafe("status", 0644, vgpu->debugfs, vgpu,
> +				   &vgpu_status_fops);
>  }
>  
>  /**
> -- 
> 2.34.1
> 
> 
>