Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4203dea-93a9-6903-d635-c36ff47337c9@linux.ibm.com>
Date:   Tue, 10 Jan 2023 20:15:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2] KVM: s390: interrupt: use READ_ONCE() before cmpxchg()
Content-Language: en-US
To:     Heiko Carstens <hca@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc:     David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230109145456.2895385-1-hca@linux.ibm.com>
From:   Christian Borntraeger <borntraeger@linux.ibm.com>
In-Reply-To: <20230109145456.2895385-1-hca@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


Am 09.01.23 um 15:54 schrieb Heiko Carstens:
> Use READ_ONCE() before cmpxchg() to prevent that the compiler generates
> code that fetches the to be compared old value several times from memory.
> 
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Looks sane.

Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>

In case you want to take it via the s390 tree:
Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>

> ---
> 
> v2: make it compile
> 
> arch/s390/kvm/interrupt.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 1dae78deddf2..ab26aa53ee37 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -83,8 +83,9 @@ static int sca_inject_ext_call(struct kvm_vcpu *vcpu, int src_id)
>   		struct esca_block *sca = vcpu->kvm->arch.sca;
>   		union esca_sigp_ctrl *sigp_ctrl =
>   			&(sca->cpu[vcpu->vcpu_id].sigp_ctrl);
> -		union esca_sigp_ctrl new_val = {0}, old_val = *sigp_ctrl;
> +		union esca_sigp_ctrl new_val = {0}, old_val;
>   
> +		old_val = READ_ONCE(*sigp_ctrl);
>   		new_val.scn = src_id;
>   		new_val.c = 1;
>   		old_val.c = 0;
> @@ -95,8 +96,9 @@ static int sca_inject_ext_call(struct kvm_vcpu *vcpu, int src_id)
>   		struct bsca_block *sca = vcpu->kvm->arch.sca;
>   		union bsca_sigp_ctrl *sigp_ctrl =
>   			&(sca->cpu[vcpu->vcpu_id].sigp_ctrl);
> -		union bsca_sigp_ctrl new_val = {0}, old_val = *sigp_ctrl;
> +		union bsca_sigp_ctrl new_val = {0}, old_val;
>   
> +		old_val = READ_ONCE(*sigp_ctrl);
>   		new_val.scn = src_id;
>   		new_val.c = 1;
>   		old_val.c = 0;
> @@ -126,16 +128,18 @@ static void sca_clear_ext_call(struct kvm_vcpu *vcpu)
>   		struct esca_block *sca = vcpu->kvm->arch.sca;
>   		union esca_sigp_ctrl *sigp_ctrl =
>   			&(sca->cpu[vcpu->vcpu_id].sigp_ctrl);
> -		union esca_sigp_ctrl old = *sigp_ctrl;
> +		union esca_sigp_ctrl old;
>   
> +		old = READ_ONCE(*sigp_ctrl);
>   		expect = old.value;
>   		rc = cmpxchg(&sigp_ctrl->value, old.value, 0);
>   	} else {
>   		struct bsca_block *sca = vcpu->kvm->arch.sca;
>   		union bsca_sigp_ctrl *sigp_ctrl =
>   			&(sca->cpu[vcpu->vcpu_id].sigp_ctrl);
> -		union bsca_sigp_ctrl old = *sigp_ctrl;
> +		union bsca_sigp_ctrl old;
>   
> +		old = READ_ONCE(*sigp_ctrl);
>   		expect = old.value;
>   		rc = cmpxchg(&sigp_ctrl->value, old.value, 0);
>   	}