Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 14:28:11 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     "Gustavo A. R. Silva" <gustavoars@kernel.org>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH][next] drm/i915/guc: Replace zero-length arrays with
 flexible-array members
Message-ID: <Y728SwYZeThQzohb@intel.com>
References: <Y72WBTUmh9r1lvKN@work>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y72WBTUmh9r1lvKN@work>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jQ4ZzYowF6pAbt7L2GtBAUnqH4KjAj2J5kXqDq7JvFU9Q2fSp3tsebKamebV?=
 =?us-ascii?Q?KsEdRlDhayk6Ta3rKjxnkE+y/Bsvhfs42Cmiw+DPlSN1EsnysAMTh2T8J5t5?=
 =?us-ascii?Q?CAhC7+sSdYTWjmtGaBiX4b8ngOW2xzbBcXTwHyxRHigAeGuBiK69WZoNGcBl?=
 =?us-ascii?Q?HP/7DjBy7HH8e3kgGXoTTvlRLKP6yV0HdWo24XeN2XiYQYcDkulzRSdT6cSt?=
 =?us-ascii?Q?iEWg611gPaUdGZZGtOSw+kYS2oG0nLSO6SqBb2nQZObFfrpKzqy4WhjfEpvk?=
 =?us-ascii?Q?6Ort6PqB8KM4Nl/zfpRlnwEe/KVb0ZYzvh3rSIy24VRe/+qkuioU9znR6y7f?=
 =?us-ascii?Q?1vv1BfcO0MyDQL9l6L9SCOwE04Ksda5ryKZ7XfasjCIf0ykrbfZUEDYNGCI7?=
 =?us-ascii?Q?YCNEuAkIboacfAfzDkjApqxRtDw0GPPiYWIeLPtxUHdKD6mSAU4erdcWuXg+?=
 =?us-ascii?Q?ZESXSrC+dJJx2lDWD8A7WTOLpKBcmaq9/CSx38htVJ7VeEAmVLZUY+/tigc1?=
 =?us-ascii?Q?sieIx3c77/18EntYR7Xh5pyN2+NGByt4hGZ8AV3hVXCuK6uG/J2x/BL5NW+P?=
 =?us-ascii?Q?6Q574yWE22KrDQyspHw/2z/IJd+jZuKAgsCi3osCFaxwsd4s+HyNk+CUUgae?=
 =?us-ascii?Q?qbzYVUIg60lC97JlUzNuj4O8p36awxdwNBp4GzO+A1sQnpSkKqIBFKul15WU?=
 =?us-ascii?Q?kqAsKYKcLPjP/y6skDMoPeqfBxDV9Msn2er508FPyuNEIIwA8bfcLrEjnnoX?=
 =?us-ascii?Q?/xiF1BSTvZie3SzQ6Eij0r3iEWwxR0LXmOtxHc18B/YFUoMVzM5dVx9X3Ctx?=
 =?us-ascii?Q?+6QIcVJOuMZ8lcv1Fch9nmWcbibiqA/mp8fPm0M0miRyACyWhzq0HKyY+JWX?=
 =?us-ascii?Q?V5ctuNiwDmPKThVJhswvjJw6Nt00CCkAhS0bjxzOhNJwfhoh6hqNinZpMnnC?=
 =?us-ascii?Q?ME+hYBR7rR1Kv3ADXLBAAegx2XIDbip1HbYodj6iokhyJEkaaO/gIFTnbKD0?=
 =?us-ascii?Q?Kp13fAimCjGkxATLAjVnCS4MY3+bLLbip+h0ZZiqTclpOoNVhTzVtcvxqAs/?=
 =?us-ascii?Q?ChqCPFvbh2trbVc9tQPcwhK9w/Vrb4gw1VZESE/BkMmwgfaKb0Q3+GtTzm17?=
 =?us-ascii?Q?E9Cijw5v/TVilFbKTZ0cd/nVabBpr4iko4XVx1PBJ+ae0LcRZoMyiZN9rhAA?=
 =?us-ascii?Q?tgOYJRK7Rq+8k9O7jUBMsmOoqvC+lo6PawRjLQjmFbzGT8+nzybZ6HRqILKu?=
 =?us-ascii?Q?/iY/fYNlL8LlY9Ew1hMLf+AwlpNDP7u9WjK+MH1TDMQ7gXwsRKy+YObIGLBI?=
 =?us-ascii?Q?AVu/IFPMP1cUWZYCRHxi4d89aDRHDwZh9SKJmblhngJZqHV1tkGsMRlqw1dB?=
 =?us-ascii?Q?iz6hnqkxEZ4RUqf3YlKI6aB/pyYU/E/M8NHj8/4TZhO3ZafmlbZq2Cbu9pVC?=
 =?us-ascii?Q?eQFUsQy71WQv+jp3pmM5yuK/iNFf0PUz7nOuIGN8kJ3ugFOHjD9ESLxk6Co2?=
 =?us-ascii?Q?K0NIYBBul8H50DYr/R+RkDhlgH/w5mwd7rUhXyn55OmOVFDPOjd10jkai3NU?=
 =?us-ascii?Q?zQ9aQgkNKoxxbzZxjjs1m2rXcfFMON6FOHfmtAk43AaNXRulyNgsWxS5/PdP?=
 =?us-ascii?Q?Sw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cfaab432-7eac-4584-01c9-08daf340d30e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 19:28:17.3056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3zbprlyQm30O2gAVhoirqufQmMYUg7nNElvUd2Cx5l7OY6of/dh8e1X7QJu6trkW/AgpDNuNfPyF3SQHKZPMkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4894
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Tue, Jan 10, 2023 at 10:44:53AM -0600, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated[1] and we are moving towards
> adopting C99 flexible-array members, instead. So, replace zero-length
> arrays in a couple of structures (three, actually) with flex-array
> members.
> 
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [2].
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

> ---
>  drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h b/drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
> index 3624abfd22d1..9d589c28f40f 100644
> --- a/drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
> +++ b/drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h
> @@ -73,7 +73,7 @@ struct guc_debug_capture_list_header {
>  
>  struct guc_debug_capture_list {
>  	struct guc_debug_capture_list_header header;
> -	struct guc_mmio_reg regs[0];
> +	struct guc_mmio_reg regs[];
>  } __packed;
>  
>  /**
> @@ -125,7 +125,7 @@ struct guc_state_capture_header_t {
>  
>  struct guc_state_capture_t {
>  	struct guc_state_capture_header_t header;
> -	struct guc_mmio_reg mmio_entries[0];
> +	struct guc_mmio_reg mmio_entries[];
>  } __packed;
>  
>  enum guc_capture_group_types {
> @@ -145,7 +145,7 @@ struct guc_state_capture_group_header_t {
>  /* this is the top level structure where an error-capture dump starts */
>  struct guc_state_capture_group_t {
>  	struct guc_state_capture_group_header_t grp_header;
> -	struct guc_state_capture_t capture_entries[0];
> +	struct guc_state_capture_t capture_entries[];

Please notice we are currently using sizeof(struct ...).
Along with your proposed changes, shouldn't we also start using
the struct_size() which already take the flexible array into account?

>  } __packed;
>  
>  /**
> -- 
> 2.34.1
>