Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d935618-8f84-2d6e-4f4c-9d38eec2ba67@intel.com>
Date:   Tue, 10 Jan 2023 12:14:10 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 1/7] x86/cpu: Enumerate LASS CPUID and CR4 bits
Content-Language: en-US
To:     Yian Chen <yian.chen@intel.com>, <linux-kernel@vger.kernel.org>,
        <x86@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ravi Shankar <ravi.v.shankar@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, Paul Lai <paul.c.lai@intel.com>
References: <20230110055204.3227669-1-yian.chen@intel.com>
 <20230110055204.3227669-2-yian.chen@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20230110055204.3227669-2-yian.chen@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djI5cktEQWs4R1JUaTcweDRZQXFvSWxwTFRiR3YxcnlzQ3BWbGx6aHg1NWZR?=
 =?utf-8?B?YldzZFdSRkdlb09STGptV2hBT0tKU29RdTJISk0rZGptVlMvUWxYbDBmajRq?=
 =?utf-8?B?OW81TDR4Y245bk1oSnFqQU91YUltSnF5NS9yTU03bGpPS0phK3VNUWJMQmhJ?=
 =?utf-8?B?SXcwcXpOOTBobTFiOFQwcmlMbmhsWkxmLzJjMkVjRTN4RFBFYUNtYVkrWUVO?=
 =?utf-8?B?dWNIWjZWOE9xclkvcS91ZnpFbW40RWhXbCt3WjlRUkkwaTRmWWNMdkw5TFR2?=
 =?utf-8?B?ZzQzcEtnMFdqU1psSUNYelpCSEE1cDJvTk14dk14cWl0Ty91NktvemNqbFNN?=
 =?utf-8?B?b2xKNThJS2ZWbzdXWkhiUStrTFBYanVqQXFhdk9ITkZncU50NGZEbFdNTUF2?=
 =?utf-8?B?WnpIR0UzVENaMENZUnZzbU5CTUdITEQzVHZWOE15VkNyaEtlVEd5ZXU0T1Nx?=
 =?utf-8?B?ZU1NUkZwdmJaTkFISE9XK0xvQjk2TFE2b2NPS2owR1N2dEtOV21UNEZBbFMw?=
 =?utf-8?B?c082b1c2alFZRjRua2hqMG9PRzhBMzR5b0dIMlBMOXpEaVlOMkR6ZFRnWG9a?=
 =?utf-8?B?VkdlN0t2MTllVFpvUTVmSFlrZ3hEQ0dRcEpnSGhZOHUwZ2k4SzVnNG1EZmFZ?=
 =?utf-8?B?WURxaXBWcm5PNFFZQmtJbjhIdHpYTXhTZlRXMVB2dHhLTTNUdmNhb3VnMmI3?=
 =?utf-8?B?dTNMV0d3M0U5bEtxYUg4MGFkWXFoSmVnYlFEbVY5a1Zjank5VEplZ3E3eWxT?=
 =?utf-8?B?bDZNekloRjc4RkxvVHNJVWxUeXI4M3ljdkN3ZlQwd05rMlYrUUQ1RDJJd0VF?=
 =?utf-8?B?aW0zSVFDOW4vVCtuamJJdGFzVStrSzF2Tk9oS3VnS2IxbE5zT0NFemVBZ3dQ?=
 =?utf-8?B?R1FDM1JsUVNvS1pRekRRQklSNFZicUhWVDg2aWVNVlJES3hOUmdLUEt6Tjla?=
 =?utf-8?B?c1YvbERVL2FBdnFJZEJFN0pSV0xyRjhvM2lwOUNlMGtQZS9PbW9OY200aUEv?=
 =?utf-8?B?bHE0RU80SFJVQVhRL1M0dHg1U2U3Um5lcWFNbFFBMDU2cWdnQWtBOTZvRTJh?=
 =?utf-8?B?aGVnbEYyNE4wZSsyZkM5NXdHMGpjMHkrSGhvNERuaWtrekZFQVBIamNaNmJJ?=
 =?utf-8?B?RUVVV3FwK1NtL3daaGJuZGh0azEvTFgzRi9VV1VDUGxLdHRsMmVRcWNETmRW?=
 =?utf-8?B?Y1RDTkxCT3hkbkNBb1hmY1dyL0toY2NOZHBuWkk3WTc5R1FrckhtbmlzVU5x?=
 =?utf-8?B?cUt3SlFqR1p6bGgwc3NlamhuYjlxZW9XWHFPa2tnRTM0QklPMi9RRXhqWUFp?=
 =?utf-8?B?VkpxWEE2N1UrYnhXVGh2aWVQcmt3YUpES3VnSXo5NW5vNW5MbWkrUWxSNXZ6?=
 =?utf-8?B?TXJMc29zQ1dUU1l4cGExRHJIalZXZ0U2QVJyem53eGNqRlROZkloWlhPeHRL?=
 =?utf-8?B?aWJjMmpEK2c3ZnVZa0g5QTBnL1pUdlZRVnhYMVNqYkNmeGVVNmpUOVJ6clh3?=
 =?utf-8?B?Mlg1Nmk1TkRncnNtczlNMXg3aGpnN1FJYk1IUzd0T3ZGMEs5T3pyWFl1Z2o3?=
 =?utf-8?B?aXFTRlNpSmVVZkpQdjlPb3ZqQkNxTW13SmFYUy9kdHJuQ1QvMm5OeTk0QkVY?=
 =?utf-8?B?SkF6QnR0ZGwvd05QMXFENjhwbDAwdGtrR3MwU0ZuRTZJRVdWZ3h0eE1sNUVx?=
 =?utf-8?B?ck5uN3NpTkRsZkJNSEF6UC9ONWVpcVV5REJCSGEzODlaZXpEdndaU1ZBdkVB?=
 =?utf-8?B?MEJDZzlvaUJOa3IvNkExY3B4d21zb1FJVGVQRnJwTHFQRitFa29VTWZiS1Bq?=
 =?utf-8?B?bnRvd2FIS1F2eWNqVU5CdHR5VVcvSlE0WDc4RVU5YUNvK1N1Tk5zU0pITmpV?=
 =?utf-8?B?YXZQdWlLU0NHeHR1aHcrbDhLdDh1NSs3aDllb0R4ZmRZMEJVaXFYSmFJd2hP?=
 =?utf-8?B?cWl3TUcyQjZoUXczV3pJTS9XVVBKS2pwYmlYQmdKNzRlVkNhNGxrZko2Unc5?=
 =?utf-8?B?dkx4ekJFb3NuQUNUZjJpeHRvZFMyVDFmRzhTTDg1NGxOSHI3YnRnZHVxVzh3?=
 =?utf-8?B?ZmZZRXlmWG1uQjJoWHlWVW16aW9nRlk0ZTFUdDJpZGwrUGt4VHZpa0xmMFJ4?=
 =?utf-8?Q?B56Wt3VrhgxE14QLmkaqHV8Lh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e8c26233-eea5-4184-125f-08daf3473da8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 20:14:13.0405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Whvb4oVMcqH8zmVA6yrkSOu3IPsrXcgRaQanZiIQZJ2TDdwLBOfsz4g3YtCNcv9nWyYrhiMZbgO/r7Lnkt8dqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5019
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/9/2023 9:51 PM, Yian Chen wrote:
> LASS (Linear Address Space Separation) is a CPU feature to
> prevent speculative address access in user/kernel mode.
> 

Would it be better to say?

LASS (Linear Address Space Separation) is a security feature that 
intends to prevent unintentional speculative address access across 
user/kernel mode.


> LASS partitions 64-bit virtual address space into two
> halves, lower address (LA[63]=0) and upper address
> (LA[63]=1). It stops any data access or code execution
>      1. from upper half address space to any lower half address
>      2, from lower half address space to any upper half address
> and generates #GP fault for a violation.
> 

I am not sure if this is the best way to say it. The kernel already 
partitions the address space this way. LASS takes what is already the 
typical OS implementation and bakes it into the hardware architecture.

> In Linux, this means LASS does not allow both kernel code
> to access any user space address and user code to access
> any kernel space address.
> 

There is clearly an overlap between the protections provided by paging 
and with SMAP and SMEP. It would be useful to paraphrase some of the 
information mentioned in the spec regarding how LASS differs from them.

"With these mode-based protections, paging can prevent malicious 
software from directly reading or writing memory inappropriately. To 
enforce these protections, the processor must traverse the hierarchy of 
paging structures in memory. Unprivileged software can use timing 
information resulting from this traversal to determine details about the 
paging structures, and these details may be used to determine the layout 
of supervisor memory.

Linear-address space separation (LASS) is an independent mechanism that 
enforces the same mode-based protections as paging but without 
traversing the paging structures. Because the protections enforced by 
LASS are applied before paging, “probes” by malicious software will 
provide no paging-based timing information."

> Signed-off-by: Yian Chen <yian.chen@intel.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>