Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 22:01:10 +0000
From:   Mark Brown <broonie@kernel.org>
To:     William Zhang <william.zhang@broadcom.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Linux SPI List <linux-spi@vger.kernel.org>,
        Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
        anand.gore@broadcom.com, tomer.yacoby@broadcom.com,
        dan.beygelman@broadcom.com, joel.peshkin@broadcom.com,
        f.fainelli@gmail.com, jonas.gorski@gmail.com,
        kursad.oney@broadcom.com, dregan@mail.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/16] dt-bindings: spi: Add spi peripheral specific
 property
Message-ID: <Y73gJhlzHz6waIvf@sirena.org.uk>
References: <20230106200809.330769-1-william.zhang@broadcom.com>
 <20230106200809.330769-4-william.zhang@broadcom.com>
 <Y7iPS48viBg0QRok@sirena.org.uk>
 <3ff9a7fa-25dd-701c-078e-03e47bd3c08b@broadcom.com>
 <CAL_JsqJ7kr-6xs53NYJufem=wXnXVRnj3-1t1rG+W6g09kJ3ew@mail.gmail.com>
 <6720e3a4-dbbb-f490-98db-511a52b9a2ab@broadcom.com>
 <Y7xosoZMJEwRi1ok@sirena.org.uk>
 <f55ab390-a784-d598-8d0e-b78040fdbb73@broadcom.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="8k6YxWNEbCoXLS2/"
Content-Disposition: inline
In-Reply-To: <f55ab390-a784-d598-8d0e-b78040fdbb73@broadcom.com>
Precedence: bulk


--8k6YxWNEbCoXLS2/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 09, 2023 at 12:18:09PM -0800, William Zhang wrote:

> This setting is set per spi message for particular chip select of the device
> when starting the message through bcm63xx_hsspi_set_clk function and restore
> to default(clock gating) when message is done through
> bcm63xx_hsspi_restore_clk_gate.

In that case I am extremely confused about what the feature is supposed
to do.  The description says:

+  brcm,no-clk-gate:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      Some SPI device such as Broadcom ISI based voice daughtercard requires
+SPI
+      clock running even when chip select is deasserted. By default the
+      controller turns off or gate the clock when cs is not active to save
+      power. This flag tells the controller driver to keep the clock running
+      when chip select is not active.


which to me sounds like the clock should never be turned off and instead
left running at all times.  Switching back to clock gating after sending
the message doesn't seem to correspond to the above at all, the message
being done would normally also be the point at which chip select is
deasserted.

--8k6YxWNEbCoXLS2/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmO94CUACgkQJNaLcl1U
h9CdJAf/QI6A4fWPY4QxulQZlgN08+3prwWv5cDXiANd7ma60ajOD9YwY0ajx9gb
iM6BzxPjLHgbRvvR0WtDxt47NWLBJr2rf9B4hBTjr5EZdX2fWurcx3aJTnD+eNG2
x7zASz234aU7ZEPr3jNsm/JAs2nJYJDiAVBSNPuplyX4fDmPUZQmrDBP3uaAhdO9
7WzWvaPY8ZomdB4V1Onv0oz9x8xXX/c0Ngx36V4XR1zsOqbnbzValVoHDJ6y3geu
d6ejtbA1wtuowzV3csuYVq/tkw3Az9h9idivu3UW7qaTmvjIUL374AHeSUUG+b1C
Dr4pP7nqnpJkzBu179zn+QlTBB/j0A==
=qE5i
-----END PGP SIGNATURE-----

--8k6YxWNEbCoXLS2/--