Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <693d8332-3b86-3dcf-fc87-5c3a08a752db@intel.com>
Date:   Tue, 10 Jan 2023 14:41:25 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 3/7] x86/cpu: Disable kernel LASS when patching kernel
 alternatives
Content-Language: en-US
To:     Yian Chen <yian.chen@intel.com>, <linux-kernel@vger.kernel.org>,
        <x86@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ravi Shankar <ravi.v.shankar@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, Paul Lai <paul.c.lai@intel.com>
References: <20230110055204.3227669-1-yian.chen@intel.com>
 <20230110055204.3227669-4-yian.chen@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20230110055204.3227669-4-yian.chen@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFFZdWlLWFN2OXlYb2QvZWo2bDYvNWM4ZFNMSW9ZeXRvUVV2Z0RPYTFYWERy?=
 =?utf-8?B?NVpQZWEzUWRRbnpPNmRhdzVtZFVSbGE4Z2YyVkxQdE51cTNQZnkwTFpvSnMr?=
 =?utf-8?B?QWl4UkhrTGZJTTR5bnpTRUdtS0l4WExkZFJkb3p3Nk02QWpuZ050RkMyQStK?=
 =?utf-8?B?R3hhKytnWVVoc2NoNXJMZmxQb2pSSlZvd2Y4UWRHRGwvejVQdE1HKzVYYWZR?=
 =?utf-8?B?MTQ1MVNLN3kzVk11T0pIM1dqeDh2UjBNUFZad01kSVFLZzVTUEwvOE54ZEpL?=
 =?utf-8?B?TDhtVjZpdXAvOHJoeVFJRkJGNjFLN2tyaDl3WHZZbFpoQnMzUlQzZUk0Y3Br?=
 =?utf-8?B?cGNKQ3kwYWgrWVJxanVVWVdSeWgyOGVWdWRHaGRjemRXU1dHc1RWWmNocDND?=
 =?utf-8?B?NUdubEtScytPMUNZemUrYkV0TGl6S09oSGdmdEJEcHRVbDR5bVZqRDlRTVNZ?=
 =?utf-8?B?akU0MmFadmp1OXRpazh6cWRhbTUxc2Z6MjJzR2tNUkNMM2ZXdUVuWTN5dDRp?=
 =?utf-8?B?eFAwTy9rZW0vK3k5cm42Z1RvaHB0MmU1S2dTWnlpeDZGRG1lN0orK1hMNFRi?=
 =?utf-8?B?M3RPNHNlc1VuYmU2SFdiT2lJcHB1N3l4ZmVJeHlOYjYyUmptNVhlWEtTSWdX?=
 =?utf-8?B?Y3BiMTNQQ3NtRlJwaUU3dUpteUNiakhrUWJiVGxPZzhacDhLQTBKcUsyb1JK?=
 =?utf-8?B?RmxVck1rMVFBRFMrOHMrL2FHazhaNjJnaXJ5bTJyNTRMV1pkazc1VWZvRGVj?=
 =?utf-8?B?eVV3Um91ZS9aZis0THArOGMvZ3lnWGQ1cDViSVo1YmlqdlIvMU4zdGV4SmM4?=
 =?utf-8?B?Uzl0U2FCL29oM20xMFFJUVNWTnJGaitOaXpHaU8xTUFRQjFXQ0VXQllTN080?=
 =?utf-8?B?ZVJQRTJ3bXVmRWx1ckxIby9LdkFTS0Fua0E4cUJjM2hnYlN5V1BIemd6RG1t?=
 =?utf-8?B?UGFBeUZvWHVwMVdpTitlbm1YTmJnZFJZTHFpaXNEQzAzbFJzTDRCdXI4bHJH?=
 =?utf-8?B?Z1ZOMVMraldQd1VwMmtqN1RCSEo2cEJDM25lTFFzNDliaENzQW1hZm1tUTRV?=
 =?utf-8?B?ck8velpQUDh4Mjl5cUc1ekJUR1ZDMytOaHdDdmxXaG1OcDdaZHJIZGZWcUhB?=
 =?utf-8?B?dnl3TDNhSkdZTi9aSjRIcUlFbnZVeEJjdTNCdGlMQkdSMHQvV1ZRTmI1SU9j?=
 =?utf-8?B?SjlUUlV2Y3FNdGhOb0ZTN1NuUGFFMGEvNHppZUF6Q1pHMEIyQzhnZW1TVllu?=
 =?utf-8?B?a0MxNmMzQ3p1STBuN3BaN0pBaXBTMGFGM1VnTkNBVzgzSUtJSkRCdmVkUFVL?=
 =?utf-8?B?cWlKQzdURE1pY3l6SE1ydGxVNTB3NTFRWU5uTTJDV2NMRjhuVzlRMG0yOGls?=
 =?utf-8?B?NHh4ZlI4L2tSd2VWc245eW1iSy9SRmRuT051N1AwelZqVEpoN3J6Y1BYMDhI?=
 =?utf-8?B?bk9vQmdHVUk0SDdlRy9qR2d0ajQ3NkgvbktZK1RSYWpoM0pDc283OWVyQXNh?=
 =?utf-8?B?ZXcwTDdYR0FLOVpqRzcrNitQMTY0ZGdUYmk4clQxYTJIR3ZhdVhuaG1ITXRW?=
 =?utf-8?B?Qm5TZDFNVVZlRC91Si9DSWdJOGFRL21nZW81SDVBaXNqM1NZaDdiRTFqRW9l?=
 =?utf-8?B?Nmhqa0Q1bWMyL29UTDFSNE9DMjBYcXpmUWw2b3BDYWRYVFRZZFJ2MmJlOHFG?=
 =?utf-8?B?YzdrV1ZIcVNpd3dWWit6eFJOWTlpTk5pRHYvbWJIcVMwUHJ5MGRWL0lDdzEw?=
 =?utf-8?B?aXRxZU1KcTNrVi9xaHk1M2h6VW41NXIwUHRFYjNUbzRENHRQcVFDQUJmMUtI?=
 =?utf-8?B?TFdORVVHMUpXU2xWaTIvb1FMT211bTBjWEY0TmFJelQ3WFVPaVRQTnB5U1R3?=
 =?utf-8?B?MnBqTzdTNmpwY1NQUjQ5Qzk4bnN2dTdYNnZ3TlpnNE0yQU52Qk9KclZ6VFBz?=
 =?utf-8?B?NGVFSEYrYldNY25JMUhuMnNIK252dTBuR3Y3TGRaRWdFTXdycm1GODBYMkRE?=
 =?utf-8?B?YkcrTVJLNFVhZVAxWjZTdlN3VHpsamF6c2lXV2k1eWhST1lzeVl5ZnBuZ0xG?=
 =?utf-8?B?V1VHYzNBUjIvSElJRjgvVUovKzhhVnVndFlUdGJxZVNvZzFUMTZpWEh6RkZ0?=
 =?utf-8?Q?mIzY1ab3FAa8PRKWJiR292Vmq?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d9bbba5b-b8a1-4623-53ac-08daf35bcef8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 22:41:27.0675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ++vIk1uQyxec23eJVx8ylOXsj+tNcI+W9tDwtEajp2+Xwg03mEM7Sg4vS0K1PgRT5D7qLbeXpzgmtSxY/g94KA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4791
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/9/2023 9:52 PM, Yian Chen wrote:

> LASS stops access to a lower half address in kernel,
> and this can be deactivated if AC bit in EFLAGS
> register is set. Hence use stac and clac instructions
> around access to the address to avoid triggering a
> LASS #GP fault.
> 

It seems we are implicitly relying on the on stac() and clac() calls 
that are added for SMAP. Have you tried running with SMAP disabled  i.e 
"clearcpuid=smap"?

I believe there needs to be a dependency between LASS and SMAP.

diff --git a/arch/x86/kernel/cpu/cpuid-deps.c 
b/arch/x86/kernel/cpu/cpuid-deps.c
index d95221117129..00bc7e4a65d2 100644
--- a/arch/x86/kernel/cpu/cpuid-deps.c
+++ b/arch/x86/kernel/cpu/cpuid-deps.c
@@ -79,6 +79,7 @@ static const struct cpuid_dep cpuid_deps[] = {
  	{ X86_FEATURE_XFD,			X86_FEATURE_XSAVES    },
  	{ X86_FEATURE_XFD,			X86_FEATURE_XGETBV1   },
  	{ X86_FEATURE_AMX_TILE,			X86_FEATURE_XFD       },
+	{ X86_FEATURE_LASS,			X86_FEATURE_SMAP      },
  	{}
  };