Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 04:15:38 +0530
From:   Bhaskar Chowdhury <unixbhaskar@gmail.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ver_linux: add missing software to checklist
Message-ID: <Y73qkkf0MZAvJCNN@Gentoo>
Mail-Followup-To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
        Shuah Khan <skhan@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
References: <20230110204225.35503-1-skhan@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="njgvF1plAGMbCVg3"
Content-Disposition: inline
In-Reply-To: <20230110204225.35503-1-skhan@linuxfoundation.org>
Precedence: bulk


--njgvF1plAGMbCVg3
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

On 13:42 Tue 10 Jan 2023, Shuah Khan wrote:
>Update to add missing software checks to bring it in sync with the
>Documentation/Changes list. Make improvements to the output with
>separator between different sections.
>
>Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
>---
> scripts/ver_linux | 29 ++++++++++++++++++++++++++---
> 1 file changed, 26 insertions(+), 3 deletions(-)
>
>diff --git a/scripts/ver_linux b/scripts/ver_linux
>index 1a8ee4ff0e32..6131f6f1b35b 100755
>--- a/scripts/ver_linux
>+++ b/scripts/ver_linux
>@@ -6,10 +6,14 @@
> # differ on your system.
>
> BEGIN {
>-	usage = "If some fields are empty or look unusual you may have an old version.\n"
>-	usage = usage "Compare to the current minimal requirements in Documentation/Changes.\n"
>+	usage = "Minimum required software versions to build and run current kernel version.\n"
>+	usage = usage "If some fields are empty or look unusual you may have an old version.\n"
>+	usage = usage "Compare with the current minimal requirements in Documentation/Changes.\n"
> 	print usage
>
>+	separator = "===================================================\n"
>+
>+	print separator
> 	system("uname -a")
> 	printf("\n")
>
>@@ -17,9 +21,15 @@ BEGIN {
> 	libc = "libc[.]so[.][0-9]+$"
> 	libcpp = "(libg|stdc)[+]+[.]so([.][0-9]+)+$"
>
>+	print separator
> 	printversion("GNU C", version("gcc -dumpversion"))
>+	printversion("Clang/LLVM (optional)", version("clang --version"))
>+	printversion("Rust (optional)", version("rustc --version"))
>+	printversion("bindgen (optional)", version("bindgen --version"))
> 	printversion("GNU Make", version("make --version"))
>+	printversion("bash", version("bash --version"))
> 	printversion("Binutils", version("ld -v"))
>+	printversion("pahole", version("pahole --version"))
> 	printversion("Util-linux", version("mount --version"))
> 	printversion("Mount", version("mount --version"))
> 	printversion("Module-init-tools", version("depmod -V"))
>@@ -28,6 +38,8 @@ BEGIN {
> 	printversion("Reiserfsprogs", version("reiserfsck -V"))
> 	printversion("Reiser4fsprogs", version("fsck.reiser4 -V"))
> 	printversion("Xfsprogs", version("xfs_db -V"))
>+	printversion("squashfs-tools", version("mksquashfs -version"))
>+	printversion("btrfs-progs", version("mkfs.btrfs --version"))
> 	printversion("Pcmciautils", version("pccardctl -V"))
> 	printversion("Pcmcia-cs", version("cardmgr -V"))
> 	printversion("Quota-tools", version("quota -V"))
>@@ -36,7 +48,16 @@ BEGIN {
> 	printversion("Nfs-utils", version("showmount --version"))
> 	printversion("Bison", version("bison --version"))
> 	printversion("Flex", version("flex --version"))
>+	printversion("Grub", version("grub-install --version"))
>+	printversion("mcelog", version("mcelog --version"))
>+	printversion("iptables", version("iptables --version"))
>+	printversion("openssl & libcrypto", version("openssl version"))
>+	printversion("bc", version("bc --version"))
>+	printversion("Sphinx (for doc builds)", version("sphinx-build --version"))
>+	printversion("cpio", version("cpio --version"))
>+	printf("\n")
>
>+	print separator
> 	while ("ldconfig -p 2>/dev/null" | getline > 0)
> 		if ($NF ~ libc || $NF ~ libcpp)
> 			if (!seen[ver = version("readlink " $NF)]++)
>@@ -50,12 +71,14 @@ BEGIN {
> 	printversion("Sh-utils", version("expr --v"))
> 	printversion("Udev", version("udevadm --version"))
> 	printversion("Wireless-tools", version("iwconfig --version"))
>+	printf("\n")
>
>+	print separator
> 	while ("sort /proc/modules" | getline > 0) {
> 		mods = mods sep $1
> 		sep = " "
> 	}
>-	printversion("Modules Loaded", mods)
>+	printversion("Modules Loaded:\n", mods)
> }
>
> function version(cmd,    ver) {
>--
>2.34.1
>
Hunch....

One, is grub required to compile kernel?

Second, can we please stick to " absolutely required software" than showing optional??

Separator adding is good one.

--
Thanks,
Bhaskar

"Here's looking at you kid"-- Casablanca
https://about.me/unixbhaskar

--njgvF1plAGMbCVg3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAmO96pIACgkQsjqdtxFL
KRVoewgAlPo+RIzbPwPElvilRNQlXpLvJuPVG700pAqVCcRZVLIWLz2tv/J+6QHJ
xp+fLTzR+H8FrgecMNcDyKGG4GkoQwVxQotNij1C31oFSvNjm4Csv13aPm0Bru87
tayrdUxga63QPv2OJ3fjk8Zrjq3nXoOQHJNiO62kHRqpGdwV1+MaS6L7e8RyJo4b
nsKwWuEVIzHfVs/U0iAJIGyL5h8M4bBkvdf/sfC4eSYsr1k+lpE15V9vsbR7fsKL
N+gvuzibry2jf2+CTBrq1+pITL1m0PA6XxyYp7roE/FkbA1QCzeEH5bmdzGZ5sec
InFWcbY10RWsqqv7McKcbMqV6Oi2/Q==
=D9JT
-----END PGP SIGNATURE-----

--njgvF1plAGMbCVg3--