Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8600029rwl; Tue, 10 Jan 2023 16:16:27 -0800 (PST) X-Google-Smtp-Source: AMrXdXvhlpmCcFfBgfgerfksWz0y7DVBAbnLa9RNaH98ukQ70LRQbHnxOWCRQJdODREDOvG2OYSk X-Received: by 2002:a50:fb02:0:b0:498:5dfd:6826 with SMTP id d2-20020a50fb02000000b004985dfd6826mr11425679edq.42.1673396186976; Tue, 10 Jan 2023 16:16:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673396186; cv=none; d=google.com; s=arc-20160816; b=uWjpXB3NmVRUjjhNFQGZSxKw9S09/mIA/DCxa7K92WbCCsTXBeEw29ZfCJdvQYLVn4 HHkLmvdDPovxQBZ1e5O1KeElkUlimHYPp/w95lCFU+vxwEH9KGwTJdNMsPLzQqb/TiT9 aMpB5FdvXIhOoowfXI8shrhr9Ml2lTO0UzH3PGBDfCe9DuGA4zCbg4MX1uf0699fa/IU tjfODsyoBiNp+xxwUbxyRw0TJNc/1YA7xx6L4jm/aRsOlSQcH8IKXoIeZu9tdaubzeKu uZReelrBiklndx/ly4K7uT4yAOrArpAslBWSDyQUWCSRag2FX+jz8wKl5i0h5w6Cm6z8 SDBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lLdl4WVOaoFufveIzKd2WoV5JXBLLKx2viavyLAWLzg=; b=gLXR3SmoL0tKZqBZyTdrU8spJ14wLMoNgt/oWqdwIKMWbkEwe3eLjLZ3ZqhmsbwP02 3LOKR49QUKyzpsh1ouWt5m/JygHCMi9deM89xjZYKR1r+HkzkkFTaFds+ND7gyGfPKLr GUzaZ1aQ0aSty5yiY12P3Tl3fnzAFS76lcOhT4gS042oI4N8615+0ZFVKuXhEoEEh5Yl uhBMpEaJu2U2BygpgYDFA0hH3tM0wMCravibqb98kQ5MWAWi/EG6vDW6HBGMs1gG+Vnb 7BqvpiJN5s9PZcGFaPeaGpPHj7YT9Tz8VR2V9DMDgKF/JjylJi3vnDak2Wr2cZzuSWfh 1Exw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=syzxvEG3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d26-20020a056402401a00b004812e6f2d97si2681427eda.537.2023.01.10.16.16.14; Tue, 10 Jan 2023 16:16:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=syzxvEG3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232858AbjAJXTY (ORCPT + 53 others); Tue, 10 Jan 2023 18:19:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235154AbjAJXS7 (ORCPT ); Tue, 10 Jan 2023 18:18:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7578E59319 for ; Tue, 10 Jan 2023 15:18:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 13A586190D for ; Tue, 10 Jan 2023 23:18:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42723C433EF; Tue, 10 Jan 2023 23:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1673392722; bh=1FrDLc773XkQj+lO8Vh4muEBRRgPkXtE/hqrdxursgo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=syzxvEG3JVxdj2XSfnkR3ErqWix6EtLHHPHXoEY/wK4F97qafATMOvbdx3Ea0QrRH Lcd0PEYmHht3egw7ziC6S3WNl+V155qeZ898xCYFNWoTt3YcNwdQIDzHp66TEADkpJ 6TmTTfGS24C0FPxVO7hgyADewLZp8f2A86FrpUF8= Date: Tue, 10 Jan 2023 15:18:41 -0800 From: Andrew Morton To: Liam Howlett Cc: SeongJae Park , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "maple-tree@lists.infradead.org" Subject: Re: [PATCH] maple_tree: Fix handle of invalidated state in mas_wr_store_setup() Message-Id: <20230110151841.149f2bd34dcc7ebcdd6bbaad@linux-foundation.org> In-Reply-To: <20230110142109.gphhirh7jo67br6x@revolver> References: <20230109154012.3342cbb91defbc485db641c1@linux-foundation.org> <20230109234317.1408-1-sj@kernel.org> <20230110142109.gphhirh7jo67br6x@revolver> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jan 2023 14:21:15 +0000 Liam Howlett wrote: > * SeongJae Park [230109 18:43]: > > Hi Andrew, > > > > On Mon, 9 Jan 2023 15:40:12 -0800 Andrew Morton wrote: > > > > > On Mon, 9 Jan 2023 19:22:48 +0000 SeongJae Park wrote: > > > > > > > On Mon, 9 Jan 2023 16:55:42 +0000 Liam Howlett wrote: > > > > > > > > > If an invalidated maple state is encountered during write, reset the > > > > > maple state to MAS_START. This will result in a re-walk of the tree to > > > > > the correct location for the write. > > > > > > Can we think of a Fixes: for this? > > It wasn't really an issue until I wrote the vma iterator store > function. > > You can put this before (mm-unstable git id..) > 9df3d25a97ec ("mm: expand vma iterator interface") I have dropped "mm: expand vma iterator interface"'s series. Should we retain this patch as a standalone thing and is the changelog still appropriate?