Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH] riscv: elf: add .riscv.attributes parsing
From:   Jessica Clarke <jrtc27@jrtc27.com>
In-Reply-To: <3e91a775-c671-35e8-0966-3ec9d8999e14@rivosinc.com>
Date:   Wed, 11 Jan 2023 00:29:49 +0000
Cc:     linux-riscv <linux-riscv@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Palmer Dabbelt <palmer@rivosinc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Eric Biederman <ebiederm@xmission.com>,
        Kees Cook <keescook@chromium.org>, Guo Ren <guoren@kernel.org>,
        Greentime Hu <greentime.hu@sifive.com>,
        Conor Dooley <conor.dooley@microchip.com>, linux@rivosinc.com,
        kernel test robot <lkp@intel.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <A2A77A5F-0322-4BFA-A163-33E373C819F7@jrtc27.com>
References: <20230110201841.2069353-1-vineetg@rivosinc.com>
 <01AF458D-1EDC-47D1-A902-A686E2DF26AF@jrtc27.com>
 <6dcdd143-ff1c-41f7-9f46-0c4505575669@rivosinc.com>
 <9061941F-3221-467D-B0FC-DCA8E8FF3996@jrtc27.com>
 <3e91a775-c671-35e8-0966-3ec9d8999e14@rivosinc.com>
To:     Vineet Gupta <vineetg@rivosinc.com>
Precedence: bulk

On 10 Jan 2023, at 23:45, Vineet Gupta <vineetg@rivosinc.com> wrote:
> On 1/10/23 15:21, Jessica Clarke wrote:
>>>> You also should handle more than one sub-subsection even if tools =
don=E2=80=99t
>>>> emit it today.
>>> Just to be on same page, a sub-section implies the following
>>>=20
>>>       uint32:len, NTBS:vendor-name, uint8: Tag_file, =
uint32:data-len, <tag><value>....
>>>=20
>>> If so, the code does support multiple of these
>> That=E2=80=99s a sub-section, but I said sub-subsection.
>=20
> The psABI documentation that we reviewed yesterday only mentions =
Tag_File =3D 1 and doesn't mention the term sub-subsection at all.
> We need to be consistent between code and the new documentation or =
just add reference to ARM documentation which covers everything and =
write the general purpose parser.

Documentation you wrote and hasn=E2=80=99t been approved by anyone else. =
Where
I said that we need to document that multiple sub-subsections are
allowed.

Jess