Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221231142721.338643-1-abel.vesa@linaro.org>
In-Reply-To: <20221231142721.338643-1-abel.vesa@linaro.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Tue, 10 Jan 2023 16:57:55 -0800
Message-ID: <CAD=FV=Xkz4CjF9VpC=H=wOuLNwoDfD1VXLQW2kd-hMb6QV8RcA@mail.gmail.com>
Subject: Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
To:     Abel Vesa <abel.vesa@linaro.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Steev Klimaszewski <steev@kali.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Johan Hovold <johan@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Sat, Dec 31, 2022 at 6:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
>
> The actual name is R133NW4K-R0.
>
> Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")

-:8: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes:
<12 chars of sha1> ("<title line>")' - ie: 'Fixes: 0f9fa5f58c78
("drm/panel-edp: add IVO M133NW4J-R3 panel entry")'
#8:
Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")

Essentially you have one too many hex digits. I'll fix it for you this
time, but please remember for the future.


> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Assuming the information from here is correct:
> https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md

This is nifty--I wasn't aware of this database.


>  drivers/gpu/drm/panel/panel-edp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Fixes: 0f9fa5f58c78 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")

Pushed to drm-misc-next. I didn't bother doing "drm-misc-fixes"
because it didn't seem urgent and it would have caused a merge
conflict with the next patch.

9cce08cadc6c drm/panel-edp: fix name for IVO product id 854b


-Doug