Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     SeongJae Park <sj@kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>
Subject: Re: [PATCH] maple_tree: Fix handle of invalidated state in
 mas_wr_store_setup()
Thread-Topic: [PATCH] maple_tree: Fix handle of invalidated state in
 mas_wr_store_setup()
Thread-Index: AQHZJEs16LTgU8asl06B/cuTn0zvJ66Wdu0AgABH6wCAAADcgIAA9UaAgACWMICAAB54AA==
Date:   Wed, 11 Jan 2023 01:07:47 +0000
Message-ID: <20230111010744.tyzjo7noocm6owko@revolver>
References: <20230109154012.3342cbb91defbc485db641c1@linux-foundation.org>
 <20230109234317.1408-1-sj@kernel.org>
 <20230110142109.gphhirh7jo67br6x@revolver>
 <20230110151841.149f2bd34dcc7ebcdd6bbaad@linux-foundation.org>
In-Reply-To: <20230110151841.149f2bd34dcc7ebcdd6bbaad@linux-foundation.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+wdeJw/i3LaQkF8wDpR21JmsvcvBTh/5V1DBBHsUAsQ1x/jsMtu9qsx1AZ/h?=
 =?us-ascii?Q?rFjb6+Ln59r+MWNQwqwA0qE/vm09B/uZgweFuKruZgHc3wvi+jM2ZZUhh3H/?=
 =?us-ascii?Q?/IgU1QNWDzcEUgLlpxPG9CklsCvkagQ/Vu2ek7ed7eE38zgqpXoxW/r6gq/k?=
 =?us-ascii?Q?dBHmmqYb/yKVrRTaHIKOmE6qCcg9sj8dBMfA6iT1CK1DgqbU4sWEBk6eVVGm?=
 =?us-ascii?Q?UvVmHX/qPONqawVUpa4O4hcfg0BEa9Nf4mr+FFCyDbx7r+SPu/jOd1krIhAq?=
 =?us-ascii?Q?QR/gLoqArC0fL8ckZbgn+2/QcqTCuha6Wak2mDUOhg2Sm1Nejkofg2JZr3kT?=
 =?us-ascii?Q?QcJJCzijhw5wbRLc+0Z+Vppq32aACM0IO8jYY4vZQM5x2WAlEi2mDXyn6DcY?=
 =?us-ascii?Q?eQzVccUXUTN+DA1JodbQIh1Q0wXUs9M4rpxKG53PBI4veSpLnbfGFLDsO1Rl?=
 =?us-ascii?Q?TJMeKYIpuACa6mHb7gi8sOBiIF3RXyMDHUf3XASUeNCQXm7Lb1L53TAsVZDN?=
 =?us-ascii?Q?bB/FSMYREykEXLpA64MBxV/pSG6O5ic8udPWqv6k/6c8xscnQMyc2w4gg2l1?=
 =?us-ascii?Q?gj+3/w1/7gcypw+Q/x0xJkwo06p7DAy0+yIGJVUxkCV+YtKX6aDiPm7tIu+K?=
 =?us-ascii?Q?QFHa55Cf+rUZhtJuz6cLEJLTghAWn1waFLWQhYekMj7nBfEdA5l6rjqc/RXa?=
 =?us-ascii?Q?UcmBIURrQOx3vVCCefG/9J+sYFFyRYT/6QT1uShzW9U7UAEkZKjhJfR0tAHJ?=
 =?us-ascii?Q?DFoD/mMZQEq50hHbhDeS4jLZl5V7cZiHZUtkP/K4II0p+xVVQ+EHTye8kjue?=
 =?us-ascii?Q?yagr4abWEXTHUuI79RP53SvfpZWRijrkLVJtSqaHey0CLWDXu11JEsqdww4N?=
 =?us-ascii?Q?iM7jN/I1TsW9wIfbjh2zlA6XMSUy56SkEx2XjHzWUNZ7Wdlg3sUM+f6v9P9e?=
 =?us-ascii?Q?O6rWWBJzRBG9MxPean3wiZN3Q3aO2fCSIEyilL/i40kvrwFfv55AOe+X+Vhk?=
 =?us-ascii?Q?Di8zV7GVD06ReJUXNbPKoW5If9bPQZhELe4WMssZo+nfkf0gRdJN/ryjPAla?=
 =?us-ascii?Q?zgYLLJtGJkpzcGrgGEtyACEkSWiudsNAsP7Hf7zQvHwg1zCCcy4dEruMBeEU?=
 =?us-ascii?Q?h+fkD4Y6/0nlHiohTIz19Yg1mwpDCWG9DrXqaBVs3eBU8SyjVoJFSs2o4QJs?=
 =?us-ascii?Q?sk8DWcfflMoYzjQ3ucKIZLnSu/jCv5VqaIdXg2O4YQ+7rJB9KadYBWhLq2/z?=
 =?us-ascii?Q?WiNlBeIVsROXPxgs1gaOZtyJZHNh9/hIGBRFc/jOYusLbcFr9RcDMfPO1GET?=
 =?us-ascii?Q?SCAOy8xc2fwqTVPqncG/QVMAaObAv+3hs7/nyyfrnJiJQCREukuVU0VB9LLP?=
 =?us-ascii?Q?Ro7Czdu1Z5LUcT5Ulp5MKSBVQzQR+1LMmLUSgPNklCAstPNIc+RGLoyA2jAZ?=
 =?us-ascii?Q?shpOuL8kT4s5qukhffii+dIDjP4TrbpAnbPtBZ5/ORC3CU0HWo1T7AxBSMoE?=
 =?us-ascii?Q?TzVr70UxSUmlFxHVewmWF8/6B66ywBhbe9EQpp44gRyCZMkYfx1Zcu5PDUZS?=
 =?us-ascii?Q?aGWD9afavhFobLLNn9ueBIeYQWVYjsfueeNwlHc7vCG8BJ0c18Qz0f6+wG1L?=
 =?us-ascii?Q?Qg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B189A25FA25E87459571E0B7397983F2@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: bXu4g2ekAlwWbDJ0bolhdmX8fbtbeOunoSq0cfmi08lNm78yBYS3MRjgVlV3UmngjUtVTH0+JKJhJ8aToTFRge32VZuTlBJho2N1hjyhJaWXM0YmWz5HrPA14MmC7HMhwMdUZFi3d1YJmNmtKsoTcFQrvtAeATQBYu97QhHpuz/K9Hu9sQzPxV9FkHUOc42TC4tfvtP7GJpQZyopEG8VUZ3bJV2kjPpmANQvjRWJ+ghM7+S8aFLzUIZbQCD0gsUcz8xlkBigCk9S1R8uZ9WwqzKO+OuRxMKKpot96EJSqN+uQRaaLqiOTXuMP+3Ms+ZZmKHaIO8nXz/iTFnxHGvBwbrhZrz39GN8O8rgiQjENuUDBwFiBoorS7eJbqZIFzLa9SG7qMc7MqEpflvkcqnQxsElJAGqp4hYprZQLG1/MBahJqlsYI9SGgc0A3+tLQntXnlALESPqqWh0RFOVmZ5R619S16tCuTa0ePcSh1dWxtrJ39dkV9bah+KQ/ilRllvTGQS51LjED0UySpVj0g4mYho2UYX9TGn2/lYZkmyCiSBxDAGYezSnhnFP1iG+XIg5Yc9hmCLEyC1eK7EA7uxHJ6AvrtXeHJgBILshJ1HL9q1Rkw+5WwSvVv272UlYxtMPYqLOU9bSUb0ujXKP8W+BJMKo2MBXyFKndJJrxZuLrAtBA2wQtgPHCGYyHr1Wg/8ukMsc5ToSq89l0WpE+vK4zfsaZrCubZIQ88oEYPX2nzO6fPSU5o6XLVRpfqFhsNgtqbJ/BNCrVu3/ZbiuzALt0FUwCQivziEXmXdf8MUX6icLdlcdR7k8muPuUnX2tZEwkwEJ7Y8bXsGUwkman/jWzg83RIHvgWu7ZL04GderB87KvBtwAiW9TeGjvxF5tghaC/qsgQ0b5qWQVmkw5T303bnO4o4Gb2DbgHwqARQ5uQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ba1d42e-b55d-46ca-9598-08daf37040b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 01:07:47.3784
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KZbJZ4T09kC9w7zssbjdVZ6/8VkHhHkt0+YLE34AKNzQDWL7s1AmrzOgP9a3F0Dcnpj9fSMgnTZh2CSLvOJPhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR10MB6005
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-10_10,2023-01-10_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=742
 malwarescore=0 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301110005
X-Proofpoint-GUID: XI8N18E6WYfauUlfQfUC6Qo5aNx0jVM6
X-Proofpoint-ORIG-GUID: XI8N18E6WYfauUlfQfUC6Qo5aNx0jVM6
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Andrew Morton <akpm@linux-foundation.org> [230110 18:18]:
> On Tue, 10 Jan 2023 14:21:15 +0000 Liam Howlett <liam.howlett@oracle.com>=
 wrote:
>=20
> > * SeongJae Park <sj@kernel.org> [230109 18:43]:
> > > Hi Andrew,
> > >=20
> > > On Mon, 9 Jan 2023 15:40:12 -0800 Andrew Morton <akpm@linux-foundatio=
n.org> wrote:
> > >=20
> > > > On Mon,  9 Jan 2023 19:22:48 +0000 SeongJae Park <sj@kernel.org> wr=
ote:
> > > >=20
> > > > > On Mon, 9 Jan 2023 16:55:42 +0000 Liam Howlett <liam.howlett@orac=
le.com> wrote:
> > > > >=20
> > > > > > If an invalidated maple state is encountered during write, rese=
t the
> > > > > > maple state to MAS_START.  This will result in a re-walk of the=
 tree to
> > > > > > the correct location for the write.
> > > >=20
> > > > Can we think of a Fixes: for this?
> >=20
> > It wasn't really an issue until I wrote the vma iterator store
> > function.
> >=20
> > You can put this before (mm-unstable git id..)
> > 9df3d25a97ec ("mm: expand vma iterator interface")
>=20
> I have dropped "mm: expand vma iterator interface"'s series.  Should we
> retain this patch as a standalone thing and is the changelog still
> appropriate?

No, just drop it and I'll re-spin v3 to include maple tree fixes on the
top.