Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 Jan 2023 18:13:14 -0800
From:   Benson Leung <bleung@google.com>
To:     Prashant Malani <pmalani@chromium.org>
Cc:     linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        bleung@chromium.org,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Guillaume Ranquet <granquet@baylibre.com>,
        Macpaul Lin <macpaul.lin@mediatek.com>,
        Pablo Sun <pablo.sun@mediatek.com>
Subject: Re: [PATCH 3/3] usb: typec: altmodes/displayport: Use proper macro
 for pin assignment check
Message-ID: <Y74bOlZC7VezQPl/@google.com>
References: <20230111020546.3384569-1-pmalani@chromium.org>
 <20230111020546.3384569-3-pmalani@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2fVYJqbuNhrzGG0D"
Content-Disposition: inline
In-Reply-To: <20230111020546.3384569-3-pmalani@chromium.org>
Precedence: bulk


--2fVYJqbuNhrzGG0D
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 11, 2023 at 02:05:43AM +0000, Prashant Malani wrote:
> While looking at the DP configuration VDO to determine the peripheral
> configuration, the spec (Table 8-5: DisplayPort Configurations, VESA
> DisplayPort Alt Mode Standard v2.0) lists the options as "UFP_U as a DP
> Source/Sink Device".
>=20
> So, use the correct macro while performing this check. Effectively it's
> the same as the existing code, but the proposed macro describes the
> state a little better.
>=20
> No functional changes introduced.
>=20
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>

Reviewed-by: Benson Leung <bleung@chromium.org>


> ---
>  drivers/usb/typec/altmodes/displayport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec=
/altmodes/displayport.c
> index c0d65c93cefe..746bfbf3d557 100644
> --- a/drivers/usb/typec/altmodes/displayport.c
> +++ b/drivers/usb/typec/altmodes/displayport.c
> @@ -426,7 +426,7 @@ static const char * const pin_assignments[] =3D {
>   */
>  static u8 get_current_pin_assignments(struct dp_altmode *dp)
>  {
> -	if (DP_CONF_CURRENTLY(dp->data.conf) =3D=3D DP_CONF_DFP_D)
> +	if (DP_CONF_CURRENTLY(dp->data.conf) =3D=3D DP_CONF_UFP_U_AS_DFP_D)
>  		return DP_CAP_PIN_ASSIGN_DFP_D(dp->alt->vdo);
>  	else
>  		return DP_CAP_PIN_ASSIGN_UFP_D(dp->alt->vdo);
> --=20
> 2.39.0.314.g84b9a713c41-goog
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--2fVYJqbuNhrzGG0D
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCY74bOgAKCRBzbaomhzOw
wowAAQDFTes+DZuv7868tAyRpVpR36P6n2H9MOeH+OqxPzCE5AD+MLsdcrYXjV24
gBXEi0yxLR33Mnnu3CMlN30COjy7IAo=
=0CVW
-----END PGP SIGNATURE-----

--2fVYJqbuNhrzGG0D--