Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8763482rwl; Tue, 10 Jan 2023 19:08:19 -0800 (PST) X-Google-Smtp-Source: AMrXdXtfdj1it2uqCNh2IH/1KkB1SIwsHMDeanYYYdQo49nrhKhyE0EsvHcEEpgOKuGmrxyV7lY7 X-Received: by 2002:aa7:cd49:0:b0:497:d8ea:d79c with SMTP id v9-20020aa7cd49000000b00497d8ead79cmr14011358edw.27.1673406498954; Tue, 10 Jan 2023 19:08:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673406498; cv=none; d=google.com; s=arc-20160816; b=RDK9tCctr9n5jkeCtG5H4Hnb+GyMj1QKzCWx1799KnI4SykIfpGXiyY9jnTQHwQB1y 50sCAwc/NO1OsRuIWgSkpILsgWmS57Br/TSh9XN60OK1vfl6yr8cB+yo60C8SlqJXHGL FYI0y6aCun2OfE1P3u/jyEcejfQvhnqXPGyAh4OK42xTRaQgXwdT6ei7fgatBVlsHPAL fGTMMCwqu6e3nY4Egd9tUraymppoa4jZiHa/zwhUaMk58AQYaP7QLzCjpoGdsZrQxedb vh6FLe7u6/lMBES9xFHmEERSrrRrS0gkorNjfT46sbABtrIZTJctbQcxh4P0OG4vCToo LGsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Dbgnw9qv0Z/GlLx6gLxjlhhsxXm01uR1J4XYaBl3C28=; b=RLsZAxn2aC3l8VxkMopzMXMq9lrTahYEwVp5zfG1K8Wnx+olSnM5ZVkUTmqFE444s/ yp+p4x1T/547z9oadm1e7FcdvHd5eyOrSg5+L3Q+2zKgOnyzHfoSWsp/ajSu3eYs9Yf7 5CfxRJ2ZUuJqhKCDgVwSBktmPBb7tbMmzsyYQQGuiEeei+SOuwYRo4DX59tU5f52+esv rfk0GyQhYs574u6Ej/04Kf8fNZ45Fj0Lvztfllr9x9wXKy5z0g3IM4vjaj5KA3jWU+Rd VhZXFUaqj2rizXps3r0Eb8uMyiJ4ttbR/fUP/QQIWv3SycoC2naxej2FQXQeX0mIwBe3 gg4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mint.lgbt header.s=dkim header.b=l2rt7HZQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b16-20020a056402279000b004619867344csi15580661ede.0.2023.01.10.19.08.06; Tue, 10 Jan 2023 19:08:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mint.lgbt header.s=dkim header.b=l2rt7HZQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233179AbjAKCxz (ORCPT + 53 others); Tue, 10 Jan 2023 21:53:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbjAKCxx (ORCPT ); Tue, 10 Jan 2023 21:53:53 -0500 Received: from amity.mint.lgbt (vmi888983.contaboserver.net [149.102.157.145]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E862165A2 for ; Tue, 10 Jan 2023 18:53:50 -0800 (PST) Received: from amity.mint.lgbt (mx.mint.lgbt [127.0.0.1]) by amity.mint.lgbt (Postfix) with ESMTP id 4NsC1T2kmpz1S5Fc for ; Tue, 10 Jan 2023 21:53:49 -0500 (EST) Authentication-Results: amity.mint.lgbt (amavisd-new); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=mint.lgbt DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mint.lgbt; h= content-transfer-encoding:content-type:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version :date:message-id; s=dkim; t=1673405628; x=1674269629; bh=8i4jmOu APCAp11p4DZJjHBlsAcEc2Uu0uW9fgZ3zFUU=; b=l2rt7HZQe1rwy8LwQ+mvR9s ghIi4RanvHXb5D/8oOnFQXPnDLRd5Eni5PfUYb2Yo0Ri2cmtTDD6WZ0b5jhqBSAJ 5XzksWHGpEQrFkqNYAM/6XDHiQ/TypWOJZ2g5MxKLZQelFOPHKKdjvlsw8rH0r0a R+XSjrRYCBDSMeKihasqs0QTs5XmOlU+KKtSThmmwyZwJU8i3ZCplxt7AmQt7++5 RV5Qn/AYGO2SpmPoniBX2GI5sjHsLeaFW13aZsxWggn6dSnICqgEgjrdO77I7N1U 8D1Sg7XrfmSIVm3g74a/niYgEW1NlGtTwsZ5J5rtk017cJ70UN7qM8JQFZ7FoAA= = X-Virus-Scanned: amavisd-new at amity.mint.lgbt Received: from amity.mint.lgbt ([127.0.0.1]) by amity.mint.lgbt (amity.mint.lgbt [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uceZx2c1D5w2 for ; Tue, 10 Jan 2023 21:53:48 -0500 (EST) Received: from [192.168.4.25] (unknown [190.196.92.66]) by amity.mint.lgbt (Postfix) with ESMTPSA id 4NsC1B5blwz1S4tq; Tue, 10 Jan 2023 21:53:34 -0500 (EST) Message-ID: Date: Tue, 10 Jan 2023 23:53:31 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v6 4/6] arm64: dts: qcom: sm6125: Add UFS nodes Content-Language: en-US To: Konrad Dybcio , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, kishon@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com Cc: ~postmarketos/upstreaming@lists.sr.ht, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, martin.botka@somainline.org, marijn.suijten@somainline.org References: <20230108195336.388349-1-they@mint.lgbt> <20230108195336.388349-5-they@mint.lgbt> <475d3f2f-114f-d6d2-89db-465ba7acd0d6@linaro.org> From: Lux Aliaga In-Reply-To: <475d3f2f-114f-d6d2-89db-465ba7acd0d6@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2023 09:18, Konrad Dybcio wrote: > > On 8.01.2023 20:53, Lux Aliaga wrote: >> Adds a UFS host controller node and its corresponding PHY to >> the sm6125 platform. >> >> Signed-off-by: Lux Aliaga >> --- >> arch/arm64/boot/dts/qcom/sm6125.dtsi | 57 ++++++++++++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi >> index df5453fcf2b9..cec7071d5279 100644 >> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi >> @@ -511,6 +511,63 @@ sdhc_2: mmc@4784000 { >> status = "disabled"; >> }; >> >> + ufs_mem_hc: ufs@4804000 { >> + compatible = "qcom,sm6125-ufshc", "qcom,ufshc", "jedec,ufs-2.0"; >> + reg = <0x04804000 0x3000>, <0x04810000 0x8000>; > You need reg-names for ICE to probe, otherwise the second reg sits unused. > >> + interrupts = ; >> + phys = <&ufs_mem_phy>; >> + phy-names = "ufsphy"; >> + lanes-per-direction = <1>; >> + #reset-cells = <1>; >> + resets = <&gcc GCC_UFS_PHY_BCR>; >> + reset-names = "rst"; >> + iommus = <&apps_smmu 0x200 0x0>; >> + >> + clock-names = "core_clk", >> + "bus_aggr_clk", >> + "iface_clk", >> + "core_clk_unipro", >> + "ref_clk", >> + "tx_lane0_sync_clk", >> + "rx_lane0_sync_clk", >> + "ice_core_clk"; >> + clocks = <&gcc GCC_UFS_PHY_AXI_CLK>, >> + <&gcc GCC_SYS_NOC_UFS_PHY_AXI_CLK>, >> + <&gcc GCC_UFS_PHY_AHB_CLK>, >> + <&gcc GCC_UFS_PHY_UNIPRO_CORE_CLK>, >> + <&rpmcc RPM_SMD_XO_CLK_SRC>, >> + <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>, >> + <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>, >> + <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; >> + freq-table-hz = <50000000 240000000>, >> + <0 0>, >> + <0 0>, >> + <37500000 150000000>, >> + <0 0>, >> + <0 0>, >> + <0 0>, >> + <75000000 300000000>; >> + >> + status = "disabled"; >> + }; >> + >> + ufs_mem_phy: phy@4807000 { >> + compatible = "qcom,sm6125-qmp-ufs-phy"; >> + reg = <0x04807000 0x1c4>; > Isn't this too small? Downstream says 0xdb8, but it's probably even bigger.. What do you think could help me find the new length of the registers? I tried 0x1000 and it probed just fine, but I'm not really sure until what extent I could push it. -- Lux Aliaga https://nixgoat.me/