Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <db4276db-bbec-142a-d306-928421eb49fc@roeck-us.net>
Date:   Tue, 10 Jan 2023 19:29:20 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 1/1] hwmon: remove unnecessary (void*) conversions
Content-Language: en-US
To:     XU pengfei <xupengfei@nfschina.com>, jdelvare@suse.com
Cc:     linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230111020723.3194-1-xupengfei@nfschina.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20230111020723.3194-1-xupengfei@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/10/23 18:07, XU pengfei wrote:
> Pointer variables of void * type do not require type cast.
> 

One patch per driver, and include the driver name (ibmpex, powr1220)
in the subject.

Guenter

> Signed-off-by: XU pengfei <xupengfei@nfschina.com>
> ---
>   drivers/hwmon/ibmpex.c   | 2 +-
>   drivers/hwmon/powr1220.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index 1837cccd993c..db066b368918 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -546,7 +546,7 @@ static void ibmpex_bmc_gone(int iface)
>   
>   static void ibmpex_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data)
>   {
> -	struct ibmpex_bmc_data *data = (struct ibmpex_bmc_data *)user_msg_data;
> +	struct ibmpex_bmc_data *data = user_msg_data;
>   
>   	if (msg->msgid != data->tx_msgid) {
>   		dev_err(data->bmc_device,
> diff --git a/drivers/hwmon/powr1220.c b/drivers/hwmon/powr1220.c
> index f77dc6db31ac..501337ee5aa3 100644
> --- a/drivers/hwmon/powr1220.c
> +++ b/drivers/hwmon/powr1220.c
> @@ -174,7 +174,7 @@ static umode_t
>   powr1220_is_visible(const void *data, enum hwmon_sensor_types type, u32
>   		    attr, int channel)
>   {
> -	struct powr1220_data *chip_data = (struct powr1220_data *)data;
> +	struct powr1220_data *chip_data = data;
>   
>   	if (channel >= chip_data->max_channels)
>   		return 0;