Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8822989rwl; Tue, 10 Jan 2023 20:17:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXswny9CA6k4lg/YvSGilAXQBLeS0EqFMgdyVcRoyKC56F4nY/BED6RL0MvKjFFvegbUGQi8 X-Received: by 2002:a17:906:b041:b0:7c0:c5b3:cb49 with SMTP id bj1-20020a170906b04100b007c0c5b3cb49mr61675451ejb.31.1673410625150; Tue, 10 Jan 2023 20:17:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673410625; cv=none; d=google.com; s=arc-20160816; b=TGVHV6H9dJ2QKlW8YtKJoKS5FTQGKJrjLvWvFb+kgyE9LEpG4V9Vjl/OScP28RuaiF 1MSP1xSbfRa1+OEgeZcH716w1cwzEAkjxlk5a+Dg6N67+gw6+tS6Bd544s3+DSccyUWG oeBZhbQvETvGYrh0mXzx8eZU96eSkrA+KllOab/jaY9swsK+1WWwlFv8p2QzKpLwYDM2 SFCrgKb/UL4nvrCjwZwUmlpg7zDKqtvo7accrPudEA28UtwXAVGVMmNbH3/i1nyJv2aG 8dULksbvjTYBj8O21N+PcjMTKHQsrox1qAP4dSNHu7V/ouXXkuULwQ936PyppKp53+bF 0mxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=idbF1CtURypA8wpbO/rYe2ZrEBUBsALsIfTFTeVbM2U=; b=UVUIwZCLqlRJVlJnow8nEFGxcNsY44P4QnqQohW5+vL/XPp5GxoTtVDI2UBh0KTg1j vbPn6I49vTJGl2BbQ9PjwxIlG773bK9Xp2OyLl4ncxuswR5Me62U8Yi7Ds1fPuuxbJgJ 8U6lT2POnbuGbBidR4i8popF90qBQWvT/pvSXJ/JtCd++vQXAq1jPa4aSzT4spGk6qrA 7a8l8vtWx77AyAgYiSNEz2XGkAfX97C3SC79lQYxr9h5caApvTn6fzzTtHh3BYp3e/PQ T6CNxkPito6mZw7W3NXdOCnRV5vSdhfp8ONcP4a18amlUWVG521hARIkzcI5Kac/4cf9 /3lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=adJ2g5KX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fy15-20020a1709069f0f00b007c0870b3739si9950210ejc.938.2023.01.10.20.16.52; Tue, 10 Jan 2023 20:17:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=adJ2g5KX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231429AbjAKD5s (ORCPT + 53 others); Tue, 10 Jan 2023 22:57:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbjAKD5q (ORCPT ); Tue, 10 Jan 2023 22:57:46 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B127120A1 for ; Tue, 10 Jan 2023 19:57:45 -0800 (PST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30B1io9h010091; Wed, 11 Jan 2023 03:57:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=idbF1CtURypA8wpbO/rYe2ZrEBUBsALsIfTFTeVbM2U=; b=adJ2g5KXsFFhQo3/i/HS68oEWDYNlgoaM+7y/ZipWoTOyPgjGpcVsNlOTRM6krWXYI95 P35sBiwDs5mw2OpXk6yVKFIsEuRzgs/MwNczZnK35XTlCRUkBbybNHAxjg/xXGMqyeWM 2VsnYrm8hJDAG/8WRUnUmGvm8oTqbVy4OZDMR0tt5kYNQZ5L3jOhbAwAEtAgX+rKmxiB +/IB3HYaDJp/YWCIm4vV/p2nK8yl0QTiWJuVjZrAZf8+CNOSBDhAZ7g2nC4P/tlg0kjI uhcQT/o4skFXB5qmv/Q/U4FSsc+Ta8JlPE3wh/d4hCi9MPUMfPbACC084cT5iiVvZODe ZQ== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n1kqma1yr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jan 2023 03:57:32 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30B1RMfX030858; Wed, 11 Jan 2023 03:57:29 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3n1kf7g54n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jan 2023 03:57:29 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30B3vR8T47055232 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Jan 2023 03:57:27 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2D19220049; Wed, 11 Jan 2023 03:57:27 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1E7E20040; Wed, 11 Jan 2023 03:57:26 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 11 Jan 2023 03:57:26 +0000 (GMT) Received: from [10.61.2.128] (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 06FF0600D2; Wed, 11 Jan 2023 14:57:23 +1100 (AEDT) Message-ID: Subject: Re: [PATCH v2 7/7] powerpc/pseries: Implement secvars for dynamic secure boot From: Andrew Donnellan To: Michael Ellerman , Russell Currey , linuxppc-dev@lists.ozlabs.org Cc: gregkh@linuxfoundation.org, gcwilson@linux.ibm.com, linux-kernel@vger.kernel.org, nayna@linux.ibm.com, zohar@linux.ibm.com Date: Wed, 11 Jan 2023 14:57:22 +1100 In-Reply-To: <87zgawgcpa.fsf@mpe.ellerman.id.au> References: <20221230042014.154483-1-ruscur@russell.cc> <20221230042014.154483-8-ruscur@russell.cc> <87zgawgcpa.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: my4_Recuo3xIFCqlqFviuBT4xa2dVIcE X-Proofpoint-GUID: my4_Recuo3xIFCqlqFviuBT4xa2dVIcE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-10_10,2023-01-10_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=534 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 bulkscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301110025 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2023-01-06 at 21:49 +1100, Michael Ellerman wrote: >=20 > > diff --git a/arch/powerpc/platforms/pseries/Kconfig > > b/arch/powerpc/platforms/pseries/Kconfig > > index a3b4d99567cb..94e08c405d50 100644 > > --- a/arch/powerpc/platforms/pseries/Kconfig > > +++ b/arch/powerpc/platforms/pseries/Kconfig > > @@ -162,6 +162,19 @@ config PSERIES_PLPKS > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 If unsure, selec= t N. > > =C2=A0 > > +config PSERIES_PLPKS_SECVAR > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0depends on PSERIES_PLPKS > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0depends on PPC_SECURE_BOOT > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0bool "Support for the PLPKS = secvar interface" > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0help > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PowerVM can support d= ynamic secure boot with user-defined > > keys > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 through the PLPKS. Ke= ystore objects used in dynamic > > secure boot > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 can be exposed to the= kernel and userspace through the > > powerpc > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 secvar infrastructure= . Select this to enable the PLPKS > > backend > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for secvars for use i= n pseries dynamic secure boot. > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 If unsure, select N. >=20 > I don't think we need that config option at all, or if we do it > should > not be user selectable and just enabled automatically by > PSERIES_PLPKS. I actually think we should get rid of both PSERIES_PLPKS_SECVAR and PSERIES_PLPKS, and just use PPC_SECURE_BOOT / PPC_SECVAR_SYSFS. --=20 Andrew Donnellan OzLabs, ADL Canberra ajd@linux.ibm.com IBM Australia Limited