Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: initialize the buf variable
From:   patchwork-bot+chrome-platform@kernel.org
Message-Id: <167340782388.3713.8161675582261475081.git-patchwork-notify@kernel.org>
Date:   Wed, 11 Jan 2023 03:30:23 +0000
References: <20230110193611.3573777-1-trix@redhat.com>
In-Reply-To: <20230110193611.3573777-1-trix@redhat.com>
To:     Tom Rix <trix@redhat.com>
Cc:     bleung@chromium.org, groeck@chromium.org, nathan@kernel.org,
        ndesaulniers@google.com, chrome-platform@lists.linux.dev,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Precedence: bulk

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Tue, 10 Jan 2023 14:36:11 -0500 you wrote:
> Clang static analysis reports this problem
> drivers/platform/chrome/cros_ec_lpc.c:379:13: warning: The left operand
>   of '!=' is a garbage value [core.UndefinedBinaryOperatorResult]
>     if (buf[0] != 'E' || buf[1] != 'C') {
>          ~~~~~~ ^
> 
> The check depends on the side effect of the read.  When the read fails
> or is short, a buf containing garbage could be mistaken as correct.
> 
> [...]

Here is the summary with links:
  - platform/chrome: cros_ec_lpc: initialize the buf variable
    https://git.kernel.org/chrome-platform/c/2ae3c610e7d2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html