Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8833901rwl; Tue, 10 Jan 2023 20:30:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXsFT2QvmCU8xXXNurKMVzX/8yyd88wduZNmJAu4TJcJ68apo8B/7aUtacSZ1jaWwIrlMXEC X-Received: by 2002:a17:907:d389:b0:7c1:5a37:825 with SMTP id vh9-20020a170907d38900b007c15a370825mr77353679ejc.34.1673411422116; Tue, 10 Jan 2023 20:30:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673411422; cv=none; d=google.com; s=arc-20160816; b=A1Hm2KHJIYfKndMRMUafpEuqTXGtBYNw+Bk21v4g3GjbZUAEdDR30m3t5lrkT5XqQB P6/W1P7qJ8fhf/9dxp2niFHgGZuWVegusF/KyLtqBTwQOL2pQxwH3IrEghPw1HNFVyO2 X/8O690BqixCZxxoNU+hD6BwK2Gp59YQniCAYnb2qhUUbTWDq/yWoMPFIkFegPQmtRTV ALN7rYiLhXDqhSp48urDbLmH7adNISbcmQH4RQBFgb4/IDj0Qf0B+PjszgktiumU8xIy rbolsawhSJEwLq7Gcv869SPmKo0LmZnMPig1SZcCi4uCyiNNO3GuIUPEGMeSEpcXTNvD Dd0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=EqaNun93LDJeh/lq8NcPCbezbWzPyh1zvXuHAbLGpYA=; b=gmQNAcKWeGMq0BHlJaziN6VkUgVbYCrFkTQSFsqmOiRWhe8KKDYpn1t+Kp+tmv3Hj1 Aqt7bNv2ofOUD5KJ0kksJfKzWJQCdc0Cygd78+d7B6svF2m7BC2paH1L3EUcbEvvesaA V/Gaf8aSoeHw4kP4TjdrcOjMNAr5Uen0DUYon3V+aPfY920WzJ0v5PfELoc7sBL5o9Eu ZIG+cxf/LNKyC8q40GeuLvWzdJBcxXOu6ybG4Txb6j9GO8bGdOSJ2VnTNKV2wJtdaXhc Y9HOs1qK3dls+VhDE9yeRR59O/gBuEGzmhTdEjx/D7hhnwdseIdKG0LvD9fSRW8T/RX7 Xeyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id be13-20020a1709070a4d00b0084ca4bdbc7asi13302437ejc.780.2023.01.10.20.30.09; Tue, 10 Jan 2023 20:30:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231978AbjAKEER (ORCPT + 55 others); Tue, 10 Jan 2023 23:04:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbjAKEEA (ORCPT ); Tue, 10 Jan 2023 23:04:00 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4594BE1 for ; Tue, 10 Jan 2023 20:03:57 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4NsDZG42yGz4f3ydT for ; Wed, 11 Jan 2023 12:03:50 +0800 (CST) Received: from [10.174.176.117] (unknown [10.174.176.117]) by APP2 (Coremail) with SMTP id Syh0CgCHeugkNb5jzwboBQ--.7168S2; Wed, 11 Jan 2023 12:03:51 +0800 (CST) Subject: Re: [PATCH v2 0/2] Fixes for fscache volume operations To: linux-cachefs@redhat.com Cc: David Howells , Jeff Layton , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jingbo Xu , "houtao1@huawei.com" References: <20221226103309.953112-1-houtao@huaweicloud.com> From: Hou Tao Message-ID: <57afbcf7-df1f-47b8-2b81-8fca87487f57@huaweicloud.com> Date: Wed, 11 Jan 2023 12:03:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221226103309.953112-1-houtao@huaweicloud.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: Syh0CgCHeugkNb5jzwboBQ--.7168S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Gr15Wr1xCFWktFyxXF18Zrb_yoWDKFg_u3 4xKas8uw40qayDKayYkFnIqrs3uw4jga18JFyDtr17G34F9rn09F1kKrySyF1Igay7ZF45 Cr1kKFZYqr129jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbzAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04 k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY 1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUrR6zUUUUU X-CM-SenderInfo: xkrx3t3r6k3tpzhluzxrxghudrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping ? On 12/26/2022 6:33 PM, Hou Tao wrote: > From: Hou Tao > > Hi, > > The patchset includes two fixes for fscache volume operations: patch 1 > fixes the hang problem during volume acquisition when the volume > acquisition process waits for the freeing of relinquished volume, patch > 2 adds the missing memory barrier in fscache_create_volume_work() and it > is spotted through code review when checking whether or not these is > missing smp_mb() before invoking wake_up_bit(). > > Comments are always welcome. > > Chang Log: > v2: > * rebased on v6.1-rc1 > * Patch 1: use wait_on_bit() instead (Suggested by David) > * Patch 2: add the missing smp_mb() in fscache_create_volume_work() > > v1: https://listman.redhat.com/archives/linux-cachefs/2022-December/007384.html > > Hou Tao (2): > fscache: Use wait_on_bit() to wait for the freeing of relinquished > volume > fscache: Add the missing smp_mb__after_atomic() before wake_up_bit() > > fs/fscache/volume.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) >