Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8898889rwl; Tue, 10 Jan 2023 21:43:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXt6Vzrf/+H02BWUTtN6eRgwf0BojH1Qr6aB7hjfMFPFCrmDA0qE19LWojiEnpeUtOguaTDA X-Received: by 2002:a05:6402:22bb:b0:48f:a9a2:29f1 with SMTP id cx27-20020a05640222bb00b0048fa9a229f1mr19241320edb.2.1673415838305; Tue, 10 Jan 2023 21:43:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673415838; cv=none; d=google.com; s=arc-20160816; b=sFfpk8g2hvJ6IpXkGUHvHSqm8k/7/bkIHoYBUvMD9lxJc3pox8ISTMnV8mjPYa9pSQ 7x6A2ov588eE22NXiF9Fjauvjwcd6B82ZztB9M3jk6qnRCpi2Yzc6AKA+jYIYyCnXBHT /XKNU7jXeMERDwVN7smZ7/3xZITLdGVc05oSu83QOlzPCUq7OaThazxvkwiS034GU7c/ k074rp5ItEWaDqkeDw/jw55WHdMMomIZZZhhoOH4Ba7n0fvSymE7xW0SWomY7d3T68D2 hvGGVrsAvRnFpTyqIcw4z1ELphrXnoh8to4Qq24yRmRE5K68WrXjdSA1H51g8LkqRYib FctQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ULg9SvtT7zvvGLJRLCcrq1ZECBTYrSzxfFukKxEEjyI=; b=R59pMh5jib5ZvLqdmlIZV/XJINMTX7UzW4LJcN3rtbyYU6Z7+h60vXQohHhpMCuwiy gNnfNaKvGuAVBg/dd3y4N7QhJxTirPWw5PtEqItefkYI6N3NDnyXQ2f0QJWRyoJ7CBry 5GgQdZxObvwkdvwykHe3o0suXsja+QlEOIPGxBqNiEVcmUQIKsdB5NjSYTa/+nBESu4P L3H+XE8iQiqOBMCnPdnp00qbV7Yf1DS0Mm645kWgDrBZETEJlmewAKtOetxN6z4hH9hy v0MstLYAaAYczDuHh/biHr+Iv93nOqejK1qKp9gFK9IW8vd90nw7Al/P1pRq2+9wYdb2 H/7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bd8-20020a056402206800b0047aaa487720si12551125edb.275.2023.01.10.21.43.45; Tue, 10 Jan 2023 21:43:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229462AbjAKF0R (ORCPT + 53 others); Wed, 11 Jan 2023 00:26:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235391AbjAKFZM (ORCPT ); Wed, 11 Jan 2023 00:25:12 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 148D913D59; Tue, 10 Jan 2023 21:19:17 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 7787768BEB; Wed, 11 Jan 2023 06:19:14 +0100 (CET) Date: Wed, 11 Jan 2023 06:19:14 +0100 From: Christoph Hellwig To: Kemeng Shi Cc: hch@lst.de, axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, john.garry@huawei.com, jack@suse.cz Subject: Re: [PATCH v3 09/14] blk-mq: use blk_mq_commit_rqs helper in blk_mq_try_issue_list_directly Message-ID: <20230111051914.GB16576@lst.de> References: <20230111130159.3741753-1-shikemeng@huaweicloud.com> <20230111130159.3741753-10-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230111130159.3741753-10-shikemeng@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2023 at 09:01:54PM +0800, Kemeng Shi wrote: > + blk_status_t ret; Same here, I think ret needs to be initialized now.