Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dada9a9c-32fd-9d8c-b692-5efb8a94c20f@gnuweeb.org>
Date:   Wed, 11 Jan 2023 13:09:35 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 1/1] hwmon: remove unnecessary (void*) conversions
Content-Language: en-US
From:   Ammar Faizi <ammarfaizi2@gnuweeb.org>
To:     XU pengfei <xupengfei@nfschina.com>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
References: <20230111020723.3194-1-xupengfei@nfschina.com>
 <db4276db-bbec-142a-d306-928421eb49fc@roeck-us.net>
 <423fcac8-97cc-88b7-19d8-f93baddea3cd@gnuweeb.org>
In-Reply-To: <423fcac8-97cc-88b7-19d8-f93baddea3cd@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/11/23 1:03 PM, Ammar Faizi wrote:
> On 1/11/23 10:29 AM, Guenter Roeck wrote:
>> On 1/10/23 18:07, XU pengfei wrote:
>>> diff --git a/drivers/hwmon/powr1220.c b/drivers/hwmon/powr1220.c
>>> index f77dc6db31ac..501337ee5aa3 100644
>>> --- a/drivers/hwmon/powr1220.c
>>> +++ b/drivers/hwmon/powr1220.c
>>> @@ -174,7 +174,7 @@ static umode_t
>>>   powr1220_is_visible(const void *data, enum hwmon_sensor_types type, u32
>>>               attr, int channel)
>>>   {
>>> -    struct powr1220_data *chip_data = (struct powr1220_data *)data;
>>> +    struct powr1220_data *chip_data = data;
> 
> This is wrong. That cast is needed to discard the "const".
> 
>    CC [M]  drivers/hwmon/powr1220.o
> drivers/hwmon/powr1220.c: In function ‘powr1220_is_visible’:
> drivers/hwmon/powr1220.c:177:43: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>    177 |         struct powr1220_data *chip_data = data;
>        |                                           ^~~~
> cc1: all warnings being treated as errors

Anyway, powr1220_is_visible() doesn't write via that pointer, but
the local variable needs to be a const as well.

diff --git a/drivers/hwmon/powr1220.c b/drivers/hwmon/powr1220.c
index f77dc6db31ac..7cbbed5a6f5e 100644
--- a/drivers/hwmon/powr1220.c
+++ b/drivers/hwmon/powr1220.c
@@ -174,7 +174,7 @@ static umode_t
  powr1220_is_visible(const void *data, enum hwmon_sensor_types type, u32
                     attr, int channel)
  {
-       struct powr1220_data *chip_data = (struct powr1220_data *)data;
+       const struct powr1220_data *chip_data = data;
  
         if (channel >= chip_data->max_channels)
                 return 0;


-- 
Ammar Faizi