Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8934052rwl; Tue, 10 Jan 2023 22:21:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXvdxqkIOgNtDp8P500Da0iMwPJetOfvEiUWw16o2dSps0ai6aTZ1gOhJtNeHzdkBnGGrazG X-Received: by 2002:a17:906:819:b0:7ad:e67d:f15c with SMTP id e25-20020a170906081900b007ade67df15cmr67850286ejd.48.1673418088088; Tue, 10 Jan 2023 22:21:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673418088; cv=none; d=google.com; s=arc-20160816; b=C6Oy4Zpjy4sYBFsWRSrik9kWjxTOM/x7B3uv3jch+6qsw77hPVxxd6HmlLMtIxkv8q 46+Tqr8NiJzQ91vwxWgcT+RY/8nW+MDREOIjKpq1AzC2/uRO0p34n160sIL2HBRu9G4r +cl0a5k9mv18e9ESpID2Hi0bHF9CyF71nVKUKHsP363pgHZIZN0qdOMXKG1RXpgyabFm sRTOjkjLt1dh4kTz3dej0OsA3s26klOTe2gmMt4Pu5pphLHnihaSrvCq7PMZDMCByJI4 gOtpjSXQzk38mICuFBxtSHXe90OIchToWCvyfeMNNPKzknuY1RPLXKTFoyNQUKX9GfT1 /FMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ohrTgIZKF4wnt2Gip9NLiR8m43VbyNvxeiAuK59oYbY=; b=1DOYo00e7Nl1gkdUukVNNMVB7sOxqzBIQj5SlvNIAc/bwK8xW32kjx0TXdVEknsUpX y2Rx597OpGkBjzHohvaasxInvISqz6tuWAn3Hp4FOh/VfTCKzTDh+bpmFhxRMuDTtljL FauRSvTfvB6AfByMw753l07oDv8+gtYCtLs7yq+E2UuzaV3JgkDq6M3R1A9+I+TyktZ7 +z29pEelYan5xOHiwXvcwuIN8q1dF8tZ6ptTBJshVe5ky8XyhVNyfinb0QwiwcL3KE+t Ze5tAD1O2FzSV2s6Od9OOxPlIFlt8u/4CmK9M88ePRB+RBdc8M3Vz+SqcYxVxpB6pqzC uW7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gt33-20020a1709072da100b007f20a95eae0si15766803ejc.262.2023.01.10.22.21.15; Tue, 10 Jan 2023 22:21:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbjAKFp4 (ORCPT + 53 others); Wed, 11 Jan 2023 00:45:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbjAKFpu (ORCPT ); Wed, 11 Jan 2023 00:45:50 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5792A127; Tue, 10 Jan 2023 21:45:49 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id C335068BFE; Wed, 11 Jan 2023 06:45:45 +0100 (CET) Date: Wed, 11 Jan 2023 06:45:45 +0100 From: Christoph Hellwig To: Kemeng Shi Cc: hch@lst.de, axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, john.garry@huawei.com, jack@suse.cz Subject: Re: [PATCH v3 10/14] blk-mq: simplify flush check in blk_mq_dispatch_rq_list Message-ID: <20230111054545.GB17158@lst.de> References: <20230111130159.3741753-1-shikemeng@huaweicloud.com> <20230111130159.3741753-11-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230111130159.3741753-11-shikemeng@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if ((!list_empty(list) || ret != BLK_STS_OK)) Plase drop the double braces.