Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Tue, 10 Jan 2023 22:27:37 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc:     XU pengfei <xupengfei@nfschina.com>,
        Jean Delvare <jdelvare@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/1] hwmon: powr1220: remove unnecessary (void*)
 conversions
Message-ID: <20230111062737.GA2257783@roeck-us.net>
References: <20230111043729.3792-1-xupengfei@nfschina.com>
 <efbc4e6f-b583-239b-439b-6ebc01ffe44d@gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <efbc4e6f-b583-239b-439b-6ebc01ffe44d@gnuweeb.org>
Precedence: bulk

On Wed, Jan 11, 2023 at 01:15:17PM +0700, Ammar Faizi wrote:
> On 1/11/23 11:37 AM, XU pengfei wrote:
> > Pointer variables of void * type do not require type cast.
> > 
> > Signed-off-by: XU pengfei <xupengfei@nfschina.com>
> > ---
> >   drivers/hwmon/powr1220.c | 2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/hwmon/powr1220.c b/drivers/hwmon/powr1220.c
> > index f77dc6db31ac..501337ee5aa3 100644
> > --- a/drivers/hwmon/powr1220.c
> > +++ b/drivers/hwmon/powr1220.c
> > @@ -174,7 +174,7 @@ static umode_t
> >   powr1220_is_visible(const void *data, enum hwmon_sensor_types type, u32
> >   		    attr, int channel)
> >   {
> > -	struct powr1220_data *chip_data = (struct powr1220_data *)data;
> > +	struct powr1220_data *chip_data = data;
> 
> Broken:
> 
>   CC [M]  drivers/hwmon/powr1220.o
> drivers/hwmon/powr1220.c: In function ‘powr1220_is_visible’:
> drivers/hwmon/powr1220.c:177:43: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>   177 |         struct powr1220_data *chip_data = data;
>       |                                           ^~~~
> cc1: all warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:249: drivers/hwmon/powr1220.o] Error 1
> make[1]: *** [scripts/Makefile.build:465: drivers/hwmon] Error 2
> make: *** [Makefile:1853: drivers] Error 2
> 

Thanks for catching. Sigh. Wouldn't it be nice if submitters would
at least build test their patches ?

Guenter