Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 15:24:20 +0800
From:   Li Chen <me@linux.beauty>
To:     "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc:     "rafael j. wysocki" <rafael@kernel.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>
Message-ID: <1859fb7306f.116a8646a961741.7679135125847887822@linux.beauty>
In-Reply-To: <Y75Wbya+U9F9UPJO@kroah.com>
References: <20230111061541.3657154-1-me@linux.beauty> <Y75Wbya+U9F9UPJO@kroah.com>
Subject: Re: [PATCH] debugfs: allow to use regmap for print regs
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Importance: Medium
User-Agent: Zoho Mail
Precedence: bulk

Hi Greg,

 > >  void debugfs_print_regs32(struct seq_file *s, const struct debugfs_re=
g32 *regs,
 > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0  int nregs, void __iomem *base, char *prefix)
 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0  int nregs, void __iomem *base, struct regmap *regmap,
 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0  char *prefix)
 >=20
 > This is confusing, please just provide a new function for regmap instead
 > of trying to overload this function.  You can use the same function
 > inside the debugfs core like this, but never export such a complex set
 > of parameters to actual users, that's just painful.

Thanks for your review, updated in v2.

Regards,
Li