Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data
 type file and Kconfig Makefile
From:   =?utf-8?Q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>
In-Reply-To: <20230111020233.4306-1-wangweidong.a@awinic.com>
Date:   Wed, 11 Jan 2023 09:38:47 +0100
Cc:     lkp@intel.com, 13691752556@139.com,
        Linux-ALSA <alsa-devel@alsa-project.org>,
        Mark Brown <broonie@kernel.org>, cezary.rojewski@intel.com,
        ckeepax@opensource.cirrus.com, daniel.beer@igorinstitute.com,
        devicetree@vger.kernel.org, flatmax@flatmax.com,
        james.schulman@cirrus.com, jonathan.albrieux@gmail.com,
        krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com,
        linux-kernel@vger.kernel.org, liweilei@awinic.com,
        llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
        perex@perex.cz, pierre-louis.bossart@linux.intel.com,
        rf@opensource.cirrus.com, robh+dt@kernel.org,
        srinivas.kandagatla@linaro.org, steve@sk2.org, tiwai@suse.com,
        yangxiaohua@everest-semi.com, yijiangtao@awinic.com,
        zhaolei@awinic.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <5EA7B038-9B49-4E5D-8209-8689C0D03071@cutebit.org>
References: <202301100233.QuEJ8pyu-lkp@intel.com>
 <20230111020233.4306-1-wangweidong.a@awinic.com>
To:     wangweidong.a@awinic.com
Precedence: bulk


> On 11. 1. 2023, at 3:02, wangweidong.a@awinic.com wrote:
>=20
> On 09/01/2023 03:00, kernel test robot wrote:

>> All errors (new ones prefixed by >>):
>=20
>>>> ld.lld: error: undefined symbol: crc8_populate_lsb
>>>>> referenced by aw883xx_bin_parse.c:1049 =
(sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1049)
>>>>>              vmlinux.o:(aw883xx_dev_load_acf_check)
>> --
>>>> ld.lld: error: undefined symbol: crc8
>>>>> referenced by aw883xx_bin_parse.c:963 =
(sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:963)
>>>>>              vmlinux.o:(aw883xx_dev_load_acf_check)
>>>>> referenced by aw883xx_bin_parse.c:1022 =
(sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1022)
>>>>>              vmlinux.o:(aw883xx_dev_load_acf_check)
>>>>> did you mean: crc4
>>>>> defined in: vmlinux.o
>=20
> This looks like a false positive. crc8_populate_lsb is defined in the =
lib/crc8.c file.
> I also could not reproduce it with GCC.

Hi,

the issue here would be that it=E2=80=99s possible to select your driver =
for compilation without
having selected the CRC8 functions, leading to the linkage error.

You can fix that by adding =E2=80=99select CRC8=E2=80=99 under the =
Kconfig section of your driver, similarly
to how the SND_SOC_SIGMADSP symbol selects CRC32.

Best regards,
Martin

>=20
> Best regards,
> Weidong Wang