Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ba52e6b4-33ec-622e-00b6-1b098f529a90@ideasonboard.com>
Date:   Wed, 11 Jan 2023 14:32:17 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v3 0/7] staging: vc04_services: Remove custom return
 values
To:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Cc:     Kees Cook <keescook@chromium.org>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Adrien Thierry <athierry@redhat.com>,
        Dan Carpenter <error27@gmail.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        Kieran Bingham <kieran.bingham@ideasonboard.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
References: <20221223122404.170585-1-umang.jain@ideasonboard.com>
Content-Language: en-US
From:   Umang Jain <umang.jain@ideasonboard.com>
In-Reply-To: <20221223122404.170585-1-umang.jain@ideasonboard.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi all,

Gentle ping for review, If it's needs more iterations or ready to be 
accepted...

Thanks,
Umang

On 12/23/22 5:53 PM, Umang Jain wrote:
> The series removes the custom return values from functions
> and replaces them with linux error codes. This address the TODO
>   vchiq interface:
> * Get rid of custom function return values
>
> Changes in v3:
> - Drop fixes tag for 5/7 as suggested in review
> - Add Tested-by: by Stefan Wahren to the series
>
> Changes in V2:
> - Patch 3/7 now reports for specific errors like -ENOMEM, -EHOSTDOWN
> - Patch 5/7 reports -ENOTCONN instead of -EINVAL and adds a "Fixes" tag
>
> Umang Jain (7):
>    staging: vc04_services: Replace vchiq_status return type to int
>    staging: vc04_services: Drop VCHIQ_SUCCESS usage
>    staging: vc04_services: Drop VCHIQ_ERROR usage
>    staging: vc04_services: Drop VCHIQ_RETRY usage
>    vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect
>    staging: vc04_services: Drop enum vchiq_status remnants
>    staging: vc04_services: vchiq: Drop custom return values from TODO
>
>   .../bcm2835-audio/bcm2835-vchiq.c             |  12 +-
>   .../include/linux/raspberrypi/vchiq.h         |  65 +++---
>   drivers/staging/vc04_services/interface/TODO  |   5 -
>   .../interface/vchiq_arm/vchiq_arm.c           | 124 +++++-----
>   .../interface/vchiq_arm/vchiq_arm.h           |  12 +-
>   .../interface/vchiq_arm/vchiq_core.c          | 216 +++++++++---------
>   .../interface/vchiq_arm/vchiq_core.h          |  18 +-
>   .../interface/vchiq_arm/vchiq_dev.c           |  36 +--
>   .../interface/vchiq_arm/vchiq_ioctl.h         |   8 +-
>   .../vc04_services/vchiq-mmal/mmal-vchiq.c     |  11 +-
>   10 files changed, 246 insertions(+), 261 deletions(-)
>