Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8042dcd4-41e6-a18d-3899-8f6d2696068a@suse.cz>
Date:   Wed, 11 Jan 2023 10:07:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] mm/slab.c: Delete the if judgment and return the result
 directly Remove the if judgment and return the result directly to reduce
 assembly statements.
Content-Language: en-US
To:     lvqian@nfschina.com, cl@linux.co, penberg@kernel.org,
        rientjes@google.com, kim@lge.com, akpm@linux-foundation.org,
        roman.gushchin@linux.dev, 42.hyeyoo@gmail.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20230111083102.111535-1-lvqian@nfschina.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20230111083102.111535-1-lvqian@nfschina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/11/23 09:31, lvqian@nfschina.com wrote:
> From: lvqian <lvqian@nfschina.com>

The subject line is long, e.g. the second sentence should be part of body,
not subject.

Note the usual wording is "if statement" not "judgement"

> Remove the if judgment and return the result directly to reduce assembly  statements.

I'm pretty sure there will be no effect on generated code/assembly, so it
should be purely about the C code readability. That's somewhat subjective,
but I think it's acceptable in this case.

> diff --git a/mm/slab.c b/mm/slab.c
> index 7a269db050ee..713265fe2dea 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1415,11 +1415,8 @@ static void kmem_rcu_free(struct rcu_head *head)
>  #if DEBUG
>  static bool is_debug_pagealloc_cache(struct kmem_cache *cachep)
>  {
> -	if (debug_pagealloc_enabled_static() && OFF_SLAB(cachep) &&
> -		(cachep->size % PAGE_SIZE) == 0)
> -		return true;
> -
> -	return false;
> +	return debug_pagealloc_enabled_static() && OFF_SLAB(cachep) &&
> +			((cachep->size % PAGE_SIZE) == 0);
>  }
>  
>  #ifdef CONFIG_DEBUG_PAGEALLOC