Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org>
Date:   Wed, 11 Jan 2023 11:00:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] arm64: dts: qcom: sm8450: Add TCSR halt register space
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Mukesh Ojha <quic_mojha@quicinc.com>, agross@kernel.org,
        andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1673428818-26112-1-git-send-email-quic_mojha@quicinc.com>
 <ab6a99da-e91b-20de-3126-3f1f94ce277b@linaro.org>
In-Reply-To: <ab6a99da-e91b-20de-3126-3f1f94ce277b@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/01/2023 10:59, Krzysztof Kozlowski wrote:
> On 11/01/2023 10:20, Mukesh Ojha wrote:
>> Add TCSR register space and refer it from scm node, so that
>> it can be used by SCM driver.
>>
>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 5704750..e0fa733 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -270,6 +270,7 @@
>>  	firmware {
>>  		scm: scm {
>>  			compatible = "qcom,scm-sm8450", "qcom,scm";
>> +			qcom,dload-mode = <&tcsr 0x13000>;
>>  			interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
>>  			#reset-cells = <1>;
>>  		};
>> @@ -1986,6 +1987,11 @@
>>  			#hwlock-cells = <1>;
>>  		};
>>  
>> +		tcsr: syscon@1fc0000 {
>> +			compatible = "syscon";
> 
> This is not allowed by itself. 

Eh, that was not proper English... I wanted to say: This is not allowed
on its own. You need specific compatible. ALWAYS.

> You should have warnings when running
> dtbs_check.
> 
> Best regards,
> Krzysztof
> 

Best regards,
Krzysztof